mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa+renesas@sang-engineering.com>
To: Krzysztof Kozlowski <krzysztof.kozlowski@oss.qualcomm.com>
Cc: Jonathan Corbet <corbet@lwn.net>,
	Shuah Khan <skhan@linuxfoundation.org>,
	Randy Dunlap <rdunlap@infradead.org>,
	workflows@vger.kernel.org, linux-doc@vger.kernel.org,
	linux-kernel@vger.kernel.org,
	Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Subject: Re: [PATCH v2] docs: submitting-patches: Clarify half-baked review tags
Date: Thu, 5 Nov 2026 13:19:14 +0200	[thread overview]
Message-ID: <auxmMrANvWIJi94i@shikoro> (raw)
In-Reply-To: <8abb2394-5210-495f-8420-a02bd16ff466@oss.qualcomm.com>


> >> "Reviewed-by:, instead, indicates that *the patch* has been reviewed and
> >> found acceptable according to the Reviewer's Statement:"
> > 
> > So, for the SPI patch: if someone spent time and reviewed the complex
> > core changes, but only 2 out of dozens of drivers, this would be an Ack
> > according to you. I would, however, understand that this person doesn't
> 
> No, and I explained this in this commit msg. That person reviewed the
> MAIN concept of the patch.

With that MAIN concept emphasized, I am okay with your reasoning and
agree. Before (I cite, upmost paragraph) "*the patch*" could be
interpreted as 100% of the patch (including dumb driver conversions).

> "Reviewing pieces of the patch while ignoring the main part of it, is
> much closer to Acknowledgment, thus Ack, and "Reviewed-by" credit should
> not be applicable."

I agree. As stated before, I don't care so much. I am glad you do :)
I'll happily take the "# subpart" potion of your patch here.

> Nowhere in my patch here I said you CANNOT review part of the patch or
> cannot even leave Rb tag for such case, right? What are we discussing
> now, exactly?

I hope the misunderstanding has been resolved in the first paragraph.

> Do you agree that if person skips the main point of the patch, the hard
> part, and reviews only less important part, that looks more as an Ack,
> than Rb, considering how "Reviewer's statement of oversight" is worded?

Sure. It is not so important to me, but yes, I agree.


  reply	other threads:[~2026-11-05 11:19 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-05  8:27 Krzysztof Kozlowski
2026-11-05  8:50 ` Wolfram Sang
2026-11-05  8:57   ` Krzysztof Kozlowski
2026-11-05  9:06     ` Wolfram Sang
2026-11-05  9:12       ` Krzysztof Kozlowski
2026-11-05  9:26         ` Andy Shevchenko
2026-11-05 10:59           ` Krzysztof Kozlowski
2026-11-05  9:28         ` Wolfram Sang
2026-11-05 11:03           ` Krzysztof Kozlowski
2026-11-05 11:19             ` Wolfram Sang [this message]
2026-11-05 11:53               ` Andy Shevchenko
2026-11-05 12:56                 ` Krzysztof Kozlowski
2026-11-05 14:14                   ` Andy Shevchenko
2026-11-05  9:29       ` Geert Uytterhoeven
2026-11-05  9:44         ` Wolfram Sang
2026-11-05  9:47           ` Andy Shevchenko
2026-11-05  9:19 ` Andy Shevchenko
2026-11-05  9:27   ` Krzysztof Kozlowski
2026-11-05  9:48     ` Andy Shevchenko
2026-11-05 10:55       ` Krzysztof Kozlowski
2026-11-05  9:30   ` Jürgen Groß
2026-11-05 15:33     ` Krzysztof Kozlowski
2026-11-05 15:44       ` Juergen Gross
2026-11-05 15:53         ` Krzysztof Kozlowski
2026-11-05 15:59           ` Jürgen Groß
2026-11-05 16:22             ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=auxmMrANvWIJi94i@shikoro \
    --to=wsa+renesas@sang-engineering.com \
    --cc=andriy.shevchenko@linux.intel.com \
    --cc=corbet@lwn.net \
    --cc=krzysztof.kozlowski@oss.qualcomm.com \
    --cc=linux-doc@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    --cc=skhan@linuxfoundation.org \
    --cc=workflows@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®