From: Alex Shi <alex.shi@intel.com>
To: rob@landley.net, mingo@redhat.com, peterz@infradead.org
Cc: gregkh@linuxfoundation.org, andre.przywara@amd.com, rjw@sisk.pl,
paul.gortmaker@windriver.com, akpm@linux-foundation.org,
paulmck@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
pjt@google.com, vincent.guittot@linaro.org
Subject: [PATCH 09/18] Revert "sched: Introduce temporary FAIR_GROUP_SCHED dependency for load-tracking"
Date: Mon, 10 Dec 2012 16:22:25 +0800 [thread overview]
Message-ID: <1355127754-8444-10-git-send-email-alex.shi@intel.com> (raw)
In-Reply-To: <1355127754-8444-1-git-send-email-alex.shi@intel.com>
This reverts commit f4e26b120b9de84cb627bc7361ba43cfdc51341f
Signed-off-by: Alex Shi <alex.shi@intel.com>
---
include/linux/sched.h | 8 +-------
kernel/sched/core.c | 7 +------
kernel/sched/fair.c | 13 ++-----------
kernel/sched/sched.h | 9 +--------
4 files changed, 5 insertions(+), 32 deletions(-)
diff --git a/include/linux/sched.h b/include/linux/sched.h
index 093f9cd..62dbc74 100644
--- a/include/linux/sched.h
+++ b/include/linux/sched.h
@@ -1184,13 +1184,7 @@ struct sched_entity {
/* rq "owned" by this entity/group: */
struct cfs_rq *my_q;
#endif
-/*
- * Load-tracking only depends on SMP, FAIR_GROUP_SCHED dependency below may be
- * removed when useful for applications beyond shares distribution (e.g.
- * load-balance).
- */
-#if defined(CONFIG_SMP) && defined(CONFIG_FAIR_GROUP_SCHED)
- /* Per-entity load-tracking */
+#ifdef CONFIG_SMP
struct sched_avg avg;
#endif
};
diff --git a/kernel/sched/core.c b/kernel/sched/core.c
index 0ecb907..05167f0 100644
--- a/kernel/sched/core.c
+++ b/kernel/sched/core.c
@@ -1526,12 +1526,7 @@ static void __sched_fork(struct task_struct *p)
p->se.vruntime = 0;
INIT_LIST_HEAD(&p->se.group_node);
-/*
- * Load-tracking only depends on SMP, FAIR_GROUP_SCHED dependency below may be
- * removed when useful for applications beyond shares distribution (e.g.
- * load-balance).
- */
-#if defined(CONFIG_SMP) && defined(CONFIG_FAIR_GROUP_SCHED)
+#ifdef CONFIG_SMP
p->se.avg.runnable_avg_period = 0;
p->se.avg.runnable_avg_sum = 0;
p->se.avg.decay_count = 0;
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index bbb069c..55c7e4f 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -882,8 +882,7 @@ static inline void update_cfs_shares(struct cfs_rq *cfs_rq)
}
#endif /* CONFIG_FAIR_GROUP_SCHED */
-/* Only depends on SMP, FAIR_GROUP_SCHED may be removed when useful in lb */
-#if defined(CONFIG_SMP) && defined(CONFIG_FAIR_GROUP_SCHED)
+#ifdef CONFIG_SMP
/*
* We choose a half-life close to 1 scheduling period.
* Note: The tables below are dependent on this value.
@@ -3165,12 +3164,6 @@ unlock:
}
/*
- * Load-tracking only depends on SMP, FAIR_GROUP_SCHED dependency below may be
- * removed when useful for applications beyond shares distribution (e.g.
- * load-balance).
- */
-#ifdef CONFIG_FAIR_GROUP_SCHED
-/*
* Called immediately before a task is migrated to a new cpu; task_cpu(p) and
* cfs_rq_of(p) references at time of call are still valid and identify the
* previous cpu. However, the caller only guarantees p->pi_lock is held; no
@@ -3193,7 +3186,6 @@ migrate_task_rq_fair(struct task_struct *p, int next_cpu)
atomic64_add(se->avg.load_avg_contrib, &cfs_rq->removed_load);
}
}
-#endif
#endif /* CONFIG_SMP */
static unsigned long
@@ -5894,9 +5886,8 @@ const struct sched_class fair_sched_class = {
#ifdef CONFIG_SMP
.select_task_rq = select_task_rq_fair,
-#ifdef CONFIG_FAIR_GROUP_SCHED
.migrate_task_rq = migrate_task_rq_fair,
-#endif
+
.rq_online = rq_online_fair,
.rq_offline = rq_offline_fair,
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 5eca173..0a75a43 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -225,12 +225,6 @@ struct cfs_rq {
#endif
#ifdef CONFIG_SMP
-/*
- * Load-tracking only depends on SMP, FAIR_GROUP_SCHED dependency below may be
- * removed when useful for applications beyond shares distribution (e.g.
- * load-balance).
- */
-#ifdef CONFIG_FAIR_GROUP_SCHED
/*
* CFS Load tracking
* Under CFS, load is tracked on a per-entity basis and aggregated up.
@@ -240,8 +234,7 @@ struct cfs_rq {
u64 runnable_load_avg, blocked_load_avg;
atomic64_t decay_counter, removed_load;
u64 last_decay;
-#endif /* CONFIG_FAIR_GROUP_SCHED */
-/* These always depend on CONFIG_FAIR_GROUP_SCHED */
+
#ifdef CONFIG_FAIR_GROUP_SCHED
u32 tg_runnable_contrib;
u64 tg_load_contrib;
--
1.7.5.1
next prev parent reply other threads:[~2012-12-10 8:26 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 8:22 [PATCH 0/18] sched: simplified fork, enable load average into LB and power awareness scheduling Alex Shi
2012-12-10 8:22 ` [PATCH 01/18] sched: select_task_rq_fair clean up Alex Shi
2012-12-11 4:23 ` Preeti U Murthy
2012-12-11 5:28 ` Alex Shi
2012-12-11 6:30 ` Preeti U Murthy
2012-12-11 11:53 ` Alex Shi
2012-12-12 5:26 ` Preeti U Murthy
2012-12-21 4:28 ` Namhyung Kim
2012-12-23 12:17 ` Alex Shi
2012-12-10 8:22 ` [PATCH 02/18] sched: fix find_idlest_group mess logical Alex Shi
2012-12-11 5:08 ` Preeti U Murthy
2012-12-11 5:29 ` Alex Shi
2012-12-11 5:50 ` Preeti U Murthy
2012-12-11 11:55 ` Alex Shi
2012-12-10 8:22 ` [PATCH 03/18] sched: don't need go to smaller sched domain Alex Shi
2012-12-10 8:22 ` [PATCH 04/18] sched: remove domain iterations in fork/exec/wake Alex Shi
2012-12-10 8:22 ` [PATCH 05/18] sched: load tracking bug fix Alex Shi
2012-12-10 8:22 ` [PATCH 06/18] sched: set initial load avg of new forked task as its load weight Alex Shi
2012-12-21 4:33 ` Namhyung Kim
2012-12-23 12:00 ` Alex Shi
2012-12-10 8:22 ` [PATCH 07/18] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task Alex Shi
2012-12-12 3:57 ` Preeti U Murthy
2012-12-12 5:52 ` Alex Shi
2012-12-13 8:45 ` Alex Shi
2012-12-21 4:35 ` Namhyung Kim
2012-12-23 11:42 ` Alex Shi
2012-12-10 8:22 ` [PATCH 08/18] sched: consider runnable load average in move_tasks Alex Shi
2012-12-12 4:41 ` Preeti U Murthy
2012-12-12 6:26 ` Alex Shi
2012-12-21 4:43 ` Namhyung Kim
2012-12-23 12:29 ` Alex Shi
2012-12-10 8:22 ` Alex Shi [this message]
2012-12-10 8:22 ` [PATCH 10/18] sched: add sched_policy in kernel Alex Shi
2012-12-10 8:22 ` [PATCH 11/18] sched: add sched_policy and it's sysfs interface Alex Shi
2012-12-10 8:22 ` [PATCH 12/18] sched: log the cpu utilization at rq Alex Shi
2012-12-10 8:22 ` [PATCH 13/18] sched: add power aware scheduling in fork/exec/wake Alex Shi
2012-12-10 8:22 ` [PATCH 14/18] sched: add power/performance balance allowed flag Alex Shi
2012-12-10 8:22 ` [PATCH 15/18] sched: don't care if the local group has capacity Alex Shi
2012-12-10 8:22 ` [PATCH 16/18] sched: pull all tasks from source group Alex Shi
2012-12-10 8:22 ` [PATCH 17/18] sched: power aware load balance, Alex Shi
2012-12-10 8:22 ` [PATCH 18/18] sched: lazy powersaving balance Alex Shi
2012-12-11 0:51 ` [PATCH 0/18] sched: simplified fork, enable load average into LB and power awareness scheduling Alex Shi
2012-12-11 12:10 ` Alex Shi
2012-12-11 15:48 ` Borislav Petkov
2012-12-11 16:03 ` Arjan van de Ven
2012-12-11 16:13 ` Borislav Petkov
2012-12-11 16:40 ` Arjan van de Ven
2012-12-12 9:52 ` Amit Kucheria
2012-12-12 13:55 ` Alex Shi
2012-12-12 14:21 ` Vincent Guittot
2012-12-13 2:51 ` Alex Shi
2012-12-12 14:41 ` Borislav Petkov
2012-12-13 3:07 ` Alex Shi
2012-12-13 11:35 ` Borislav Petkov
2012-12-14 1:56 ` Alex Shi
2012-12-12 1:14 ` Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355127754-8444-10-git-send-email-alex.shi@intel.com \
--to=alex.shi@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andre.przywara@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paul.gortmaker@windriver.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=rjw@sisk.pl \
--cc=rob@landley.net \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®