From: Alex Shi <alex.shi@intel.com>
To: rob@landley.net, mingo@redhat.com, peterz@infradead.org
Cc: gregkh@linuxfoundation.org, andre.przywara@amd.com, rjw@sisk.pl,
paul.gortmaker@windriver.com, akpm@linux-foundation.org,
paulmck@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
pjt@google.com, vincent.guittot@linaro.org
Subject: [PATCH 15/18] sched: don't care if the local group has capacity
Date: Mon, 10 Dec 2012 16:22:31 +0800 [thread overview]
Message-ID: <1355127754-8444-16-git-send-email-alex.shi@intel.com> (raw)
In-Reply-To: <1355127754-8444-1-git-send-email-alex.shi@intel.com>
In power aware scheduling, we don't care load weight and
want not to pull tasks just because local group has capacity.
Because the local group maybe no tasks at the time, that is the power
balance hope so.
Signed-off-by: Alex Shi <alex.shi@intel.com>
---
kernel/sched/fair.c | 6 +++++-
1 files changed, 5 insertions(+), 1 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 57a85cc..fe0ba07 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -4496,8 +4496,12 @@ static inline void update_sd_lb_stats(struct lb_env *env,
* extra check prevents the case where you always pull from the
* heaviest group when it is already under-utilized (possible
* with a large weight task outweighs the tasks on the system).
+ *
+ * In power aware scheduling, we don't care load weight and
+ * want not to pull tasks just because local group has capacity.
*/
- if (prefer_sibling && !local_group && sds->this_has_capacity)
+ if (prefer_sibling && !local_group && sds->this_has_capacity
+ && env->perf_lb)
sgs.group_capacity = min(sgs.group_capacity, 1UL);
if (local_group) {
--
1.7.5.1
next prev parent reply other threads:[~2012-12-10 8:26 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 8:22 [PATCH 0/18] sched: simplified fork, enable load average into LB and power awareness scheduling Alex Shi
2012-12-10 8:22 ` [PATCH 01/18] sched: select_task_rq_fair clean up Alex Shi
2012-12-11 4:23 ` Preeti U Murthy
2012-12-11 5:28 ` Alex Shi
2012-12-11 6:30 ` Preeti U Murthy
2012-12-11 11:53 ` Alex Shi
2012-12-12 5:26 ` Preeti U Murthy
2012-12-21 4:28 ` Namhyung Kim
2012-12-23 12:17 ` Alex Shi
2012-12-10 8:22 ` [PATCH 02/18] sched: fix find_idlest_group mess logical Alex Shi
2012-12-11 5:08 ` Preeti U Murthy
2012-12-11 5:29 ` Alex Shi
2012-12-11 5:50 ` Preeti U Murthy
2012-12-11 11:55 ` Alex Shi
2012-12-10 8:22 ` [PATCH 03/18] sched: don't need go to smaller sched domain Alex Shi
2012-12-10 8:22 ` [PATCH 04/18] sched: remove domain iterations in fork/exec/wake Alex Shi
2012-12-10 8:22 ` [PATCH 05/18] sched: load tracking bug fix Alex Shi
2012-12-10 8:22 ` [PATCH 06/18] sched: set initial load avg of new forked task as its load weight Alex Shi
2012-12-21 4:33 ` Namhyung Kim
2012-12-23 12:00 ` Alex Shi
2012-12-10 8:22 ` [PATCH 07/18] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task Alex Shi
2012-12-12 3:57 ` Preeti U Murthy
2012-12-12 5:52 ` Alex Shi
2012-12-13 8:45 ` Alex Shi
2012-12-21 4:35 ` Namhyung Kim
2012-12-23 11:42 ` Alex Shi
2012-12-10 8:22 ` [PATCH 08/18] sched: consider runnable load average in move_tasks Alex Shi
2012-12-12 4:41 ` Preeti U Murthy
2012-12-12 6:26 ` Alex Shi
2012-12-21 4:43 ` Namhyung Kim
2012-12-23 12:29 ` Alex Shi
2012-12-10 8:22 ` [PATCH 09/18] Revert "sched: Introduce temporary FAIR_GROUP_SCHED dependency for load-tracking" Alex Shi
2012-12-10 8:22 ` [PATCH 10/18] sched: add sched_policy in kernel Alex Shi
2012-12-10 8:22 ` [PATCH 11/18] sched: add sched_policy and it's sysfs interface Alex Shi
2012-12-10 8:22 ` [PATCH 12/18] sched: log the cpu utilization at rq Alex Shi
2012-12-10 8:22 ` [PATCH 13/18] sched: add power aware scheduling in fork/exec/wake Alex Shi
2012-12-10 8:22 ` [PATCH 14/18] sched: add power/performance balance allowed flag Alex Shi
2012-12-10 8:22 ` Alex Shi [this message]
2012-12-10 8:22 ` [PATCH 16/18] sched: pull all tasks from source group Alex Shi
2012-12-10 8:22 ` [PATCH 17/18] sched: power aware load balance, Alex Shi
2012-12-10 8:22 ` [PATCH 18/18] sched: lazy powersaving balance Alex Shi
2012-12-11 0:51 ` [PATCH 0/18] sched: simplified fork, enable load average into LB and power awareness scheduling Alex Shi
2012-12-11 12:10 ` Alex Shi
2012-12-11 15:48 ` Borislav Petkov
2012-12-11 16:03 ` Arjan van de Ven
2012-12-11 16:13 ` Borislav Petkov
2012-12-11 16:40 ` Arjan van de Ven
2012-12-12 9:52 ` Amit Kucheria
2012-12-12 13:55 ` Alex Shi
2012-12-12 14:21 ` Vincent Guittot
2012-12-13 2:51 ` Alex Shi
2012-12-12 14:41 ` Borislav Petkov
2012-12-13 3:07 ` Alex Shi
2012-12-13 11:35 ` Borislav Petkov
2012-12-14 1:56 ` Alex Shi
2012-12-12 1:14 ` Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1355127754-8444-16-git-send-email-alex.shi@intel.com \
--to=alex.shi@intel.com \
--cc=akpm@linux-foundation.org \
--cc=andre.przywara@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paul.gortmaker@windriver.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=rjw@sisk.pl \
--cc=rob@landley.net \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®