From: Namhyung Kim <namhyung@kernel.org>
To: Alex Shi <alex.shi@intel.com>
Cc: Preeti U Murthy <preeti@linux.vnet.ibm.com>,
rob@landley.net, mingo@redhat.com, peterz@infradead.org,
gregkh@linuxfoundation.org, andre.przywara@amd.com, rjw@sisk.pl,
paul.gortmaker@windriver.com, akpm@linux-foundation.org,
paulmck@linux.vnet.ibm.com, linux-kernel@vger.kernel.org,
pjt@google.com, vincent.guittot@linaro.org
Subject: Re: [PATCH 08/18] sched: consider runnable load average in move_tasks
Date: Fri, 21 Dec 2012 13:43:43 +0900 [thread overview]
Message-ID: <871uekf20w.fsf@sejong.aot.lge.com> (raw)
In-Reply-To: <50C823A4.109@intel.com> (Alex Shi's message of "Wed, 12 Dec 2012 14:26:44 +0800")
On Wed, 12 Dec 2012 14:26:44 +0800, Alex Shi wrote:
> On 12/12/2012 12:41 PM, Preeti U Murthy wrote:
>> Also why can't p->se.load_avg_contrib be used directly? as a return
>> value for task_h_load_avg? since this is already updated in
>> update_task_entity_contrib and update_group_entity_contrib.
>
> No, only non task entity goes to update_group_entity_contrib. not task
> entity.
???
But task entity goes to __update_task_entity_contrib()?
/* Compute the current contribution to load_avg by se, return any delta */
static long __update_entity_load_avg_contrib(struct sched_entity *se)
{
long old_contrib = se->avg.load_avg_contrib;
if (entity_is_task(se)) {
__update_task_entity_contrib(se);
} else {
__update_tg_runnable_avg(&se->avg, group_cfs_rq(se));
__update_group_entity_contrib(se);
}
return se->avg.load_avg_contrib - old_contrib;
}
Thanks,
Namhyung
next prev parent reply other threads:[~2012-12-21 4:43 UTC|newest]
Thread overview: 56+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-12-10 8:22 [PATCH 0/18] sched: simplified fork, enable load average into LB and power awareness scheduling Alex Shi
2012-12-10 8:22 ` [PATCH 01/18] sched: select_task_rq_fair clean up Alex Shi
2012-12-11 4:23 ` Preeti U Murthy
2012-12-11 5:28 ` Alex Shi
2012-12-11 6:30 ` Preeti U Murthy
2012-12-11 11:53 ` Alex Shi
2012-12-12 5:26 ` Preeti U Murthy
2012-12-21 4:28 ` Namhyung Kim
2012-12-23 12:17 ` Alex Shi
2012-12-10 8:22 ` [PATCH 02/18] sched: fix find_idlest_group mess logical Alex Shi
2012-12-11 5:08 ` Preeti U Murthy
2012-12-11 5:29 ` Alex Shi
2012-12-11 5:50 ` Preeti U Murthy
2012-12-11 11:55 ` Alex Shi
2012-12-10 8:22 ` [PATCH 03/18] sched: don't need go to smaller sched domain Alex Shi
2012-12-10 8:22 ` [PATCH 04/18] sched: remove domain iterations in fork/exec/wake Alex Shi
2012-12-10 8:22 ` [PATCH 05/18] sched: load tracking bug fix Alex Shi
2012-12-10 8:22 ` [PATCH 06/18] sched: set initial load avg of new forked task as its load weight Alex Shi
2012-12-21 4:33 ` Namhyung Kim
2012-12-23 12:00 ` Alex Shi
2012-12-10 8:22 ` [PATCH 07/18] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task Alex Shi
2012-12-12 3:57 ` Preeti U Murthy
2012-12-12 5:52 ` Alex Shi
2012-12-13 8:45 ` Alex Shi
2012-12-21 4:35 ` Namhyung Kim
2012-12-23 11:42 ` Alex Shi
2012-12-10 8:22 ` [PATCH 08/18] sched: consider runnable load average in move_tasks Alex Shi
2012-12-12 4:41 ` Preeti U Murthy
2012-12-12 6:26 ` Alex Shi
2012-12-21 4:43 ` Namhyung Kim [this message]
2012-12-23 12:29 ` Alex Shi
2012-12-10 8:22 ` [PATCH 09/18] Revert "sched: Introduce temporary FAIR_GROUP_SCHED dependency for load-tracking" Alex Shi
2012-12-10 8:22 ` [PATCH 10/18] sched: add sched_policy in kernel Alex Shi
2012-12-10 8:22 ` [PATCH 11/18] sched: add sched_policy and it's sysfs interface Alex Shi
2012-12-10 8:22 ` [PATCH 12/18] sched: log the cpu utilization at rq Alex Shi
2012-12-10 8:22 ` [PATCH 13/18] sched: add power aware scheduling in fork/exec/wake Alex Shi
2012-12-10 8:22 ` [PATCH 14/18] sched: add power/performance balance allowed flag Alex Shi
2012-12-10 8:22 ` [PATCH 15/18] sched: don't care if the local group has capacity Alex Shi
2012-12-10 8:22 ` [PATCH 16/18] sched: pull all tasks from source group Alex Shi
2012-12-10 8:22 ` [PATCH 17/18] sched: power aware load balance, Alex Shi
2012-12-10 8:22 ` [PATCH 18/18] sched: lazy powersaving balance Alex Shi
2012-12-11 0:51 ` [PATCH 0/18] sched: simplified fork, enable load average into LB and power awareness scheduling Alex Shi
2012-12-11 12:10 ` Alex Shi
2012-12-11 15:48 ` Borislav Petkov
2012-12-11 16:03 ` Arjan van de Ven
2012-12-11 16:13 ` Borislav Petkov
2012-12-11 16:40 ` Arjan van de Ven
2012-12-12 9:52 ` Amit Kucheria
2012-12-12 13:55 ` Alex Shi
2012-12-12 14:21 ` Vincent Guittot
2012-12-13 2:51 ` Alex Shi
2012-12-12 14:41 ` Borislav Petkov
2012-12-13 3:07 ` Alex Shi
2012-12-13 11:35 ` Borislav Petkov
2012-12-14 1:56 ` Alex Shi
2012-12-12 1:14 ` Alex Shi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=871uekf20w.fsf@sejong.aot.lge.com \
--to=namhyung@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=alex.shi@intel.com \
--cc=andre.przywara@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=paul.gortmaker@windriver.com \
--cc=paulmck@linux.vnet.ibm.com \
--cc=peterz@infradead.org \
--cc=pjt@google.com \
--cc=preeti@linux.vnet.ibm.com \
--cc=rjw@sisk.pl \
--cc=rob@landley.net \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome