mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Pooventhiran G <pooventhiran.g@oss.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH wireless-next v4 14/21] wifi: mac80211: add driver_op for SMD substate changes
Date: Mon, 16 Nov 2026 12:32:39 +0100	[thread overview]
Message-ID: <13d0d8d00897f425ace949084cc0644d52a0e504.camel@sipsolutions.net> (raw)
In-Reply-To: <a743c654-14f8-435f-9b83-bccdf2865615@oss.qualcomm.com>

On Sat, 2026-11-14 at 00:50 +0530, Pooventhiran G wrote:
> 
> > > +void sta_info_reset_smd_state(struct sta_info *sta, bool notify)
> > > +{
> > > +	if (sta->smd_state == IEEE80211_STA_SMD_NONE)
> > > +		return;
> > > +
> > > +	/* DRAIN -> NONE, EXEC -> NONE or PREP -> NONE */
> > > +	WARN_ON_ONCE(sta_info_move_smd_state(sta, IEEE80211_STA_SMD_NONE,
> > > +					     notify));
> > 
> > How is that even useful? If we're talking about a sub-state while in
> > state 4, then surely moving out of state 4 simply invalidates that, why
> > bother?
> > 
> 
> True, thought I could clean up the roam states before that exact invalidation
> happens. I will remove it from state 4->3 transition.
> 
> > > +	clear_sta_flag(sta, WLAN_STA_SMD_PREP_TARGET);
> > > +	clear_sta_flag(sta, WLAN_STA_SMD_EXEC_CURRENT);
> > > +	clear_sta_flag(sta, WLAN_STA_SMD_DL_DRAIN);
> > 
> > Understand that you need to clear the stale flags, but for the driver
> > that just seems strange?
> > 
> 
> So, this is also called from state 4->3 transition so clearing the stale flags
> seems necessary. For the drv_sta_smd_state op as well, if we don't clear the
> state in mac80211, there will be inconsistency between driver and mac80211.

Wait, which way is it then? Anyway I'm not sure I see a lot of value in
moving the driver down when the whole state 4 is left later?

> > > +	case IEEE80211_STA_SMD_EXEC:
> > > +	case IEEE80211_STA_SMD_DRAIN:
> > > +		err = drv_sta_smd_state(local, sta->sdata, &sta->sta,
> > > +					IEEE80211_STA_SMD_NONE,
> > > +					IEEE80211_STA_SMD_EXEC);
> > > +		if (err)
> > > +			goto rollback;
> > > +
> > > +		if (new_ss == IEEE80211_STA_SMD_DRAIN)
> > > +			err = drv_sta_smd_state(local, sta->sdata, &sta->sta,
> > > +						IEEE80211_STA_SMD_EXEC,
> > > +						IEEE80211_STA_SMD_DRAIN);
> > > +		break;
> > 
> > you do realize "fallthrough" exists?
> > 
> 
> I am afraid I am not able to understand how fallthrough helps here. 

My bad, sorry! I mixed up the order of operations.

> > > +	/* if EXEC -> DRAIN failed in the driver, notify EXEC -> NONE */
> > > +	WARN_ON_ONCE(drv_sta_smd_state(local, sta->sdata, &sta->sta,
> > > +				       IEEE80211_STA_SMD_EXEC,
> > > +				       IEEE80211_STA_SMD_NONE));
> > 
> > I'm not a fan of sticking whole blocks of code into a WARN, but I'm also
> > not sure this whole "model what should be a one-way sub-state based on
> > sta_state" was a good idea in this patch.
> > 
> Could you please kindly clarify "model what should be a one-way sub-state
> based on sta_state"? Would you prefer if the driver was able to directly
> update the state as well?

Ah, no, I was just mostly thinking about the above discussion, and also
the whole substates.

For station _state_ I think it makes sense (mostly) to go have the
"ladder" of states (notexist <-> none <-> auth <-> assoc <-> authorized)
and clearly modelled it based on that.

But does that makes sense here? Why even go 4 -> 4b -> 4c as a substate
etc. Wouldn't it be a lot simpler to just say "this is the new substate"
deal with it? There's not a lot of "ladder" going on, the substates
don't really depend on each other as fundamentally. In fact, for 4a vs.
b/c they're not even a ladder anyway since that's completely different
use cases.

johannes

  reply	other threads:[~2026-11-16 11:32 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06  7:58 [PATCH wireless-next v4 00/21] wifi: Add Seamless Mobility Domain (SMD) AP support Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 01/21] wifi: nl80211: define Seamless Mobility Domain (SMD) device capability Pooventhiran G
2026-11-10 14:15   ` Johannes Berg
2026-11-10 14:26     ` Johannes Berg
2026-11-13 15:23       ` Pooventhiran G
2026-11-16 10:40         ` Johannes Berg
2026-11-06  7:58 ` [PATCH wireless-next v4 02/21] wifi: nl80211/cfg80211: define interfaces for SMD setup and STA update Pooventhiran G
2026-11-10 18:18   ` Johannes Berg
2026-11-06  7:58 ` [PATCH wireless-next v4 03/21] wifi: nl80211: add SMD BSS Transition sub-state STA flags Pooventhiran G
2026-11-10 18:27   ` Johannes Berg
2026-11-16 10:21     ` Pooventhiran G
2026-11-16 10:50       ` Johannes Berg
2026-11-06  7:58 ` [PATCH wireless-next v4 04/21] wifi: cfg80211: define layouts for SMD BSS Transition context Pooventhiran G
2026-11-10 18:39   ` Johannes Berg
2026-11-13 18:15     ` Pooventhiran G
2026-11-16 10:54       ` Johannes Berg
2026-11-06  7:58 ` [PATCH wireless-next v4 05/21] wifi: nl80211: define interfaces for SMD BSS Transition context transfer Pooventhiran G
2026-11-10 18:45   ` Johannes Berg
2026-11-13 16:45     ` Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 06/21] wifi: ieee80211: define APIs for UHR Link Reconfiguration frame checks Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 07/21] wifi: ieee80211: define API to check if frame is class 3 Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 08/21] wifi: nl80211/cfg80211: pack SMD dynamic context along with frame Pooventhiran G
2026-11-10 18:51   ` Johannes Berg
2026-11-13 18:17     ` Pooventhiran G
2026-11-16 11:00       ` Johannes Berg
2026-11-11  9:14   ` Allen Ye
2026-11-13 18:19     ` Pooventhiran G
2026-11-16  3:38       ` Allen Ye (葉芷勳)
2026-11-06  7:58 ` [PATCH wireless-next v4 09/21] wifi: nl80211/cfg80211: add support for SMD context programming Pooventhiran G
2026-11-10 18:55   ` Johannes Berg
2026-11-13 17:54     ` Pooventhiran G
2026-11-16 11:13       ` Johannes Berg
2026-11-06  7:58 ` [PATCH wireless-next v4 10/21] wifi: nl80211/cfg80211: add support for querying SMD context for target AP MLD Pooventhiran G
2026-11-10 19:00   ` Johannes Berg
2026-11-13 18:33     ` Pooventhiran G
2026-11-16 11:20       ` Johannes Berg
2026-11-06  7:58 ` [PATCH wireless-next v4 11/21] wifi: nl80211/cfg80211: define API to notify SMD Drain completion Pooventhiran G
2026-11-10 19:01   ` Johannes Berg
2026-11-13 18:38     ` Pooventhiran G
2026-11-16 11:23       ` Johannes Berg
2026-11-06  7:58 ` [PATCH wireless-next v4 12/21] wifi: mac80211: set SMD parameters for AP setup and STA update Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 13/21] wifi: mac80211: apply SMD BSS Transition STA sub-states Pooventhiran G
2026-11-10 20:29   ` Johannes Berg
2026-11-13 18:46     ` Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 14/21] wifi: mac80211: add driver_op for SMD substate changes Pooventhiran G
2026-11-10 20:38   ` Johannes Berg
2026-11-13 19:20     ` Pooventhiran G
2026-11-16 11:32       ` Johannes Berg [this message]
2026-11-06  7:58 ` [PATCH wireless-next v4 15/21] wifi: mac80211: filter uplink and downlink frames based on SMD states Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 16/21] wifi: mac80211: send BlockAck policy in AMPDU action Pooventhiran G
2026-11-10 20:43   ` Johannes Berg
2026-11-16 10:50     ` Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 17/21] wifi: mac80211: pass rx_data directly from ieee80211_rx_list() Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 18/21] wifi: mac80211: handle UHR Link Reconfiguration frame Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 19/21] wifi: mac80211: add mac80211 support to handle NL80211_CMD_SET_SMD_CTX Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 20/21] wifi: mac80211: add mac80211 support to handle NL80211_CMD_GET_SMD_CTX Pooventhiran G
2026-11-10 20:47   ` Johannes Berg
2026-11-13 19:22     ` Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 21/21] wifi: mac80211: define API to invoke SMD Drain Completion event Pooventhiran G
2026-11-10 20:49   ` Johannes Berg
2026-11-13 19:24     ` Pooventhiran G

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=13d0d8d00897f425ace949084cc0644d52a0e504.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pooventhiran.g@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®