mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Pooventhiran G <pooventhiran.g@oss.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH wireless-next v4 04/21] wifi: cfg80211: define layouts for SMD BSS Transition context
Date: Mon, 16 Nov 2026 11:54:34 +0100	[thread overview]
Message-ID: <c9ffcbff38996a38c293105d8db526673e572acc.camel@sipsolutions.net> (raw)
In-Reply-To: <b6cda6b5-adb0-403d-a2b4-d64939a967e7@oss.qualcomm.com>

On Fri, 2026-11-13 at 23:45 +0530, Pooventhiran G wrote:
> 
> On 11/11/2026 12:09 am, Johannes Berg wrote:
> > On Fri, 2026-11-06 at 13:28 +0530, Pooventhiran G wrote:
> > > IEEE P802.11bn/D2.0
> > > 
> > 
> > It probably didn't change here, but there's D2.1 :)
> > 
> 
> From the looks of it, D2.1 doesn't seem to modify the context layout but Dual
> BA :)
> 
> > > +#define IEEE80211_SMD_CTX_MAX_PN_LEN 16
> > 
> > Huh?
> > 
> 
> There is no cfg80211-equivalent for IEEE80211_MAX_PN_LEN as defined in mac80211.

We could move it, but I was much more questioning the *value*.

> > > + * @buffer_size: Reorder buffer size from ADDBA Request (10-bit, max 1023)
> > 
> > It's probably literally in this spec this way, but I see absolutely no
> > reason to split it up like that (with ext_buffer_size) in what's
> > effectively an internal API?!
> > 
> 
> Buffer size was sent this way so that hostapd can directly use that to report
> the DL BA Info and UL BA Info in the ST Preparation Response frame (Figure
> 9-aa53 — Extended BA Parameters Info field format).
> 
> I can combine these into one single @buffer_size and let hostapd split it for
> preparing the OTA frame (as it is only needed there) but would still need to
> send ext_no_frag and extfrag_level as part of the context. Would it be okay?

Oh I was just thinking of why you were splitting the buffer size in
internal APIs that way - much simpler to just have a single u16 (since
we don't have C23 yet) value?

> > > +/**
> > > + * struct ieee80211_smd_ctx - IEEE 802.11bn SMD Roaming Context (refer
> > > + *	IEEE P802.11bn/D2.0, Aug 2026, subclause 37.16.9)
> > > + *
> > > + * @dl_sn_valid: if downlink (DL) SN Transfer is requested or not
> > > + * @ul_sn_valid: if uplink (UL) SN Transfer is requested or not
> > 
> > Hmm. It might make more sense to invert that like in the frames?
> > 
> 
> Sure, will reorder this as UL, DL.

Oh I didn't mean the _order_, I don't even know what the order was, I
meant _invert_, i.e. "no_dl_sn_transfer" or something? That's how it's
in the frames, IIRC.

> > > + * @pn_valid: if PN is transferred or not
> > 
> > This being false is not a thing (any more)?
> > 
> 
> PN is still defined to be transferred in the Prep context (at least as per
> D2.0 37.16.9). Even if drivers choose to send this in the Exec context, it may
> not be present in both Prep and Exec contexts? Should we make it so that PN is
> transferred in both?

Oh ... no strong opinion, but the documentation literally says "is
transferred or not" and ... there's no "isn't transferred" option in the
spec (any more).

> 
> > > + * @ba_params_valid: if BlockAck parameters are transferred or not
> > > + * @mgmt_tid_valid: if management information is transferred or not.
> > > + *	@{d,u}l.mgmt_sn and @ul.mgmt_pn are still bounded by @{d,u}l_sn_valid
> > > + *	and @pn_valid fields.
> > > + * @pn_len: Length of PN in bytes; varies by cipher type
> > > + *	(e.g. CCMP (6), GCMP-256 (16))
> > 
> > ??
> > 
> 
> Especially while filling in the data in nl80211 to report to userspace or when
> we parse the SET_SMD_CTX from userspace, this eliminates the dependency on
> key_conf to derive the length from the cipher type. But is the preference here
> exactly that?

No, see above, what's with 16-byte PNs, there's no such thing.

johannes

  reply	other threads:[~2026-11-16 10:54 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06  7:58 [PATCH wireless-next v4 00/21] wifi: Add Seamless Mobility Domain (SMD) AP support Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 01/21] wifi: nl80211: define Seamless Mobility Domain (SMD) device capability Pooventhiran G
2026-11-10 14:15   ` Johannes Berg
2026-11-10 14:26     ` Johannes Berg
2026-11-13 15:23       ` Pooventhiran G
2026-11-16 10:40         ` Johannes Berg
2026-11-06  7:58 ` [PATCH wireless-next v4 02/21] wifi: nl80211/cfg80211: define interfaces for SMD setup and STA update Pooventhiran G
2026-11-10 18:18   ` Johannes Berg
2026-11-06  7:58 ` [PATCH wireless-next v4 03/21] wifi: nl80211: add SMD BSS Transition sub-state STA flags Pooventhiran G
2026-11-10 18:27   ` Johannes Berg
2026-11-16 10:21     ` Pooventhiran G
2026-11-16 10:50       ` Johannes Berg
2026-11-06  7:58 ` [PATCH wireless-next v4 04/21] wifi: cfg80211: define layouts for SMD BSS Transition context Pooventhiran G
2026-11-10 18:39   ` Johannes Berg
2026-11-13 18:15     ` Pooventhiran G
2026-11-16 10:54       ` Johannes Berg [this message]
2026-11-06  7:58 ` [PATCH wireless-next v4 05/21] wifi: nl80211: define interfaces for SMD BSS Transition context transfer Pooventhiran G
2026-11-10 18:45   ` Johannes Berg
2026-11-13 16:45     ` Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 06/21] wifi: ieee80211: define APIs for UHR Link Reconfiguration frame checks Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 07/21] wifi: ieee80211: define API to check if frame is class 3 Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 08/21] wifi: nl80211/cfg80211: pack SMD dynamic context along with frame Pooventhiran G
2026-11-10 18:51   ` Johannes Berg
2026-11-13 18:17     ` Pooventhiran G
2026-11-16 11:00       ` Johannes Berg
2026-11-11  9:14   ` Allen Ye
2026-11-13 18:19     ` Pooventhiran G
2026-11-16  3:38       ` Allen Ye (葉芷勳)
2026-11-06  7:58 ` [PATCH wireless-next v4 09/21] wifi: nl80211/cfg80211: add support for SMD context programming Pooventhiran G
2026-11-10 18:55   ` Johannes Berg
2026-11-13 17:54     ` Pooventhiran G
2026-11-16 11:13       ` Johannes Berg
2026-11-06  7:58 ` [PATCH wireless-next v4 10/21] wifi: nl80211/cfg80211: add support for querying SMD context for target AP MLD Pooventhiran G
2026-11-10 19:00   ` Johannes Berg
2026-11-13 18:33     ` Pooventhiran G
2026-11-16 11:20       ` Johannes Berg
2026-11-06  7:58 ` [PATCH wireless-next v4 11/21] wifi: nl80211/cfg80211: define API to notify SMD Drain completion Pooventhiran G
2026-11-10 19:01   ` Johannes Berg
2026-11-13 18:38     ` Pooventhiran G
2026-11-16 11:23       ` Johannes Berg
2026-11-06  7:58 ` [PATCH wireless-next v4 12/21] wifi: mac80211: set SMD parameters for AP setup and STA update Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 13/21] wifi: mac80211: apply SMD BSS Transition STA sub-states Pooventhiran G
2026-11-10 20:29   ` Johannes Berg
2026-11-13 18:46     ` Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 14/21] wifi: mac80211: add driver_op for SMD substate changes Pooventhiran G
2026-11-10 20:38   ` Johannes Berg
2026-11-13 19:20     ` Pooventhiran G
2026-11-16 11:32       ` Johannes Berg
2026-11-06  7:58 ` [PATCH wireless-next v4 15/21] wifi: mac80211: filter uplink and downlink frames based on SMD states Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 16/21] wifi: mac80211: send BlockAck policy in AMPDU action Pooventhiran G
2026-11-10 20:43   ` Johannes Berg
2026-11-16 10:50     ` Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 17/21] wifi: mac80211: pass rx_data directly from ieee80211_rx_list() Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 18/21] wifi: mac80211: handle UHR Link Reconfiguration frame Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 19/21] wifi: mac80211: add mac80211 support to handle NL80211_CMD_SET_SMD_CTX Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 20/21] wifi: mac80211: add mac80211 support to handle NL80211_CMD_GET_SMD_CTX Pooventhiran G
2026-11-10 20:47   ` Johannes Berg
2026-11-13 19:22     ` Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 21/21] wifi: mac80211: define API to invoke SMD Drain Completion event Pooventhiran G
2026-11-10 20:49   ` Johannes Berg
2026-11-13 19:24     ` Pooventhiran G

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=c9ffcbff38996a38c293105d8db526673e572acc.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pooventhiran.g@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®