mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Pooventhiran G <pooventhiran.g@oss.qualcomm.com>
Cc: linux-wireless@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH wireless-next v4 03/21] wifi: nl80211: add SMD BSS Transition sub-state STA flags
Date: Mon, 16 Nov 2026 11:50:36 +0100	[thread overview]
Message-ID: <7a83c6576a0797cfc009066ef768e2828284c212.camel@sipsolutions.net> (raw)
In-Reply-To: <aeb887e0-48c3-40d7-8e93-951231dd2ed0@oss.qualcomm.com>

On Mon, 2026-11-16 at 15:51 +0530, Pooventhiran G wrote:
> 
> > I'm also not sure why you need to distinguish between the latter two at
> > all, hostapd is going to send the ST execution response and immediately
> > transition to DL drain (4c) or back to 4 anyway?
> > 
> 
> The 4b/4c differentiation is needed to resolve frame filtering (especially UL
> data) since the requirements differ between these two states. There will be
> some time here between the reception of ST Exec Request (set 4b, communicate
> with the target AP MLD, and get the confirmation back) and sending the ST Exec
> Response to the non-AP STA MLD.

Well, technically yes, but there shouldn't _be_ any UL data (from a
compliant non-AP MLD). If that's the only reason, do we really want to
make the implementation more complex for effectively non-compliant
stations?

I understand that you need to get the ST context at some time between
those points, or already have it attached to the ST execution request
frame, and then receiving and accepting UL data from a non-compliant
peer will ... break things for that peer after it transitions. Actually
it's broken anyway, regardless of the AP dropping the frames, since the
peer continued to transmit. A (buggy or malicious) peer can already
duplicate the frame on the DS by just sending it multiple times. In your
(planned) implementation, the AP can't even protect against it fully
because the ST context snapshot is at the RX time, while moving the
state takes a hostapd reaction, unless you say that the FW also has to
move the state when it takes the ST context snapshot. In the case you
just discussed with Allen, you could move the state before taking the
context.

So ... that's a fairly long-winded way of saying "is it really worth
it"? It doesn't seem to buy either side anything if the peer isn't
compliant, and has no effect if it is compliant?

johannes

  reply	other threads:[~2026-11-16 10:50 UTC|newest]

Thread overview: 61+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-11-06  7:58 [PATCH wireless-next v4 00/21] wifi: Add Seamless Mobility Domain (SMD) AP support Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 01/21] wifi: nl80211: define Seamless Mobility Domain (SMD) device capability Pooventhiran G
2026-11-10 14:15   ` Johannes Berg
2026-11-10 14:26     ` Johannes Berg
2026-11-13 15:23       ` Pooventhiran G
2026-11-16 10:40         ` Johannes Berg
2026-11-06  7:58 ` [PATCH wireless-next v4 02/21] wifi: nl80211/cfg80211: define interfaces for SMD setup and STA update Pooventhiran G
2026-11-10 18:18   ` Johannes Berg
2026-11-06  7:58 ` [PATCH wireless-next v4 03/21] wifi: nl80211: add SMD BSS Transition sub-state STA flags Pooventhiran G
2026-11-10 18:27   ` Johannes Berg
2026-11-16 10:21     ` Pooventhiran G
2026-11-16 10:50       ` Johannes Berg [this message]
2026-11-06  7:58 ` [PATCH wireless-next v4 04/21] wifi: cfg80211: define layouts for SMD BSS Transition context Pooventhiran G
2026-11-10 18:39   ` Johannes Berg
2026-11-13 18:15     ` Pooventhiran G
2026-11-16 10:54       ` Johannes Berg
2026-11-06  7:58 ` [PATCH wireless-next v4 05/21] wifi: nl80211: define interfaces for SMD BSS Transition context transfer Pooventhiran G
2026-11-10 18:45   ` Johannes Berg
2026-11-13 16:45     ` Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 06/21] wifi: ieee80211: define APIs for UHR Link Reconfiguration frame checks Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 07/21] wifi: ieee80211: define API to check if frame is class 3 Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 08/21] wifi: nl80211/cfg80211: pack SMD dynamic context along with frame Pooventhiran G
2026-11-10 18:51   ` Johannes Berg
2026-11-13 18:17     ` Pooventhiran G
2026-11-16 11:00       ` Johannes Berg
2026-11-11  9:14   ` Allen Ye
2026-11-13 18:19     ` Pooventhiran G
2026-11-16  3:38       ` Allen Ye (葉芷勳)
2026-11-06  7:58 ` [PATCH wireless-next v4 09/21] wifi: nl80211/cfg80211: add support for SMD context programming Pooventhiran G
2026-11-10 18:55   ` Johannes Berg
2026-11-13 17:54     ` Pooventhiran G
2026-11-16 11:13       ` Johannes Berg
2026-11-06  7:58 ` [PATCH wireless-next v4 10/21] wifi: nl80211/cfg80211: add support for querying SMD context for target AP MLD Pooventhiran G
2026-11-10 19:00   ` Johannes Berg
2026-11-13 18:33     ` Pooventhiran G
2026-11-16 11:20       ` Johannes Berg
2026-11-06  7:58 ` [PATCH wireless-next v4 11/21] wifi: nl80211/cfg80211: define API to notify SMD Drain completion Pooventhiran G
2026-11-10 19:01   ` Johannes Berg
2026-11-13 18:38     ` Pooventhiran G
2026-11-16 11:23       ` Johannes Berg
2026-11-06  7:58 ` [PATCH wireless-next v4 12/21] wifi: mac80211: set SMD parameters for AP setup and STA update Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 13/21] wifi: mac80211: apply SMD BSS Transition STA sub-states Pooventhiran G
2026-11-10 20:29   ` Johannes Berg
2026-11-13 18:46     ` Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 14/21] wifi: mac80211: add driver_op for SMD substate changes Pooventhiran G
2026-11-10 20:38   ` Johannes Berg
2026-11-13 19:20     ` Pooventhiran G
2026-11-16 11:32       ` Johannes Berg
2026-11-06  7:58 ` [PATCH wireless-next v4 15/21] wifi: mac80211: filter uplink and downlink frames based on SMD states Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 16/21] wifi: mac80211: send BlockAck policy in AMPDU action Pooventhiran G
2026-11-10 20:43   ` Johannes Berg
2026-11-16 10:50     ` Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 17/21] wifi: mac80211: pass rx_data directly from ieee80211_rx_list() Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 18/21] wifi: mac80211: handle UHR Link Reconfiguration frame Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 19/21] wifi: mac80211: add mac80211 support to handle NL80211_CMD_SET_SMD_CTX Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 20/21] wifi: mac80211: add mac80211 support to handle NL80211_CMD_GET_SMD_CTX Pooventhiran G
2026-11-10 20:47   ` Johannes Berg
2026-11-13 19:22     ` Pooventhiran G
2026-11-06  7:58 ` [PATCH wireless-next v4 21/21] wifi: mac80211: define API to invoke SMD Drain Completion event Pooventhiran G
2026-11-10 20:49   ` Johannes Berg
2026-11-13 19:24     ` Pooventhiran G

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7a83c6576a0797cfc009066ef768e2828284c212.camel@sipsolutions.net \
    --to=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pooventhiran.g@oss.qualcomm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®