From: Luca Abeni <luca.abeni@unitn.it>
To: linux-kernel@vger.kernel.org
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Juri Lelli <juri.lelli@arm.com>,
Luca Abeni <luca.abeni@unitn.it>
Subject: [RFC 1/8] Track the active utilisation
Date: Thu, 14 Jan 2016 16:24:46 +0100 [thread overview]
Message-ID: <1452785094-3086-2-git-send-email-luca.abeni@unitn.it> (raw)
In-Reply-To: <1452785094-3086-1-git-send-email-luca.abeni@unitn.it>
The active utilisation here is defined as the total utilisation of the
active (TASK_RUNNING) tasks queued on a runqueue. Hence, it is increased
when a task wakes up and is decreased when a task blocks.
This might need to be fixed / improved by decreasing the active
utilisation at the so-called "0-lag time" instead of when the task blocks.
Signed-off-by: Juri Lelli <juri.lelli@arm.com>
---
kernel/sched/deadline.c | 36 +++++++++++++++++++++++++++++++++++-
kernel/sched/sched.h | 5 +++++
2 files changed, 40 insertions(+), 1 deletion(-)
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index cd64c97..e779cce 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -43,6 +43,24 @@ static inline int on_dl_rq(struct sched_dl_entity *dl_se)
return !RB_EMPTY_NODE(&dl_se->rb_node);
}
+static void add_running_bw(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
+{
+ u64 se_bw = dl_se->dl_bw;
+
+ dl_rq->running_bw += se_bw;
+}
+
+static void clear_running_bw(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
+{
+ u64 se_bw = dl_se->dl_bw;
+
+ dl_rq->running_bw -= se_bw;
+ if (dl_rq->running_bw < 0) {
+ WARN_ON(1);
+ dl_rq->running_bw = 0;
+ }
+}
+
static inline int is_leftmost(struct task_struct *p, struct dl_rq *dl_rq)
{
struct sched_dl_entity *dl_se = &p->dl;
@@ -500,6 +518,8 @@ static void update_dl_entity(struct sched_dl_entity *dl_se,
struct dl_rq *dl_rq = dl_rq_of_se(dl_se);
struct rq *rq = rq_of_dl_rq(dl_rq);
+ add_running_bw(dl_se, dl_rq);
+
/*
* The arrival of a new instance needs special treatment, i.e.,
* the actual scheduling parameters have to be "renewed".
@@ -961,8 +981,10 @@ static void enqueue_task_dl(struct rq *rq, struct task_struct *p, int flags)
* its rq, the bandwidth timer callback (which clearly has not
* run yet) will take care of this.
*/
- if (p->dl.dl_throttled && !(flags & ENQUEUE_REPLENISH))
+ if (p->dl.dl_throttled && !(flags & ENQUEUE_REPLENISH)) {
+ add_running_bw(&p->dl, &rq->dl);
return;
+ }
enqueue_dl_entity(&p->dl, pi_se, flags);
@@ -980,6 +1002,8 @@ static void dequeue_task_dl(struct rq *rq, struct task_struct *p, int flags)
{
update_curr_dl(rq);
__dequeue_task_dl(rq, p, flags);
+ if (flags & DEQUEUE_SLEEP)
+ clear_running_bw(&p->dl, &rq->dl);
}
/*
@@ -1218,6 +1242,8 @@ static void task_fork_dl(struct task_struct *p)
static void task_dead_dl(struct task_struct *p)
{
struct dl_bw *dl_b = dl_bw_of(task_cpu(p));
+ struct dl_rq *dl_rq = dl_rq_of_se(&p->dl);
+ struct rq *rq = rq_of_dl_rq(dl_rq);
/*
* Since we are TASK_DEAD we won't slip out of the domain!
@@ -1226,6 +1252,10 @@ static void task_dead_dl(struct task_struct *p)
/* XXX we should retain the bw until 0-lag */
dl_b->total_bw -= p->dl.dl_bw;
raw_spin_unlock_irq(&dl_b->lock);
+
+ if (task_on_rq_queued(p)) {
+ clear_running_bw(&p->dl, &rq->dl);
+ }
}
static void set_curr_task_dl(struct rq *rq)
@@ -1705,6 +1735,10 @@ static void switched_from_dl(struct rq *rq, struct task_struct *p)
if (!start_dl_timer(p))
__dl_clear_params(p);
+ if (task_on_rq_queued(p)) {
+ clear_running_bw(&p->dl, &rq->dl);
+ }
+
/*
* Since this might be the only -deadline task on the rq,
* this is the right place to try to pull some other one
diff --git a/kernel/sched/sched.h b/kernel/sched/sched.h
index 10f1637..826ca6a 100644
--- a/kernel/sched/sched.h
+++ b/kernel/sched/sched.h
@@ -519,6 +519,11 @@ struct dl_rq {
#else
struct dl_bw dl_bw;
#endif
+ /* This is the "active utilization" for this runqueue.
+ * Increased when a task wakes up (becomes TASK_RUNNING)
+ * and decreased when a task blocks
+ */
+ s64 running_bw;
};
#ifdef CONFIG_SMP
--
1.9.1
next prev parent reply other threads:[~2016-01-14 15:36 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 15:24 [RFC 0/8] CPU reclaiming for SCHED_DEADLINE Luca Abeni
2016-01-14 15:24 ` Luca Abeni [this message]
2016-01-14 16:49 ` [RFC 1/8] Track the active utilisation Peter Zijlstra
2016-01-15 6:37 ` Luca Abeni
2016-01-14 19:13 ` Peter Zijlstra
2016-01-15 8:07 ` Luca Abeni
2016-01-14 15:24 ` [RFC 2/8] Correctly track the active utilisation for migrating tasks Luca Abeni
2016-01-14 15:24 ` [RFC 3/8] sched/deadline: add some tracepoints Luca Abeni
2016-01-14 15:24 ` [RFC 4/8] Improve the tracking of active utilisation Luca Abeni
2016-01-14 17:16 ` Peter Zijlstra
2016-01-15 6:48 ` Luca Abeni
2016-01-14 19:43 ` Peter Zijlstra
2016-01-15 9:27 ` Luca Abeni
2016-01-19 12:20 ` Luca Abeni
2016-01-19 13:47 ` Peter Zijlstra
2016-01-27 13:36 ` Luca Abeni
2016-01-27 14:39 ` Peter Zijlstra
2016-01-27 14:45 ` Luca Abeni
2016-01-28 13:08 ` Vincent Guittot
[not found] ` <CAKfTPtAt0gTwk9aAZN238NT1O-zJvxVQDTh2QN_KxAnE61xMww@mail.gmail.com>
2016-01-28 13:48 ` luca abeni
2016-01-28 13:56 ` Vincent Guittot
2016-01-28 11:14 ` luca abeni
2016-01-28 12:21 ` Peter Zijlstra
2016-01-28 13:41 ` luca abeni
2016-01-28 14:00 ` Peter Zijlstra
2016-01-28 21:15 ` Luca Abeni
2016-01-14 19:47 ` Peter Zijlstra
2016-01-15 8:10 ` Luca Abeni
2016-01-15 8:32 ` Peter Zijlstra
2016-01-14 15:24 ` [RFC 5/8] Track the "total rq utilisation" too Luca Abeni
2016-01-14 19:12 ` Peter Zijlstra
2016-01-15 8:04 ` Luca Abeni
2016-01-14 19:48 ` Peter Zijlstra
2016-01-15 6:50 ` Luca Abeni
2016-01-15 8:34 ` Peter Zijlstra
2016-01-15 9:15 ` Luca Abeni
2016-01-29 15:06 ` Peter Zijlstra
2016-01-29 21:21 ` Luca Abeni
2016-01-14 15:24 ` [RFC 6/8] GRUB accounting Luca Abeni
2016-01-14 19:50 ` Peter Zijlstra
2016-01-15 8:05 ` Luca Abeni
2016-01-14 15:24 ` [RFC 7/8] Make GRUB a task's flag Luca Abeni
2016-01-14 19:56 ` Peter Zijlstra
2016-01-15 8:15 ` Luca Abeni
2016-01-15 8:41 ` Peter Zijlstra
2016-01-15 9:08 ` Luca Abeni
2016-01-14 15:24 ` [RFC 8/8] Do not reclaim the whole CPU bandwidth Luca Abeni
2016-01-14 19:59 ` Peter Zijlstra
2016-01-15 8:21 ` Luca Abeni
2016-01-15 8:50 ` Peter Zijlstra
2016-01-15 9:49 ` Luca Abeni
2016-01-26 12:52 ` luca abeni
2016-01-27 14:44 ` Peter Zijlstra
2016-02-02 20:53 ` Luca Abeni
2016-02-03 11:30 ` Juri Lelli
2016-02-03 13:28 ` luca abeni
2016-01-19 10:11 ` [RFC 0/8] CPU reclaiming for SCHED_DEADLINE Juri Lelli
2016-01-19 11:50 ` Luca Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452785094-3086-2-git-send-email-luca.abeni@unitn.it \
--to=luca.abeni@unitn.it \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®