From: Luca Abeni <luca.abeni@unitn.it>
To: linux-kernel@vger.kernel.org
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Juri Lelli <juri.lelli@arm.com>,
Luca Abeni <luca.abeni@unitn.it>
Subject: [RFC 2/8] Correctly track the active utilisation for migrating tasks
Date: Thu, 14 Jan 2016 16:24:47 +0100 [thread overview]
Message-ID: <1452785094-3086-3-git-send-email-luca.abeni@unitn.it> (raw)
In-Reply-To: <1452785094-3086-1-git-send-email-luca.abeni@unitn.it>
Fix active utilisation accounting on migration: when a task is migrated
from CPUi to CPUj, immediately subtract the task's utilisation from
CPUi and add it to CPUj. This mechanism is implemented by modifying the
pull and push functions.
Note: this is not fully correct from the theoretical point of view
(the utilisation should be removed from CPUi only at the 0 lag time),
but doing the right thing would be _MUCH_ more complex (leaving the
timer armed when the task is on a different CPU... Inactive timers should
be moved from per-task timers to per-runqueue lists of timers! Bah...)
---
kernel/sched/deadline.c | 4 ++++
1 file changed, 4 insertions(+)
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index e779cce..8d7ee79 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -1541,7 +1541,9 @@ retry:
}
deactivate_task(rq, next_task, 0);
+ clear_running_bw(&next_task->dl, &rq->dl);
set_task_cpu(next_task, later_rq->cpu);
+ add_running_bw(&next_task->dl, &later_rq->dl);
activate_task(later_rq, next_task, 0);
ret = 1;
@@ -1629,7 +1631,9 @@ static void pull_dl_task(struct rq *this_rq)
resched = true;
deactivate_task(src_rq, p, 0);
+ clear_running_bw(&p->dl, &src_rq->dl);
set_task_cpu(p, this_cpu);
+ add_running_bw(&p->dl, &this_rq->dl);
activate_task(this_rq, p, 0);
dmin = p->dl.deadline;
--
1.9.1
next prev parent reply other threads:[~2016-01-14 15:36 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 15:24 [RFC 0/8] CPU reclaiming for SCHED_DEADLINE Luca Abeni
2016-01-14 15:24 ` [RFC 1/8] Track the active utilisation Luca Abeni
2016-01-14 16:49 ` Peter Zijlstra
2016-01-15 6:37 ` Luca Abeni
2016-01-14 19:13 ` Peter Zijlstra
2016-01-15 8:07 ` Luca Abeni
2016-01-14 15:24 ` Luca Abeni [this message]
2016-01-14 15:24 ` [RFC 3/8] sched/deadline: add some tracepoints Luca Abeni
2016-01-14 15:24 ` [RFC 4/8] Improve the tracking of active utilisation Luca Abeni
2016-01-14 17:16 ` Peter Zijlstra
2016-01-15 6:48 ` Luca Abeni
2016-01-14 19:43 ` Peter Zijlstra
2016-01-15 9:27 ` Luca Abeni
2016-01-19 12:20 ` Luca Abeni
2016-01-19 13:47 ` Peter Zijlstra
2016-01-27 13:36 ` Luca Abeni
2016-01-27 14:39 ` Peter Zijlstra
2016-01-27 14:45 ` Luca Abeni
2016-01-28 13:08 ` Vincent Guittot
[not found] ` <CAKfTPtAt0gTwk9aAZN238NT1O-zJvxVQDTh2QN_KxAnE61xMww@mail.gmail.com>
2016-01-28 13:48 ` luca abeni
2016-01-28 13:56 ` Vincent Guittot
2016-01-28 11:14 ` luca abeni
2016-01-28 12:21 ` Peter Zijlstra
2016-01-28 13:41 ` luca abeni
2016-01-28 14:00 ` Peter Zijlstra
2016-01-28 21:15 ` Luca Abeni
2016-01-14 19:47 ` Peter Zijlstra
2016-01-15 8:10 ` Luca Abeni
2016-01-15 8:32 ` Peter Zijlstra
2016-01-14 15:24 ` [RFC 5/8] Track the "total rq utilisation" too Luca Abeni
2016-01-14 19:12 ` Peter Zijlstra
2016-01-15 8:04 ` Luca Abeni
2016-01-14 19:48 ` Peter Zijlstra
2016-01-15 6:50 ` Luca Abeni
2016-01-15 8:34 ` Peter Zijlstra
2016-01-15 9:15 ` Luca Abeni
2016-01-29 15:06 ` Peter Zijlstra
2016-01-29 21:21 ` Luca Abeni
2016-01-14 15:24 ` [RFC 6/8] GRUB accounting Luca Abeni
2016-01-14 19:50 ` Peter Zijlstra
2016-01-15 8:05 ` Luca Abeni
2016-01-14 15:24 ` [RFC 7/8] Make GRUB a task's flag Luca Abeni
2016-01-14 19:56 ` Peter Zijlstra
2016-01-15 8:15 ` Luca Abeni
2016-01-15 8:41 ` Peter Zijlstra
2016-01-15 9:08 ` Luca Abeni
2016-01-14 15:24 ` [RFC 8/8] Do not reclaim the whole CPU bandwidth Luca Abeni
2016-01-14 19:59 ` Peter Zijlstra
2016-01-15 8:21 ` Luca Abeni
2016-01-15 8:50 ` Peter Zijlstra
2016-01-15 9:49 ` Luca Abeni
2016-01-26 12:52 ` luca abeni
2016-01-27 14:44 ` Peter Zijlstra
2016-02-02 20:53 ` Luca Abeni
2016-02-03 11:30 ` Juri Lelli
2016-02-03 13:28 ` luca abeni
2016-01-19 10:11 ` [RFC 0/8] CPU reclaiming for SCHED_DEADLINE Juri Lelli
2016-01-19 11:50 ` Luca Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452785094-3086-3-git-send-email-luca.abeni@unitn.it \
--to=luca.abeni@unitn.it \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®