From: Luca Abeni <luca.abeni@unitn.it>
To: linux-kernel@vger.kernel.org
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@redhat.com>, Juri Lelli <juri.lelli@arm.com>
Subject: [RFC 3/8] sched/deadline: add some tracepoints
Date: Thu, 14 Jan 2016 16:24:48 +0100 [thread overview]
Message-ID: <1452785094-3086-4-git-send-email-luca.abeni@unitn.it> (raw)
In-Reply-To: <1452785094-3086-1-git-send-email-luca.abeni@unitn.it>
From: Juri Lelli <juri.lelli@arm.com>
These tracepoints can be used to check the active bandwidth
tracking and to show SCHED_DEADLINE parameters
Signed-off-by: Juri Lelli <juri.lelli@arm.com>
---
include/trace/events/sched.h | 69 ++++++++++++++++++++++++++++++++++++++++++++
kernel/sched/deadline.c | 6 ++++
2 files changed, 75 insertions(+)
diff --git a/include/trace/events/sched.h b/include/trace/events/sched.h
index 9b90c57..52644c7 100644
--- a/include/trace/events/sched.h
+++ b/include/trace/events/sched.h
@@ -408,6 +408,75 @@ DEFINE_EVENT(sched_stat_runtime, sched_stat_runtime,
TP_ARGS(tsk, runtime, vruntime));
/*
+ * Tracepoint for accounting running bandwidth of active SCHED_DEADLINE
+ * tasks (XXX specific to SCHED_FLAG_GRUB).
+ */
+DECLARE_EVENT_CLASS(sched_stat_running_bw,
+
+ TP_PROTO(struct task_struct *tsk, u64 tsk_bw, s64 running_bw),
+
+ TP_ARGS(tsk, tsk_bw, running_bw),
+
+ TP_STRUCT__entry(
+ __array( char, comm, TASK_COMM_LEN )
+ __field( pid_t, pid )
+ __field( u64, tsk_bw )
+ __field( s64, running_bw )
+ __field( int, cpu )
+ ),
+
+ TP_fast_assign(
+ memcpy(__entry->comm, tsk->comm, TASK_COMM_LEN);
+ __entry->cpu = task_cpu(tsk);
+ __entry->pid = tsk->pid;
+ __entry->tsk_bw = tsk_bw;
+ __entry->running_bw = running_bw;
+ ),
+
+ TP_printk("comm=%s pid=%d cpu=%d tsk_bw=%Lu running_bw=%Ld ",
+ __entry->comm, __entry->pid, __entry->cpu,
+ (unsigned long long)__entry->tsk_bw,
+ (unsigned long long)__entry->running_bw)
+);
+
+DEFINE_EVENT(sched_stat_running_bw, sched_stat_running_bw_add,
+ TP_PROTO(struct task_struct *tsk, u64 tsk_bw, s64 running_bw),
+ TP_ARGS(tsk, tsk_bw, running_bw));
+
+DEFINE_EVENT(sched_stat_running_bw, sched_stat_running_bw_clear,
+ TP_PROTO(struct task_struct *tsk, u64 tsk_bw, s64 running_bw),
+ TP_ARGS(tsk, tsk_bw, running_bw));
+/*
+ * Tracepoint for showing actual parameters of SCHED_DEADLINE
+ * tasks.
+ */
+TRACE_EVENT(sched_stat_params_dl,
+
+ TP_PROTO(struct task_struct *tsk, s64 runtime, u64 deadline),
+
+ TP_ARGS(tsk, runtime, deadline),
+
+ TP_STRUCT__entry(
+ __array( char, comm, TASK_COMM_LEN )
+ __field( pid_t, pid )
+ __field( s64, runtime )
+ __field( u64, deadline )
+ ),
+
+ TP_fast_assign(
+ memcpy(__entry->comm, tsk->comm, TASK_COMM_LEN);
+ __entry->pid = tsk->pid;
+ __entry->runtime = runtime;
+ __entry->deadline = deadline;
+ ),
+
+ TP_printk("comm=%s pid=%d runtime=%Ld [ns] deadline=%Lu",
+ __entry->comm, __entry->pid,
+ __entry->runtime, __entry->deadline)
+);
+
+
+/*
* Tracepoint for showing priority inheritance modifying a tasks
* priority.
*/
diff --git a/kernel/sched/deadline.c b/kernel/sched/deadline.c
index 8d7ee79..d8e9962 100644
--- a/kernel/sched/deadline.c
+++ b/kernel/sched/deadline.c
@@ -18,6 +18,8 @@
#include <linux/slab.h>
+#include <trace/events/sched.h>
+
struct dl_bandwidth def_dl_bandwidth;
static inline struct task_struct *dl_task_of(struct sched_dl_entity *dl_se)
@@ -48,6 +50,7 @@ static void add_running_bw(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
u64 se_bw = dl_se->dl_bw;
dl_rq->running_bw += se_bw;
+ trace_sched_stat_running_bw_add(dl_task_of(dl_se), se_bw, dl_rq->running_bw);
}
static void clear_running_bw(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
@@ -55,6 +58,7 @@ static void clear_running_bw(struct sched_dl_entity *dl_se, struct dl_rq *dl_rq)
u64 se_bw = dl_se->dl_bw;
dl_rq->running_bw -= se_bw;
+ trace_sched_stat_running_bw_clear(dl_task_of(dl_se), se_bw, dl_rq->running_bw);
if (dl_rq->running_bw < 0) {
WARN_ON(1);
dl_rq->running_bw = 0;
@@ -770,6 +774,7 @@ static void update_curr_dl(struct rq *rq)
sched_rt_avg_update(rq, delta_exec);
dl_se->runtime -= dl_se->dl_yielded ? 0 : delta_exec;
+ trace_sched_stat_params_dl(curr, dl_se->runtime, dl_se->deadline);
if (dl_runtime_exceeded(dl_se)) {
dl_se->dl_throttled = 1;
__dequeue_task_dl(rq, curr, 0);
@@ -987,6 +992,7 @@ static void enqueue_task_dl(struct rq *rq, struct task_struct *p, int flags)
}
enqueue_dl_entity(&p->dl, pi_se, flags);
+ trace_sched_stat_params_dl(p, p->dl.runtime, p->dl.deadline);
if (!task_current(rq, p) && p->nr_cpus_allowed > 1)
enqueue_pushable_dl_task(rq, p);
--
1.9.1
next prev parent reply other threads:[~2016-01-14 15:25 UTC|newest]
Thread overview: 58+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-01-14 15:24 [RFC 0/8] CPU reclaiming for SCHED_DEADLINE Luca Abeni
2016-01-14 15:24 ` [RFC 1/8] Track the active utilisation Luca Abeni
2016-01-14 16:49 ` Peter Zijlstra
2016-01-15 6:37 ` Luca Abeni
2016-01-14 19:13 ` Peter Zijlstra
2016-01-15 8:07 ` Luca Abeni
2016-01-14 15:24 ` [RFC 2/8] Correctly track the active utilisation for migrating tasks Luca Abeni
2016-01-14 15:24 ` Luca Abeni [this message]
2016-01-14 15:24 ` [RFC 4/8] Improve the tracking of active utilisation Luca Abeni
2016-01-14 17:16 ` Peter Zijlstra
2016-01-15 6:48 ` Luca Abeni
2016-01-14 19:43 ` Peter Zijlstra
2016-01-15 9:27 ` Luca Abeni
2016-01-19 12:20 ` Luca Abeni
2016-01-19 13:47 ` Peter Zijlstra
2016-01-27 13:36 ` Luca Abeni
2016-01-27 14:39 ` Peter Zijlstra
2016-01-27 14:45 ` Luca Abeni
2016-01-28 13:08 ` Vincent Guittot
[not found] ` <CAKfTPtAt0gTwk9aAZN238NT1O-zJvxVQDTh2QN_KxAnE61xMww@mail.gmail.com>
2016-01-28 13:48 ` luca abeni
2016-01-28 13:56 ` Vincent Guittot
2016-01-28 11:14 ` luca abeni
2016-01-28 12:21 ` Peter Zijlstra
2016-01-28 13:41 ` luca abeni
2016-01-28 14:00 ` Peter Zijlstra
2016-01-28 21:15 ` Luca Abeni
2016-01-14 19:47 ` Peter Zijlstra
2016-01-15 8:10 ` Luca Abeni
2016-01-15 8:32 ` Peter Zijlstra
2016-01-14 15:24 ` [RFC 5/8] Track the "total rq utilisation" too Luca Abeni
2016-01-14 19:12 ` Peter Zijlstra
2016-01-15 8:04 ` Luca Abeni
2016-01-14 19:48 ` Peter Zijlstra
2016-01-15 6:50 ` Luca Abeni
2016-01-15 8:34 ` Peter Zijlstra
2016-01-15 9:15 ` Luca Abeni
2016-01-29 15:06 ` Peter Zijlstra
2016-01-29 21:21 ` Luca Abeni
2016-01-14 15:24 ` [RFC 6/8] GRUB accounting Luca Abeni
2016-01-14 19:50 ` Peter Zijlstra
2016-01-15 8:05 ` Luca Abeni
2016-01-14 15:24 ` [RFC 7/8] Make GRUB a task's flag Luca Abeni
2016-01-14 19:56 ` Peter Zijlstra
2016-01-15 8:15 ` Luca Abeni
2016-01-15 8:41 ` Peter Zijlstra
2016-01-15 9:08 ` Luca Abeni
2016-01-14 15:24 ` [RFC 8/8] Do not reclaim the whole CPU bandwidth Luca Abeni
2016-01-14 19:59 ` Peter Zijlstra
2016-01-15 8:21 ` Luca Abeni
2016-01-15 8:50 ` Peter Zijlstra
2016-01-15 9:49 ` Luca Abeni
2016-01-26 12:52 ` luca abeni
2016-01-27 14:44 ` Peter Zijlstra
2016-02-02 20:53 ` Luca Abeni
2016-02-03 11:30 ` Juri Lelli
2016-02-03 13:28 ` luca abeni
2016-01-19 10:11 ` [RFC 0/8] CPU reclaiming for SCHED_DEADLINE Juri Lelli
2016-01-19 11:50 ` Luca Abeni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1452785094-3086-4-git-send-email-luca.abeni@unitn.it \
--to=luca.abeni@unitn.it \
--cc=juri.lelli@arm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®