* gma500: mmu: unmap the correct address
@ 2017-10-29 5:55 Pan Bian
2017-10-30 10:22 ` Daniel Vetter
0 siblings, 1 reply; 2+ messages in thread
From: Pan Bian @ 2017-10-29 5:55 UTC (permalink / raw)
To: Patrik Jakobsson, David Airlie; +Cc: dri-devel, linux-kernel, Pan Bian
The function kunmap_atomatic() is called on the same variable twice,
i.e. pt->v. In the second call, its parameter should be variable v
rather than pt->v.
Signed-off-by: Pan Bian <bianpan2016@163.com>
---
drivers/gpu/drm/gma500/mmu.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/gpu/drm/gma500/mmu.c b/drivers/gpu/drm/gma500/mmu.c
index 0eaf11c..ccb161c 100644
--- a/drivers/gpu/drm/gma500/mmu.c
+++ b/drivers/gpu/drm/gma500/mmu.c
@@ -395,7 +395,7 @@ static void psb_mmu_pt_unmap_unlock(struct psb_mmu_pt *pt)
psb_mmu_clflush(pd->driver, (void *)&v[pt->index]);
atomic_set(&pd->driver->needs_tlbflush, 1);
}
- kunmap_atomic(pt->v);
+ kunmap_atomic(v);
spin_unlock(&pd->driver->lock);
psb_mmu_free_pt(pt);
return;
--
1.9.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: gma500: mmu: unmap the correct address
2017-10-29 5:55 gma500: mmu: unmap the correct address Pan Bian
@ 2017-10-30 10:22 ` Daniel Vetter
0 siblings, 0 replies; 2+ messages in thread
From: Daniel Vetter @ 2017-10-30 10:22 UTC (permalink / raw)
To: Pan Bian; +Cc: Patrik Jakobsson, David Airlie, linux-kernel, dri-devel
On Sun, Oct 29, 2017 at 01:55:12PM +0800, Pan Bian wrote:
> The function kunmap_atomatic() is called on the same variable twice,
> i.e. pt->v. In the second call, its parameter should be variable v
> rather than pt->v.
>
> Signed-off-by: Pan Bian <bianpan2016@163.com>
Makes sense, not sure this ever worked or how it ever worked, but oh well.
Applied to drm-misc-next for 4.16.
-Daniel
> ---
> drivers/gpu/drm/gma500/mmu.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/gma500/mmu.c b/drivers/gpu/drm/gma500/mmu.c
> index 0eaf11c..ccb161c 100644
> --- a/drivers/gpu/drm/gma500/mmu.c
> +++ b/drivers/gpu/drm/gma500/mmu.c
> @@ -395,7 +395,7 @@ static void psb_mmu_pt_unmap_unlock(struct psb_mmu_pt *pt)
> psb_mmu_clflush(pd->driver, (void *)&v[pt->index]);
> atomic_set(&pd->driver->needs_tlbflush, 1);
> }
> - kunmap_atomic(pt->v);
> + kunmap_atomic(v);
> spin_unlock(&pd->driver->lock);
> psb_mmu_free_pt(pt);
> return;
> --
> 1.9.1
>
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/dri-devel
--
Daniel Vetter
Software Engineer, Intel Corporation
http://blog.ffwll.ch
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-10-30 10:22 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-10-29 5:55 gma500: mmu: unmap the correct address Pan Bian
2017-10-30 10:22 ` Daniel Vetter
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®