From: Christoph Hellwig <hch@infradead.org>
To: Martin Schwidefsky <schwidefsky@de.ibm.com>
Cc: linux-kernel@vger.kernel.org, torvalds@transmeta.com
Subject: Re: [PATCH] s390 update (4/9): common i/o layer update.
Date: Wed, 26 Mar 2003 16:08:10 +0000 [thread overview]
Message-ID: <20030326160810.A17984@infradead.org> (raw)
In-Reply-To: <200303261610.16448.schwidefsky@de.ibm.com>; from schwidefsky@de.ibm.com on Wed, Mar 26, 2003 at 04:10:16PM +0100
On Wed, Mar 26, 2003 at 04:10:16PM +0100, Martin Schwidefsky wrote:
> + typeof (chsc_area_ssd.response_block)
> + *ssd_res = &chsc_area_ssd.response_block;
Yikes! Please use the actual type here instead of typeof()
> + if (sch->lpm == 0)
> + return -ENODEV;
> + else
> + return -EACCES;
I'd write this as return (sch->lpm ? -EACCES : -ENODEV), but maybe I'm
just too picky..
> - sch = kmalloc (sizeof (*sch), GFP_DMA);
> + sch = kmalloc (sizeof (*sch), GFP_KERNEL | GFP_DMA);
What about using GFP_KERNEL | __GFP_DMA instead? This makes it
more clear that it's just a qualifier.
next prev parent reply other threads:[~2003-03-26 15:57 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-26 15:10 Martin Schwidefsky
2003-03-26 16:08 ` Christoph Hellwig [this message]
2003-03-26 22:18 ` Henning P. Schmiedehausen
2003-03-26 16:27 Martin Schwidefsky
2003-03-26 16:37 ` Jörn Engel
2003-03-26 16:47 ` Francis Galiegue
2003-03-26 20:05 ` Christoph Hellwig
[not found] <20030326153033$579e@gated-at.bofh.it>
[not found] ` <20030326161014$2d93@gated-at.bofh.it>
2003-03-26 23:47 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20030326160810.A17984@infradead.org \
--to=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=schwidefsky@de.ibm.com \
--cc=torvalds@transmeta.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®