Re: [PATCH] s390 update (4/9): common i/o layer update.

[Arnd Bergmann <arnd@bergmann-dalldorf.de>]

Christoph Hellwig wrote:

> On Wed, Mar 26, 2003 at 04:10:16PM +0100, Martin Schwidefsky wrote:
>> +    typeof (chsc_area_ssd.response_block)
>> +            *ssd_res = &chsc_area_ssd.response_block;
> 
> Yikes!  Please use the actual type here instead of typeof()

That code still has a bigger problem and has to be changed anyway.
If there is a good reason against typeof, I will do it differently
for the final version. This change only kept the hack working
with gcc-3.3, I just forgot to do it right before Martin submitted
it.

>> +    if (sch->lpm == 0)
>> +            return -ENODEV;
>> +    else
>> +            return -EACCES;
> 
> I'd write this as return (sch->lpm ? -EACCES : -ENODEV), but maybe I'm
> just too picky..

No, you are right. I'll change it.

>> -    sch = kmalloc (sizeof (*sch), GFP_DMA);
>> +    sch = kmalloc (sizeof (*sch), GFP_KERNEL | GFP_DMA);
> 
> What about using GFP_KERNEL | __GFP_DMA instead?  This makes it
> more clear that it's just a qualifier.

Erm, no:

$ find -name \*.c | xargs grep '\<__GFP_DMA' | wc -l
      9
$ find -name \*.c | xargs grep '\<GFP_DMA'  | wc -l
    183

How about changing the few users of __GFP_DMA to GFP_DMA instead?

        Arnd <><