Re: [PATCH] s390 update (4/9): common i/o layer update.

["Martin Schwidefsky" <schwidefsky@de.ibm.com>]

> > + typeof (chsc_area_ssd.response_block)
> > +       *ssd_res = &chsc_area_ssd.response_block;
>
> Yikes!  Please use the actual type here instead of typeof()
Trouble is that response_block is an anonymous structure. There
is not type...

> > + if (sch->lpm == 0)
> > +       return -ENODEV;
> > + else
> > +       return -EACCES;
>
> I'd write this as return (sch->lpm ? -EACCES : -ENODEV), but maybe I'm
> just too picky..
No, you are not. return (sch->lpm ? -EACCES : -ENODEV) is better.

> > - sch = kmalloc (sizeof (*sch), GFP_DMA);
> > + sch = kmalloc (sizeof (*sch), GFP_KERNEL | GFP_DMA);
>
> What about using GFP_KERNEL | __GFP_DMA instead?  This makes it
> more clear that it's just a qualifier.
Hmm, GFP_DMA and __GFP_DMA are equivalent. I don't quite see your
point here.

blue skies,
   Martin