Re: [PATCH] s390 update (4/9): common i/o layer update.

[Francis Galiegue <fg6@wanadoo.fr>]

On Wednesday 26 March 2003 17:37, Jörn Engel wrote:
> On Wed, 26 March 2003 17:27:23 +0100, Martin Schwidefsky wrote:
> > > > + if (sch->lpm == 0)
> > > > +       return -ENODEV;
> > > > + else
> > > > +       return -EACCES;
> > >
> > > I'd write this as return (sch->lpm ? -EACCES : -ENODEV), but maybe I'm
> > > just too picky..
> >
> > No, you are not. return (sch->lpm ? -EACCES : -ENODEV) is better.
>
> Are the brackets really necessary? This is highly personal, but I
> spend a few second "stubling" over them, which makes the code less
> readable for me.
>

Hey, after all it's a return we're doing here, no?

if (sch->lpm)
	return -EACCESS;

return -ENODEV;


-- 
Francis Galiegue <fgaliegue@tbs-internet.com>
Vatican (Score:5, Funny) 
by Anonymous Coward on Friday January 24, @11:26AM (#5151284) 
"Scientists at the Vatican Praying Center found that 98% of the prayer queries
at the God level are unnecessary."