From: "Henning P. Schmiedehausen" <hps@intermeta.de>
To: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] s390 update (4/9): common i/o layer update.
Date: Wed, 26 Mar 2003 22:18:32 +0000 (UTC) [thread overview]
Message-ID: <b5t8vo$g1b$1@tangens.hometree.net> (raw)
In-Reply-To: <20030326160810.A17984@infradead.org>
Christoph Hellwig <hch@infradead.org> writes:
>Yikes! Please use the actual type here instead of typeof()
>> + if (sch->lpm == 0)
>> + return -ENODEV;
>> + else
>> + return -EACCES;
>I'd write this as return (sch->lpm ? -EACCES : -ENODEV), but maybe I'm
>just too picky..
Ah, don't be shy. Real men write this as
return -(sch->lpm ? EACCES : ENODEV);
:-)
Henning
--
Dipl.-Inf. (Univ.) Henning P. Schmiedehausen INTERMETA GmbH
hps@intermeta.de +49 9131 50 654 0 http://www.intermeta.de/
Java, perl, Solaris, Linux, xSP Consulting, Web Services
freelance consultant -- Jakarta Turbine Development -- hero for hire
next prev parent reply other threads:[~2003-03-26 22:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2003-03-26 15:10 Martin Schwidefsky
2003-03-26 16:08 ` Christoph Hellwig
2003-03-26 22:18 ` Henning P. Schmiedehausen [this message]
2003-03-26 16:27 Martin Schwidefsky
2003-03-26 16:37 ` Jörn Engel
2003-03-26 16:47 ` Francis Galiegue
2003-03-26 20:05 ` Christoph Hellwig
[not found] <20030326153033$579e@gated-at.bofh.it>
[not found] ` <20030326161014$2d93@gated-at.bofh.it>
2003-03-26 23:47 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='b5t8vo$g1b$1@tangens.hometree.net' \
--to=hps@intermeta.de \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®