[PATCH] KCONFIG: Add some extra info regarding the kernel localversion.

[PATCH] KCONFIG: Add some extra info regarding the kernel localversion.

[Robert P. J. Day]

  A small formatting fix, and add a few lines describing the origin of
the git-based "localversion" string for the kernel version.

Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>

---

diff --git a/init/Kconfig b/init/Kconfig
index f977086..4d5aef6 100644
--- a/init/Kconfig
+++ b/init/Kconfig
@@ -80,13 +80,19 @@ config LOCALVERSION_AUTO
 	default y
 	help
 	  This will try to automatically determine if the current tree is a
-	  release tree by looking for git tags that
-	  belong to the current top of tree revision.
+	  release tree by looking for git tags that belong to the current
+	  top of tree revision.

 	  A string of the format -gxxxxxxxx will be added to the localversion
-	  if a git based tree is found.  The string generated by this will be
+	  if a git-based tree is found.  The string generated by this will be
 	  appended after any matching localversion* files, and after the value
-	  set in CONFIG_LOCALVERSION
+	  set in CONFIG_LOCALVERSION.  (The actual string is the first eight
+	  characters produced by running the command:
+
+	    $ git rev-parse --verify HEAD
+
+	  which is done within the script "scripts/setlocalversion", in case
+	  you were interested.)

 	  Note: This requires Perl, and a git repository, but not necessarily
 	  the git or cogito tools to be installed.
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================

Re: [PATCH] KCONFIG: Add some extra info regarding the kernel localversion.

[Randy Dunlap]

On Sun, 4 Mar 2007 06:01:17 -0500 (EST) Robert P. J. Day wrote:

> 
>   A small formatting fix, and add a few lines describing the origin of
> the git-based "localversion" string for the kernel version.
> 
> Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> 
> ---
> 
> diff --git a/init/Kconfig b/init/Kconfig
> index f977086..4d5aef6 100644
> --- a/init/Kconfig
> +++ b/init/Kconfig
> @@ -80,13 +80,19 @@ config LOCALVERSION_AUTO
>  	default y
>  	help
>  	  This will try to automatically determine if the current tree is a
> -	  release tree by looking for git tags that
> -	  belong to the current top of tree revision.
> +	  release tree by looking for git tags that belong to the current
> +	  top of tree revision.
> 
>  	  A string of the format -gxxxxxxxx will be added to the localversion
> -	  if a git based tree is found.  The string generated by this will be
> +	  if a git-based tree is found.  The string generated by this will be
>  	  appended after any matching localversion* files, and after the value
> -	  set in CONFIG_LOCALVERSION
> +	  set in CONFIG_LOCALVERSION.  (The actual string is the first eight
> +	  characters produced by running the command:
> +
> +	    $ git rev-parse --verify HEAD
> +
> +	  which is done within the script "scripts/setlocalversion", in case
> +	  you were interested.)

Please omit ", in case you were interested".

> 
>  	  Note: This requires Perl, and a git repository, but not necessarily
>  	  the git or cogito tools to be installed.

How can this be the case since a 'git' command is used, according to
your new documentation?


---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***

Re: [PATCH] KCONFIG: Add some extra info regarding the kernel localversion.

[Robert P. J. Day]

On Sun, 4 Mar 2007, Randy Dunlap wrote:

> On Sun, 4 Mar 2007 06:01:17 -0500 (EST) Robert P. J. Day wrote:
>
> >
> >   A small formatting fix, and add a few lines describing the origin of
> > the git-based "localversion" string for the kernel version.
> >
> > Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> >
> > ---
> >
> > diff --git a/init/Kconfig b/init/Kconfig
> > index f977086..4d5aef6 100644
> > --- a/init/Kconfig
> > +++ b/init/Kconfig
> > @@ -80,13 +80,19 @@ config LOCALVERSION_AUTO
> >  	default y
> >  	help
> >  	  This will try to automatically determine if the current tree is a
> > -	  release tree by looking for git tags that
> > -	  belong to the current top of tree revision.
> > +	  release tree by looking for git tags that belong to the current
> > +	  top of tree revision.
> >
> >  	  A string of the format -gxxxxxxxx will be added to the localversion
> > -	  if a git based tree is found.  The string generated by this will be
> > +	  if a git-based tree is found.  The string generated by this will be
> >  	  appended after any matching localversion* files, and after the value
> > -	  set in CONFIG_LOCALVERSION
> > +	  set in CONFIG_LOCALVERSION.  (The actual string is the first eight
> > +	  characters produced by running the command:
> > +
> > +	    $ git rev-parse --verify HEAD
> > +
> > +	  which is done within the script "scripts/setlocalversion", in case
> > +	  you were interested.)
>
> Please omit ", in case you were interested".

ok, will resubmit.

> >
> >  	  Note: This requires Perl, and a git repository, but not necessarily
> >  	  the git or cogito tools to be installed.
>
> How can this be the case since a 'git' command is used, according to
> your new documentation?

i have no idea why that last part says that -- that's not part of my
addition, it's the original text.  in fact, there's nothing about
scripts/setlocalversion that seems to require perl, so that last part
is *doubly* odd.

rday
-- 
========================================================================
Robert P. J. Day
Linux Consulting, Training and Annoying Kernel Pedantry
Waterloo, Ontario, CANADA

http://fsdev.net/wiki/index.php?title=Main_Page
========================================================================

Re: [PATCH] KCONFIG: Add some extra info regarding the kernel localversion.

[Sam Ravnborg]

On Sun, Mar 04, 2007 at 12:10:18PM -0500, Robert P. J. Day wrote:
> On Sun, 4 Mar 2007, Randy Dunlap wrote:
> 
> > On Sun, 4 Mar 2007 06:01:17 -0500 (EST) Robert P. J. Day wrote:
> >
> > >
> > >   A small formatting fix, and add a few lines describing the origin of
> > > the git-based "localversion" string for the kernel version.
> > >
> > > Signed-off-by: Robert P. J. Day <rpjday@mindspring.com>
> > >
> > > ---
> > >
> > > diff --git a/init/Kconfig b/init/Kconfig
> > > index f977086..4d5aef6 100644
> > > --- a/init/Kconfig
> > > +++ b/init/Kconfig
> > > @@ -80,13 +80,19 @@ config LOCALVERSION_AUTO
> > >  	default y
> > >  	help
> > >  	  This will try to automatically determine if the current tree is a
> > > -	  release tree by looking for git tags that
> > > -	  belong to the current top of tree revision.
> > > +	  release tree by looking for git tags that belong to the current
> > > +	  top of tree revision.
> > >
> > >  	  A string of the format -gxxxxxxxx will be added to the localversion
> > > -	  if a git based tree is found.  The string generated by this will be
> > > +	  if a git-based tree is found.  The string generated by this will be
> > >  	  appended after any matching localversion* files, and after the value
> > > -	  set in CONFIG_LOCALVERSION
> > > +	  set in CONFIG_LOCALVERSION.  (The actual string is the first eight
> > > +	  characters produced by running the command:
> > > +
> > > +	    $ git rev-parse --verify HEAD
> > > +
> > > +	  which is done within the script "scripts/setlocalversion", in case
> > > +	  you were interested.)
> >
> > Please omit ", in case you were interested".
> 
> ok, will resubmit.
> 
> > >
> > >  	  Note: This requires Perl, and a git repository, but not necessarily
> > >  	  the git or cogito tools to be installed.
> >
> > How can this be the case since a 'git' command is used, according to
> > your new documentation?
> 
> i have no idea why that last part says that -- that's not part of my
> addition, it's the original text.  in fact, there's nothing about
> scripts/setlocalversion that seems to require perl, so that last part
> is *doubly* odd.
In the past setlocalversion was a perl script.

	Sam