Re: [git pull] "big box" x86 changes, boot protocol

[Adrian Bunk <bunk@kernel.org>]

On Sat, Apr 26, 2008 at 01:39:28PM -0700, Andrew Morton wrote:
> On Sat, 26 Apr 2008 21:54:07 +0200 Ingo Molnar <mingo@elte.hu> wrote:
>...
> >
> > +void __init free_early(unsigned long start, unsigned long end)
> > +{
> > +	struct early_res *r;
> > +	int i, j;
> > +
> > +	for (i = 0; i < MAX_EARLY_RES && early_res[i].end; i++) {
> > +		r = &early_res[i];
> > +		if (start == r->start && end == r->end)
> > +			break;
> > +	}
> > +	if (i >= MAX_EARLY_RES || !early_res[i].end)
> > +		panic("free_early on not reserved area: %lx-%lx!", start, end);
> > +
> > +	for (j = i + 1; j < MAX_EARLY_RES && early_res[j].end; j++)
> > +		;
> > +
> > +	memcpy(&early_res[i], &early_res[i + 1],
> > +	       (j - 1 - i) * sizeof(struct early_res));
> 
> nit: memcpy() shouldn't be used for overlapping copies.  It happens to be
> OK (for dst<src) in the kernel implementations.  We hope.
>...

We always use the gcc builtin for memcpy() here.

cu
Adrian

-- 

       "Is there not promise of rain?" Ling Tan asked suddenly out
        of the darkness. There had been need of rain for many days.
       "Only a promise," Lao Er said.
                                       Pearl S. Buck - Dragon Seed