* [PATCH 1/2] mfd: retu: Add OF device ID table
@ 2017-02-21 13:34 Javier Martinez Canillas
2017-02-21 13:34 ` [PATCH 2/2] mfd: tps6105x: " Javier Martinez Canillas
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Javier Martinez Canillas @ 2017-02-21 13:34 UTC (permalink / raw)
To: linux-kernel; +Cc: Javier Martinez Canillas, Lee Jones
The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2C device registered via OF will always match a legacy I2C device ID and
that the MODALIAS reported will always be of the form i2c:<device>.
But this could change in the future so the correct approach is to have a
OF device ID table if the devices are registered via OF.
The compatible strings don't have a vendor prefix because that's how it's
used currently, and changing this will be a Device Tree ABI break.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/mfd/retu-mfd.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/mfd/retu-mfd.c b/drivers/mfd/retu-mfd.c
index d4c114abeb75..b47ba6a63b7e 100644
--- a/drivers/mfd/retu-mfd.c
+++ b/drivers/mfd/retu-mfd.c
@@ -308,9 +308,17 @@ static const struct i2c_device_id retu_id[] = {
};
MODULE_DEVICE_TABLE(i2c, retu_id);
+static const struct of_device_id retu_of_match[] = {
+ { .compatible = "retu-mfd" },
+ { .compatible = "tahvo-mfd" },
+ { }
+};
+MODULE_DEVICE_TABLE(of, retu_of_match);
+
static struct i2c_driver retu_driver = {
.driver = {
.name = "retu-mfd",
+ .of_match_table = of_match_ptr(retu_of_match),
},
.probe = retu_probe,
.remove = retu_remove,
--
2.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread* [PATCH 2/2] mfd: tps6105x: Add OF device ID table
2017-02-21 13:34 [PATCH 1/2] mfd: retu: Add OF device ID table Javier Martinez Canillas
@ 2017-02-21 13:34 ` Javier Martinez Canillas
2017-03-15 10:35 ` Lee Jones
2017-03-10 13:23 ` [PATCH 1/2] mfd: retu: " Javier Martinez Canillas
2017-03-15 10:34 ` Lee Jones
2 siblings, 1 reply; 6+ messages in thread
From: Javier Martinez Canillas @ 2017-02-21 13:34 UTC (permalink / raw)
To: linux-kernel; +Cc: Javier Martinez Canillas, Lee Jones
The driver doesn't have a struct of_device_id table but supported devices
are registered via Device Trees. This is working on the assumption that a
I2C device registered via OF will always match a legacy I2C device ID and
that the MODALIAS reported will always be of the form i2c:<device>.
But this could change in the future so the correct approach is to have a
OF device ID table if the devices are registered via OF.
The compatible strings don't have a vendor prefix because that's how it's
used currently, and changing this will be a Device Tree ABI break.
Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
---
drivers/mfd/tps6105x.c | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/mfd/tps6105x.c b/drivers/mfd/tps6105x.c
index baa12ea666fb..29f86b8eebc5 100644
--- a/drivers/mfd/tps6105x.c
+++ b/drivers/mfd/tps6105x.c
@@ -173,9 +173,17 @@ static const struct i2c_device_id tps6105x_id[] = {
};
MODULE_DEVICE_TABLE(i2c, tps6105x_id);
+static const struct of_device_id tps6105x_of_match[] = {
+ { .compatible = "tps61050" },
+ { .compatible = "tps61052" },
+ { },
+};
+MODULE_DEVICE_TABLE(of, tps6105x_of_match);
+
static struct i2c_driver tps6105x_driver = {
.driver = {
.name = "tps6105x",
+ .of_match_table = of_match_ptr(tps6105x_of_match),
},
.probe = tps6105x_probe,
.remove = tps6105x_remove,
--
2.9.3
^ permalink raw reply [flat|nested] 6+ messages in thread* Re: [PATCH 2/2] mfd: tps6105x: Add OF device ID table
2017-02-21 13:34 ` [PATCH 2/2] mfd: tps6105x: " Javier Martinez Canillas
@ 2017-03-15 10:35 ` Lee Jones
0 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2017-03-15 10:35 UTC (permalink / raw)
To: Javier Martinez Canillas; +Cc: linux-kernel
On Tue, 21 Feb 2017, Javier Martinez Canillas wrote:
> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.
>
> But this could change in the future so the correct approach is to have a
> OF device ID table if the devices are registered via OF.
>
> The compatible strings don't have a vendor prefix because that's how it's
> used currently, and changing this will be a Device Tree ABI break.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
>
> drivers/mfd/tps6105x.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
Likewise.
> diff --git a/drivers/mfd/tps6105x.c b/drivers/mfd/tps6105x.c
> index baa12ea666fb..29f86b8eebc5 100644
> --- a/drivers/mfd/tps6105x.c
> +++ b/drivers/mfd/tps6105x.c
> @@ -173,9 +173,17 @@ static const struct i2c_device_id tps6105x_id[] = {
> };
> MODULE_DEVICE_TABLE(i2c, tps6105x_id);
>
> +static const struct of_device_id tps6105x_of_match[] = {
> + { .compatible = "tps61050" },
> + { .compatible = "tps61052" },
> + { },
> +};
> +MODULE_DEVICE_TABLE(of, tps6105x_of_match);
> +
> static struct i2c_driver tps6105x_driver = {
> .driver = {
> .name = "tps6105x",
> + .of_match_table = of_match_ptr(tps6105x_of_match),
> },
> .probe = tps6105x_probe,
> .remove = tps6105x_remove,
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] mfd: retu: Add OF device ID table
2017-02-21 13:34 [PATCH 1/2] mfd: retu: Add OF device ID table Javier Martinez Canillas
2017-02-21 13:34 ` [PATCH 2/2] mfd: tps6105x: " Javier Martinez Canillas
@ 2017-03-10 13:23 ` Javier Martinez Canillas
2017-03-14 10:04 ` Lee Jones
2017-03-15 10:34 ` Lee Jones
2 siblings, 1 reply; 6+ messages in thread
From: Javier Martinez Canillas @ 2017-03-10 13:23 UTC (permalink / raw)
To: linux-kernel; +Cc: Lee Jones
Hello Lee,
On 02/21/2017 10:34 AM, Javier Martinez Canillas wrote:
> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.
>
> But this could change in the future so the correct approach is to have a
> OF device ID table if the devices are registered via OF.
>
> The compatible strings don't have a vendor prefix because that's how it's
> used currently, and changing this will be a Device Tree ABI break.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
Any comment on this patch and 2/2?
Best regards,
--
Javier Martinez Canillas
Open Source Group
Samsung Research America
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] mfd: retu: Add OF device ID table
2017-03-10 13:23 ` [PATCH 1/2] mfd: retu: " Javier Martinez Canillas
@ 2017-03-14 10:04 ` Lee Jones
0 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2017-03-14 10:04 UTC (permalink / raw)
To: Javier Martinez Canillas; +Cc: linux-kernel
On Fri, 10 Mar 2017, Javier Martinez Canillas wrote:
> Hello Lee,
>
> On 02/21/2017 10:34 AM, Javier Martinez Canillas wrote:
> > The driver doesn't have a struct of_device_id table but supported devices
> > are registered via Device Trees. This is working on the assumption that a
> > I2C device registered via OF will always match a legacy I2C device ID and
> > that the MODALIAS reported will always be of the form i2c:<device>.
> >
> > But this could change in the future so the correct approach is to have a
> > OF device ID table if the devices are registered via OF.
> >
> > The compatible strings don't have a vendor prefix because that's how it's
> > used currently, and changing this will be a Device Tree ABI break.
> >
> > Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> > ---
>
> Any comment on this patch and 2/2?
Apologies, I've been on vacation.
Will get to it in due course.
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH 1/2] mfd: retu: Add OF device ID table
2017-02-21 13:34 [PATCH 1/2] mfd: retu: Add OF device ID table Javier Martinez Canillas
2017-02-21 13:34 ` [PATCH 2/2] mfd: tps6105x: " Javier Martinez Canillas
2017-03-10 13:23 ` [PATCH 1/2] mfd: retu: " Javier Martinez Canillas
@ 2017-03-15 10:34 ` Lee Jones
2 siblings, 0 replies; 6+ messages in thread
From: Lee Jones @ 2017-03-15 10:34 UTC (permalink / raw)
To: Javier Martinez Canillas; +Cc: linux-kernel
On Tue, 21 Feb 2017, Javier Martinez Canillas wrote:
> The driver doesn't have a struct of_device_id table but supported devices
> are registered via Device Trees. This is working on the assumption that a
> I2C device registered via OF will always match a legacy I2C device ID and
> that the MODALIAS reported will always be of the form i2c:<device>.
>
> But this could change in the future so the correct approach is to have a
> OF device ID table if the devices are registered via OF.
>
> The compatible strings don't have a vendor prefix because that's how it's
> used currently, and changing this will be a Device Tree ABI break.
>
> Signed-off-by: Javier Martinez Canillas <javier@osg.samsung.com>
> ---
>
> drivers/mfd/retu-mfd.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
You're going to need a DT Ack for this.
... which might be difficult, since you didn't Cc them.
> diff --git a/drivers/mfd/retu-mfd.c b/drivers/mfd/retu-mfd.c
> index d4c114abeb75..b47ba6a63b7e 100644
> --- a/drivers/mfd/retu-mfd.c
> +++ b/drivers/mfd/retu-mfd.c
> @@ -308,9 +308,17 @@ static const struct i2c_device_id retu_id[] = {
> };
> MODULE_DEVICE_TABLE(i2c, retu_id);
>
> +static const struct of_device_id retu_of_match[] = {
> + { .compatible = "retu-mfd" },
> + { .compatible = "tahvo-mfd" },
> + { }
> +};
> +MODULE_DEVICE_TABLE(of, retu_of_match);
> +
> static struct i2c_driver retu_driver = {
> .driver = {
> .name = "retu-mfd",
> + .of_match_table = of_match_ptr(retu_of_match),
> },
> .probe = retu_probe,
> .remove = retu_remove,
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2017-03-15 10:35 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-02-21 13:34 [PATCH 1/2] mfd: retu: Add OF device ID table Javier Martinez Canillas
2017-02-21 13:34 ` [PATCH 2/2] mfd: tps6105x: " Javier Martinez Canillas
2017-03-15 10:35 ` Lee Jones
2017-03-10 13:23 ` [PATCH 1/2] mfd: retu: " Javier Martinez Canillas
2017-03-14 10:04 ` Lee Jones
2017-03-15 10:34 ` Lee Jones
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®