From: Tejun Heo <tj@kernel.org>
To: Michael Bringmann <mwb@linux.vnet.ibm.com>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>,
linux-kernel@vger.kernel.org,
Nathan Fontenot <nfont@linux.vnet.ibm.com>
Subject: Re: [PATCH] workqueue: Ensure that cpumask set for pools created after boot
Date: Tue, 16 May 2017 11:55:27 -0400 [thread overview]
Message-ID: <20170516155527.GB6389@htj.duckdns.org> (raw)
In-Reply-To: <ed3fc72a-b5b7-659c-f44a-9bd7061fa196@linux.vnet.ibm.com>
Hello, Michael.
On Mon, May 15, 2017 at 10:48:04AM -0500, Michael Bringmann wrote:
> >> --- a/kernel/workqueue.c
> >> +++ b/kernel/workqueue.c
> >> @@ -3366,6 +3366,8 @@ static struct worker_pool *get_unbound_pool(const struct workqueue_attrs *attrs)
> >> copy_workqueue_attrs(pool->attrs, attrs);
> >> pool->node = target_node;
> >>
> >> + cpumask_copy(pool->attrs->cpumask, cpumask_of(smp_processor_id()));
> >
> > What prevents a cpu getting added right here tho?
>
> PowerPC has only one control path to add/remove CPUs via DLPAR operations.
> Even so, the underlying code is protected through multiple locks.
The more I look at the patch, the less sense it seems to make. So,
whenever we create a new pool, we ignore the requested cpumask and
override it with the cpumask of the current thread?
> > Maybe the right thing to do is protecting the whole thing with hotplug
> > readlock?
>
> The operation is already within a hotplug readlock when performing DLPAR
> add/remove. Adding a CPU to the system, requires it to be brought online.
> Removing a CPU from the system, requires it to be taken offline. These
> involve calls to cpu_up / cpu_down, which go through _cpu_up / _cpu_down,
> which acquire the hotplug locks, among others along the path of execution.
>
> The locks are acquired before getting to the workqueue code, the pool
> creation/attachment code (which is where the cpu mask needs to be set),
> or trying to wakeup the initial created task in 'sched.c'.
A new unbound workqueue and thus unbound pool can also be created from
paths outside cpu hotplug, so get_unbound_pool() can race against
hotplug. Can you please explain the failures that you see in more
detail? I'm sure your patch works around the issue somehow but it
doesn't look like the right fix.
Thanks.
--
tejun
next prev parent reply other threads:[~2017-05-16 15:55 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 16:48 Michael Bringmann
2017-05-10 17:33 ` Tejun Heo
2017-05-15 15:48 ` Michael Bringmann
2017-05-16 15:55 ` Tejun Heo [this message]
2017-05-23 19:44 ` Michael Bringmann
2017-05-23 19:49 ` Tejun Heo
2017-05-23 20:09 ` Michael Bringmann
2017-05-23 20:10 ` Tejun Heo
2017-05-24 16:30 ` Michael Bringmann
2017-05-24 23:39 ` Michael Bringmann
2017-05-25 15:03 ` Tejun Heo
2017-05-25 15:07 ` Tejun Heo
2017-05-25 15:30 ` Michael Bringmann
2017-06-06 16:18 ` Michael Bringmann
2017-06-06 18:09 ` Tejun Heo
2017-06-12 14:47 ` Michael Bringmann
2017-06-12 16:14 ` Tejun Heo
2017-06-12 17:10 ` Michael Bringmann
2017-06-12 17:32 ` Tejun Heo
2017-06-13 20:04 ` Michael Bringmann
2017-06-13 20:10 ` Tejun Heo
2017-06-28 21:15 ` Michael Bringmann
2017-06-28 21:24 ` Tejun Heo
2017-07-26 15:25 ` Michael Bringmann
2017-07-26 19:16 ` Tejun Heo
2017-07-27 17:04 ` Michael Bringmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170516155527.GB6389@htj.duckdns.org \
--to=tj@kernel.org \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mwb@linux.vnet.ibm.com \
--cc=nfont@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®