From: Michael Bringmann <mwb@linux.vnet.ibm.com>
To: Tejun Heo <tj@kernel.org>
Cc: Lai Jiangshan <jiangshanlai@gmail.com>,
linux-kernel@vger.kernel.org,
Nathan Fontenot <nfont@linux.vnet.ibm.com>
Subject: Re: [PATCH] workqueue: Ensure that cpumask set for pools created after boot
Date: Wed, 28 Jun 2017 16:15:09 -0500 [thread overview]
Message-ID: <acd1d7b8-074b-6a60-bae0-43293461b135@linux.vnet.ibm.com> (raw)
In-Reply-To: <20170613201029.GA7359@htj.duckdns.org>
I will try that patch tomorrow. My only concern about that is the use of WARN_ON().
As I may have mentioned in my note of 6/27, I saw about 600 instances of the warning
message just during boot of the PowerPC kernel. I doubt that we want to see that on
an ongoing basis.
Michael
On 06/13/2017 03:10 PM, Tejun Heo wrote:
> Hello,
>
> On Tue, Jun 13, 2017 at 03:04:30PM -0500, Michael Bringmann wrote:
>> @@ -3564,19 +3564,28 @@ static struct pool_workqueue *alloc_unbound_pwq(struct workqueue_struct *wq,
>> static bool wq_calc_node_cpumask(const struct workqueue_attrs *attrs, int node,
>> int cpu_going_down, cpumask_t *cpumask)
>> {
>> + cpumask_t onl_targ_cm;
>> +
>> if (!wq_numa_enabled || attrs->no_numa)
>> goto use_dfl;
>>
>> /* does @node have any online CPUs @attrs wants? */
>> - cpumask_and(cpumask, cpumask_of_node(node), attrs->cpumask);
>> + cpumask_and(&onl_targ_cm, cpumask_of_node(node), attrs->cpumask);
>> if (cpu_going_down >= 0)
>> - cpumask_clear_cpu(cpu_going_down, cpumask);
>> + cpumask_clear_cpu(cpu_going_down, &onl_targ_cm);
>>
>> - if (cpumask_empty(cpumask))
>> + if (cpumask_empty(&onl_targ_cm))
>> goto use_dfl;
>>
>> /* yeap, return possible CPUs in @node that @attrs wants */
>> cpumask_and(cpumask, attrs->cpumask, wq_numa_possible_cpumask[node]);
>> +
>> + if (cpumask_weight(&onl_targ_cm) > cpumask_weight(cpumask)) {
>> + printk(KERN_INFO "WARNING: WQ cpumask: onl intersect > "
>> + "possible intersect\n");
>> + return false;
>> + }
>
> Yeah, alternatively, we can just add right before returning,
>
> if (WARN_ON(cpumask_empty(cpumask)))
> return false;
>
> Thanks.
>
--
Michael W. Bringmann
Linux Technology Center
IBM Corporation
Tie-Line 363-5196
External: (512) 286-5196
Cell: (512) 466-0650
mwb@linux.vnet.ibm.com
next prev parent reply other threads:[~2017-06-28 21:15 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-05-10 16:48 Michael Bringmann
2017-05-10 17:33 ` Tejun Heo
2017-05-15 15:48 ` Michael Bringmann
2017-05-16 15:55 ` Tejun Heo
2017-05-23 19:44 ` Michael Bringmann
2017-05-23 19:49 ` Tejun Heo
2017-05-23 20:09 ` Michael Bringmann
2017-05-23 20:10 ` Tejun Heo
2017-05-24 16:30 ` Michael Bringmann
2017-05-24 23:39 ` Michael Bringmann
2017-05-25 15:03 ` Tejun Heo
2017-05-25 15:07 ` Tejun Heo
2017-05-25 15:30 ` Michael Bringmann
2017-06-06 16:18 ` Michael Bringmann
2017-06-06 18:09 ` Tejun Heo
2017-06-12 14:47 ` Michael Bringmann
2017-06-12 16:14 ` Tejun Heo
2017-06-12 17:10 ` Michael Bringmann
2017-06-12 17:32 ` Tejun Heo
2017-06-13 20:04 ` Michael Bringmann
2017-06-13 20:10 ` Tejun Heo
2017-06-28 21:15 ` Michael Bringmann [this message]
2017-06-28 21:24 ` Tejun Heo
2017-07-26 15:25 ` Michael Bringmann
2017-07-26 19:16 ` Tejun Heo
2017-07-27 17:04 ` Michael Bringmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=acd1d7b8-074b-6a60-bae0-43293461b135@linux.vnet.ibm.com \
--to=mwb@linux.vnet.ibm.com \
--cc=jiangshanlai@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nfont@linux.vnet.ibm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®