From: Peter Zijlstra <peterz@infradead.org>
To: x86@kernel.org
Cc: linux-kernel@vger.kernel.org, peterz@infradead.org,
David.Kaplan@amd.com, Andrew.Cooper3@citrix.com,
jpoimboe@kernel.org, gregkh@linuxfoundation.org,
nik.borisov@suse.com
Subject: [PATCH v2 02/11] x86/cpu: Fix up srso_safe_ret() and __x86_return_thunk()
Date: Mon, 14 Aug 2023 13:44:28 +0200 [thread overview]
Message-ID: <20230814121148.637802730@infradead.org> (raw)
In-Reply-To: <20230814114426.057251214@infradead.org>
vmlinux.o: warning: objtool: srso_untrain_ret() falls through to next function __x86_return_skl()
vmlinux.o: warning: objtool: __x86_return_thunk() falls through to next function __x86_return_skl()
This is because these functions (can) end with CALL, which objtool
does not consider a terminating instruction. Therefore replace the
INT3 instruction (which is a non-fatal trap) with UD2 (which is a
fatal-trap).
This indicates execution will not continue past this point.
Fixes: fb3bd914b3ec ("x86/srso: Add a Speculative RAS Overflow mitigation")
Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
---
arch/x86/lib/retpoline.S | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/arch/x86/lib/retpoline.S
+++ b/arch/x86/lib/retpoline.S
@@ -259,7 +259,7 @@ SYM_INNER_LABEL(srso_safe_ret, SYM_L_GLO
int3
lfence
call srso_safe_ret
- int3
+ ud2
SYM_CODE_END(srso_safe_ret)
SYM_FUNC_END(srso_untrain_ret)
__EXPORT_THUNK(srso_untrain_ret)
@@ -269,7 +269,7 @@ SYM_CORE_START(__x86_return_thunk)
ANNOTATE_NOENDBR
ALTERNATIVE_2 "jmp __ret", "call srso_safe_ret", X86_FEATURE_SRSO, \
"call srso_safe_ret_alias", X86_FEATURE_SRSO_ALIAS
- int3
+ ud2
SYM_CODE_END(__x86_return_thunk)
EXPORT_SYMBOL(__x86_return_thunk)
next prev parent reply other threads:[~2023-08-14 12:20 UTC|newest]
Thread overview: 74+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-08-14 11:44 [PATCH v2 00/11] Fix up SRSO stuff Peter Zijlstra
2023-08-14 11:44 ` [PATCH v2 01/11] x86/cpu: Fixup __x86_return_thunk Peter Zijlstra
2023-08-16 7:55 ` [tip: x86/urgent] x86/cpu: Fix __x86_return_thunk symbol type tip-bot2 for Peter Zijlstra
2023-08-14 11:44 ` Peter Zijlstra [this message]
2023-08-16 7:55 ` [tip: x86/urgent] x86/cpu: Fix up srso_safe_ret() and __x86_return_thunk() tip-bot2 for Peter Zijlstra
2023-08-14 11:44 ` [PATCH v2 03/11] objtool/x86: Fix SRSO mess Peter Zijlstra
2023-08-14 12:54 ` Andrew.Cooper3
2023-08-16 7:55 ` [tip: x86/urgent] " tip-bot2 for Peter Zijlstra
2023-08-16 11:59 ` Peter Zijlstra
2023-08-16 20:31 ` Josh Poimboeuf
2023-08-16 22:08 ` [PATCH] objtool/x86: Fixup frame-pointer vs rethunk Peter Zijlstra
2023-08-16 22:22 ` Josh Poimboeuf
2023-08-17 8:39 ` [tip: x86/urgent] " tip-bot2 for Peter Zijlstra
2023-08-14 11:44 ` [PATCH v2 04/11] x86/alternative: Make custom return thunk unconditional Peter Zijlstra
2023-08-16 7:55 ` [tip: x86/urgent] " tip-bot2 for Peter Zijlstra
2023-08-14 11:44 ` [PATCH v2 05/11] x86/cpu: Clean up SRSO return thunk mess Peter Zijlstra
2023-08-14 13:02 ` Borislav Petkov
2023-08-14 17:48 ` Borislav Petkov
2023-08-15 21:29 ` Nathan Chancellor
2023-08-15 22:43 ` Peter Zijlstra
2023-08-16 7:38 ` Borislav Petkov
2023-08-16 14:52 ` Nathan Chancellor
2023-08-16 15:08 ` Borislav Petkov
2023-08-16 7:55 ` [tip: x86/urgent] " tip-bot2 for Peter Zijlstra
2023-08-16 18:58 ` Nathan Chancellor
2023-08-16 19:24 ` Borislav Petkov
2023-08-16 19:30 ` Nathan Chancellor
2023-08-16 19:42 ` Borislav Petkov
2023-08-16 19:57 ` Borislav Petkov
2023-08-16 21:20 ` tip-bot2 for Peter Zijlstra
2023-08-14 11:44 ` [PATCH v2 06/11] x86/cpu: Rename original retbleed methods Peter Zijlstra
2023-08-14 19:41 ` Josh Poimboeuf
2023-08-16 7:55 ` [tip: x86/urgent] " tip-bot2 for Peter Zijlstra
2023-08-16 21:20 ` tip-bot2 for Peter Zijlstra
2023-08-14 11:44 ` [PATCH v2 07/11] x86/cpu: Rename srso_(.*)_alias to srso_alias_\1 Peter Zijlstra
2023-08-16 7:55 ` [tip: x86/urgent] " tip-bot2 for Peter Zijlstra
2023-08-16 21:20 ` tip-bot2 for Peter Zijlstra
2023-08-14 11:44 ` [PATCH v2 08/11] x86/cpu: Cleanup the untrain mess Peter Zijlstra
2023-08-16 7:55 ` [tip: x86/urgent] " tip-bot2 for Peter Zijlstra
2023-08-16 21:20 ` tip-bot2 for Peter Zijlstra
2023-08-14 11:44 ` [PATCH v2 09/11] x86/cpu/kvm: Provide UNTRAIN_RET_VM Peter Zijlstra
2023-08-16 7:55 ` [tip: x86/urgent] " tip-bot2 for Peter Zijlstra
2023-08-16 21:20 ` tip-bot2 for Peter Zijlstra
2023-08-14 11:44 ` [PATCH v2 10/11] x86/alternatives: Simplify ALTERNATIVE_n() Peter Zijlstra
2023-08-15 20:49 ` Nikolay Borisov
2023-08-15 22:44 ` Peter Zijlstra
2023-09-07 8:31 ` Borislav Petkov
2023-09-07 11:09 ` Peter Zijlstra
2023-09-07 11:11 ` Peter Zijlstra
2023-09-07 11:16 ` Peter Zijlstra
2023-09-07 15:06 ` Borislav Petkov
2023-09-07 15:30 ` Borislav Petkov
2023-09-09 7:50 ` Borislav Petkov
2023-09-09 9:25 ` Peter Zijlstra
2023-09-09 9:42 ` Peter Zijlstra
2023-09-10 14:42 ` Borislav Petkov
2023-09-12 9:27 ` Peter Zijlstra
2023-09-12 9:44 ` Peter Zijlstra
2023-09-13 4:37 ` Borislav Petkov
2023-09-13 8:46 ` Peter Zijlstra
2023-09-13 14:38 ` Borislav Petkov
2023-09-13 16:14 ` Peter Zijlstra
2023-09-15 7:46 ` Peter Zijlstra
2023-09-15 7:51 ` Peter Zijlstra
2023-09-15 12:05 ` Borislav Petkov
2023-09-13 4:24 ` Borislav Petkov
2023-08-14 11:44 ` [PATCH v2 11/11] x86/cpu: Use fancy alternatives to get rid of entry_untrain_ret() Peter Zijlstra
2023-08-14 16:44 ` [PATCH v2 00/11] Fix up SRSO stuff Borislav Petkov
2023-08-14 19:51 ` Josh Poimboeuf
2023-08-14 19:57 ` Borislav Petkov
2023-08-14 20:01 ` Josh Poimboeuf
2023-08-14 20:09 ` Borislav Petkov
2023-08-15 14:26 ` [PATCH] x86/srso: Explain the untraining sequences a bit more Borislav Petkov
2023-08-15 15:41 ` Nikolay Borisov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20230814121148.637802730@infradead.org \
--to=peterz@infradead.org \
--cc=Andrew.Cooper3@citrix.com \
--cc=David.Kaplan@amd.com \
--cc=gregkh@linuxfoundation.org \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nik.borisov@suse.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome