[PATCH v2] riscv: add Siflower RISC-V SoC family Kconfig support

[PATCH v2] riscv: add Siflower RISC-V SoC family Kconfig support

[Chuanhong Guo]

Siflower RISC-V SoCs, including SF21A6826, SF21H8898 and some other
upcomping chips, are RISC-V chips with T-Head C908 cores for home
routers and gateways. Add a Kconfig entry named ARCH_SIFLOWER for
them.
Notably these chips uses ARM PL011 for UART. ARM_AMBA is selected
for its driver.

Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
---

Changes since v1:
 * removed deprecated SOC_ symbol

 arch/riscv/Kconfig.socs | 6 ++++++
 1 file changed, 6 insertions(+)

diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
index 1916cf7ba450..64a49e7ea03e 100644
--- a/arch/riscv/Kconfig.socs
+++ b/arch/riscv/Kconfig.socs
@@ -19,6 +19,12 @@ config ARCH_SIFIVE
 	help
 	  This enables support for SiFive SoC platform hardware.
 
+config ARCH_SIFLOWER
+	bool "Siflower RISC-V SoCs"
+	select ARM_AMBA if TTY
+	help
+	  This enables support for Siflower RISC-V SoC platform hardware.
+
 config ARCH_SOPHGO
 	bool "Sophgo SoCs"
 	help
-- 
2.48.1

Re: [PATCH v2] riscv: add Siflower RISC-V SoC family Kconfig support

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1186 bytes --]

On Mon, Jan 20, 2025 at 10:23:58AM +0800, Chuanhong Guo wrote:
> Siflower RISC-V SoCs, including SF21A6826, SF21H8898 and some other
> upcomping chips, are RISC-V chips with T-Head C908 cores for home
> routers and gateways. Add a Kconfig entry named ARCH_SIFLOWER for
> them.
> Notably these chips uses ARM PL011 for UART. ARM_AMBA is selected
> for its driver.
> 
> Signed-off-by: Chuanhong Guo <gch981213@gmail.com>

This needs to be in a series with the user (your dts)

> ---
> 
> Changes since v1:
>  * removed deprecated SOC_ symbol
> 
>  arch/riscv/Kconfig.socs | 6 ++++++
>  1 file changed, 6 insertions(+)
> 
> diff --git a/arch/riscv/Kconfig.socs b/arch/riscv/Kconfig.socs
> index 1916cf7ba450..64a49e7ea03e 100644
> --- a/arch/riscv/Kconfig.socs
> +++ b/arch/riscv/Kconfig.socs
> @@ -19,6 +19,12 @@ config ARCH_SIFIVE
>  	help
>  	  This enables support for SiFive SoC platform hardware.
>  
> +config ARCH_SIFLOWER
> +	bool "Siflower RISC-V SoCs"
> +	select ARM_AMBA if TTY
> +	help
> +	  This enables support for Siflower RISC-V SoC platform hardware.
> +
>  config ARCH_SOPHGO
>  	bool "Sophgo SoCs"
>  	help
> -- 
> 2.48.1
> 
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

Re: [PATCH v2] riscv: add Siflower RISC-V SoC family Kconfig support

[Chuanhong Guo]

Hello!

On Tue, Jan 21, 2025 at 2:48 AM Conor Dooley <conor@kernel.org> wrote:
>
> On Mon, Jan 20, 2025 at 10:23:58AM +0800, Chuanhong Guo wrote:
> > Siflower RISC-V SoCs, including SF21A6826, SF21H8898 and some other
> > upcomping chips, are RISC-V chips with T-Head C908 cores for home
> > routers and gateways. Add a Kconfig entry named ARCH_SIFLOWER for
> > them.
> > Notably these chips uses ARM PL011 for UART. ARM_AMBA is selected
> > for its driver.
> >
> > Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
>
> This needs to be in a series with the user (your dts)

Could the user be a driver Kconfig instead? When submitting a GPIO driver I
was suggested to not depend on architecture symbol and add soc-specific
ones to arch/ first. [0]

I still need to polish the clock/reset driver a bit before submitting them.
Without a clock driver I can't really submit a dts with meaningful content.

[0] https://lore.kernel.org/linux-gpio/CACRpkdYi_+aQ5L-c4=w9MK-6Uh0e9dX0nnU6LcZcHd90j97q7w@mail.gmail.com/T/#mf2352fb36ed2cb8c6574d9eb0d4c261d9346bf10

-- 
Regards,
Chuanhong Guo

Re: [PATCH v2] riscv: add Siflower RISC-V SoC family Kconfig support

[Conor Dooley]

[-- Attachment #1: Type: text/plain, Size: 1237 bytes --]

On Tue, Jan 21, 2025 at 09:04:47AM +0800, Chuanhong Guo wrote:
> Hello!
> 
> On Tue, Jan 21, 2025 at 2:48 AM Conor Dooley <conor@kernel.org> wrote:
> >
> > On Mon, Jan 20, 2025 at 10:23:58AM +0800, Chuanhong Guo wrote:
> > > Siflower RISC-V SoCs, including SF21A6826, SF21H8898 and some other
> > > upcomping chips, are RISC-V chips with T-Head C908 cores for home
> > > routers and gateways. Add a Kconfig entry named ARCH_SIFLOWER for
> > > them.
> > > Notably these chips uses ARM PL011 for UART. ARM_AMBA is selected
> > > for its driver.
> > >
> > > Signed-off-by: Chuanhong Guo <gch981213@gmail.com>
> >
> > This needs to be in a series with the user (your dts)
> 
> Could the user be a driver Kconfig instead? When submitting a GPIO driver I
> was suggested to not depend on architecture symbol and add soc-specific
> ones to arch/ first. [0]
> 
> I still need to polish the clock/reset driver a bit before submitting them.
> Without a clock driver I can't really submit a dts with meaningful content.
> 
> [0] https://lore.kernel.org/linux-gpio/CACRpkdYi_+aQ5L-c4=w9MK-6Uh0e9dX0nnU6LcZcHd90j97q7w@mail.gmail.com/T/#mf2352fb36ed2cb8c6574d9eb0d4c261d9346bf10

Send it with the GPIO driver then please.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 228 bytes --]