From: Michal Suchanek <msuchanek@suse.de>
Cc: Michal Suchanek <msuchanek@suse.de>,
Peter Huewe <peterhuewe@gmx.de>,
Jarkko Sakkinen <jarkko@kernel.org>,
Jason Gunthorpe <jgg@ziepe.ca>,
linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
Jonathan McDowell <noodles@earth.li>
Subject: [PATCH] tpm: tis: Increase the default for timeouts B and C
Date: Wed, 2 Apr 2025 19:21:30 +0200 [thread overview]
Message-ID: <20250402172134.7751-1-msuchanek@suse.de> (raw)
With some Infineon chips the timeouts in tpm_tis_send_data (both B and
C) can reach up to about 2250 ms.
Extend the timeout duration to accommodate this.
Link: https://lore.kernel.org/linux-integrity/Z5pI07m0Muapyu9w@kitsune.suse.cz/
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
An alternative would be to add an entry to vendor_timeout_overrides but
I do not know how to determine the chip IDs to put into this table.
---
drivers/char/tpm/tpm_tis_core.h | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/char/tpm/tpm_tis_core.h b/drivers/char/tpm/tpm_tis_core.h
index 970d02c337c7..1ff565be2175 100644
--- a/drivers/char/tpm/tpm_tis_core.h
+++ b/drivers/char/tpm/tpm_tis_core.h
@@ -54,7 +54,7 @@ enum tis_int_flags {
enum tis_defaults {
TIS_MEM_LEN = 0x5000,
TIS_SHORT_TIMEOUT = 750, /* ms */
- TIS_LONG_TIMEOUT = 2000, /* 2 sec */
+ TIS_LONG_TIMEOUT = 4000, /* 2 sec */
TIS_TIMEOUT_MIN_ATML = 14700, /* usecs */
TIS_TIMEOUT_MAX_ATML = 15000, /* usecs */
};
@@ -64,7 +64,7 @@ enum tis_defaults {
*/
#define TIS_TIMEOUT_A_MAX max_t(int, TIS_SHORT_TIMEOUT, TPM2_TIMEOUT_A)
#define TIS_TIMEOUT_B_MAX max_t(int, TIS_LONG_TIMEOUT, TPM2_TIMEOUT_B)
-#define TIS_TIMEOUT_C_MAX max_t(int, TIS_SHORT_TIMEOUT, TPM2_TIMEOUT_C)
+#define TIS_TIMEOUT_C_MAX max_t(int, TIS_LONG_TIMEOUT, TPM2_TIMEOUT_C)
#define TIS_TIMEOUT_D_MAX max_t(int, TIS_SHORT_TIMEOUT, TPM2_TIMEOUT_D)
#define TPM_ACCESS(l) (0x0000 | ((l) << 12))
--
2.47.1
next reply other threads:[~2025-04-02 17:21 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-04-02 17:21 Michal Suchanek [this message]
2025-04-02 17:45 ` Jonathan McDowell
2025-04-02 20:07 ` Michal Suchánek
2025-04-03 9:31 ` Michal Suchánek
2025-04-03 11:00 ` Jonathan McDowell
2025-04-03 11:56 ` Michal Suchánek
2025-04-03 13:00 ` Jonathan McDowell
2025-04-03 14:11 ` Michal Suchánek
2025-04-03 18:25 ` [PATCH] tpm: tis: Increase the default for timeout B Michal Suchanek
2025-04-03 18:28 ` Paul Menzel
2025-04-04 8:23 ` [PATCH v3] tpm: tis: Double the timeout B to 4s Michal Suchanek
2025-04-04 8:53 ` Jarkko Sakkinen
2025-05-14 12:10 ` Michal Suchánek
2025-05-15 1:41 ` Jarkko Sakkinen
2025-05-15 11:17 ` Jarkko Sakkinen
2025-04-03 18:49 ` [PATCH] tpm: tis: Increase the default for timeout B Jarkko Sakkinen
2025-04-04 7:53 ` Michal Suchánek
2025-04-04 8:12 ` Michal Suchánek
2025-04-04 8:14 ` Jarkko Sakkinen
2025-04-03 18:45 ` [PATCH] tpm: tis: Increase the default for timeouts B and C Jarkko Sakkinen
2025-04-03 20:43 ` Jonathan McDowell
2025-04-04 7:51 ` Michal Suchánek
2025-04-04 8:10 ` Jarkko Sakkinen
2025-04-04 9:31 ` Jonathan McDowell
2025-04-04 11:58 ` Jarkko Sakkinen
2025-04-03 18:38 ` Jarkko Sakkinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250402172134.7751-1-msuchanek@suse.de \
--to=msuchanek@suse.de \
--cc=jarkko@kernel.org \
--cc=jgg@ziepe.ca \
--cc=linux-integrity@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=noodles@earth.li \
--cc=peterhuewe@gmx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®