mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Michal Suchanek <msuchanek@suse.de>
Cc: Michal Suchanek <msuchanek@suse.de>,
	Peter Huewe <peterhuewe@gmx.de>,
	Jarkko Sakkinen <jarkko@kernel.org>,
	Jason Gunthorpe <jgg@ziepe.ca>,
	linux-integrity@vger.kernel.org, linux-kernel@vger.kernel.org,
	Jonathan McDowell <noodles@earth.li>,
	Paul Menzel <pmenzel@molgen.mpg.de>
Subject: [PATCH v3] tpm: tis: Double the timeout B to 4s
Date: Fri,  4 Apr 2025 10:23:14 +0200	[thread overview]
Message-ID: <20250404082325.13876-1-msuchanek@suse.de> (raw)
In-Reply-To: <4e4640bd-0313-4594-9667-82340ed9368a@molgen.mpg.de>

With some Infineon chips the timeouts in tpm_tis_send_data (both B and
C) can reach up to about 2250 ms.

Timeout C is retried since
commit de9e33df7762 ("tpm, tpm_tis: Workaround failed command reception on Infineon devices")

Timeout B still needs to be extended.

The problem is most commonly encountered with context related operation
such as load context/save context. These are issued directly by the
kernel, and there is no retry logic for them.

When a filesystem is set up to use the TPM for unlocking the boot fails,
and restarting the userspace service is ineffective. This is likely
because ignoring a load context/save context result puts the real TPM
state and the TPM state expected by the kernel out of sync.

Chips known to be affected:
tpm_tis IFX1522:00: 2.0 TPM (device-id 0x1D, rev-id 54)
Description: SLB9672
Firmware Revision: 15.22

tpm_tis MSFT0101:00: 2.0 TPM (device-id 0x1B, rev-id 22)
Firmware Revision: 7.83

tpm_tis MSFT0101:00: 2.0 TPM (device-id 0x1A, rev-id 16)
Firmware Revision: 5.63

Link: https://lore.kernel.org/linux-integrity/Z5pI07m0Muapyu9w@kitsune.suse.cz/
Signed-off-by: Michal Suchanek <msuchanek@suse.de>
---
v2: Only extend timeout B
v3: Update commit message
---
 drivers/char/tpm/tpm_tis_core.h | 2 +-
 include/linux/tpm.h             | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/drivers/char/tpm/tpm_tis_core.h b/drivers/char/tpm/tpm_tis_core.h
index 970d02c337c7..6c3aa480396b 100644
--- a/drivers/char/tpm/tpm_tis_core.h
+++ b/drivers/char/tpm/tpm_tis_core.h
@@ -54,7 +54,7 @@ enum tis_int_flags {
 enum tis_defaults {
 	TIS_MEM_LEN = 0x5000,
 	TIS_SHORT_TIMEOUT = 750,	/* ms */
-	TIS_LONG_TIMEOUT = 2000,	/* 2 sec */
+	TIS_LONG_TIMEOUT = 4000,	/* 4 secs */
 	TIS_TIMEOUT_MIN_ATML = 14700,	/* usecs */
 	TIS_TIMEOUT_MAX_ATML = 15000,	/* usecs */
 };
diff --git a/include/linux/tpm.h b/include/linux/tpm.h
index 6c3125300c00..3db0b6a87d45 100644
--- a/include/linux/tpm.h
+++ b/include/linux/tpm.h
@@ -224,7 +224,7 @@ enum tpm2_const {
 
 enum tpm2_timeouts {
 	TPM2_TIMEOUT_A          =    750,
-	TPM2_TIMEOUT_B          =   2000,
+	TPM2_TIMEOUT_B          =   4000,
 	TPM2_TIMEOUT_C          =    200,
 	TPM2_TIMEOUT_D          =     30,
 	TPM2_DURATION_SHORT     =     20,
-- 
2.47.1


  reply	other threads:[~2025-04-04  8:23 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-04-02 17:21 [PATCH] tpm: tis: Increase the default for timeouts B and C Michal Suchanek
2025-04-02 17:45 ` Jonathan McDowell
2025-04-02 20:07   ` Michal Suchánek
2025-04-03  9:31     ` Michal Suchánek
2025-04-03 11:00     ` Jonathan McDowell
2025-04-03 11:56       ` Michal Suchánek
2025-04-03 13:00         ` Jonathan McDowell
2025-04-03 14:11           ` Michal Suchánek
2025-04-03 18:25           ` [PATCH] tpm: tis: Increase the default for timeout B Michal Suchanek
2025-04-03 18:28             ` Paul Menzel
2025-04-04  8:23               ` Michal Suchanek [this message]
2025-04-04  8:53                 ` [PATCH v3] tpm: tis: Double the timeout B to 4s Jarkko Sakkinen
2025-05-14 12:10                   ` Michal Suchánek
2025-05-15  1:41                     ` Jarkko Sakkinen
2025-05-15 11:17                       ` Jarkko Sakkinen
2025-04-03 18:49             ` [PATCH] tpm: tis: Increase the default for timeout B Jarkko Sakkinen
2025-04-04  7:53               ` Michal Suchánek
2025-04-04  8:12               ` Michal Suchánek
2025-04-04  8:14                 ` Jarkko Sakkinen
2025-04-03 18:45   ` [PATCH] tpm: tis: Increase the default for timeouts B and C Jarkko Sakkinen
2025-04-03 20:43     ` Jonathan McDowell
2025-04-04  7:51       ` Michal Suchánek
2025-04-04  8:10         ` Jarkko Sakkinen
2025-04-04  9:31           ` Jonathan McDowell
2025-04-04 11:58             ` Jarkko Sakkinen
2025-04-03 18:38 ` Jarkko Sakkinen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250404082325.13876-1-msuchanek@suse.de \
    --to=msuchanek@suse.de \
    --cc=jarkko@kernel.org \
    --cc=jgg@ziepe.ca \
    --cc=linux-integrity@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=noodles@earth.li \
    --cc=peterhuewe@gmx.de \
    --cc=pmenzel@molgen.mpg.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®