mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: David Kaplan <david.kaplan@amd.com>
To: Thomas Gleixner <tglx@linutronix.de>,
	Borislav Petkov <bp@alien8.de>,
	Peter Zijlstra <peterz@infradead.org>,
	Josh Poimboeuf <jpoimboe@kernel.org>,
	Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
	Ingo Molnar <mingo@redhat.com>,
	Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
	"H . Peter Anvin" <hpa@zytor.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH v6 12/21] x86/bugs: Add attack vector controls for retbleed
Date: Mon, 7 Jul 2025 13:33:07 -0500	[thread overview]
Message-ID: <20250707183316.1349127-13-david.kaplan@amd.com> (raw)
In-Reply-To: <20250707183316.1349127-1-david.kaplan@amd.com>

Use attack vector controls to determine if retbleed mitigation is
required.

Disable SMT if cross-thread protection is desired and STIBP is not
available.

Signed-off-by: David Kaplan <david.kaplan@amd.com>
---
 arch/x86/kernel/cpu/bugs.c | 11 ++++++++---
 1 file changed, 8 insertions(+), 3 deletions(-)

diff --git a/arch/x86/kernel/cpu/bugs.c b/arch/x86/kernel/cpu/bugs.c
index f4b3d879ba38..1e2dab9be7db 100644
--- a/arch/x86/kernel/cpu/bugs.c
+++ b/arch/x86/kernel/cpu/bugs.c
@@ -1309,7 +1309,7 @@ early_param("retbleed", retbleed_parse_cmdline);
 
 static void __init retbleed_select_mitigation(void)
 {
-	if (!boot_cpu_has_bug(X86_BUG_RETBLEED) || cpu_mitigations_off()) {
+	if (!boot_cpu_has_bug(X86_BUG_RETBLEED)) {
 		retbleed_mitigation = RETBLEED_MITIGATION_NONE;
 		return;
 	}
@@ -1346,6 +1346,11 @@ static void __init retbleed_select_mitigation(void)
 	if (retbleed_mitigation != RETBLEED_MITIGATION_AUTO)
 		return;
 
+	if (!should_mitigate_vuln(X86_BUG_RETBLEED)) {
+		retbleed_mitigation = RETBLEED_MITIGATION_NONE;
+		return;
+	}
+
 	/* Intel mitigation selected in retbleed_update_mitigation() */
 	if (boot_cpu_data.x86_vendor == X86_VENDOR_AMD ||
 	    boot_cpu_data.x86_vendor == X86_VENDOR_HYGON) {
@@ -1369,7 +1374,7 @@ static void __init retbleed_select_mitigation(void)
 
 static void __init retbleed_update_mitigation(void)
 {
-	if (!boot_cpu_has_bug(X86_BUG_RETBLEED) || cpu_mitigations_off())
+	if (!boot_cpu_has_bug(X86_BUG_RETBLEED))
 		return;
 
 	 /* ITS can also enable stuffing */
@@ -1464,7 +1469,7 @@ static void __init retbleed_apply_mitigation(void)
 	}
 
 	if (mitigate_smt && !boot_cpu_has(X86_FEATURE_STIBP) &&
-	    (retbleed_nosmt || cpu_mitigations_auto_nosmt()))
+	    (retbleed_nosmt || smt_mitigations == SMT_MITIGATIONS_ON))
 		cpu_smt_disable(false);
 }
 
-- 
2.34.1


  parent reply	other threads:[~2025-07-07 18:33 UTC|newest]

Thread overview: 50+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-07-07 18:32 [PATCH v6 00/21] Attack vector controls (part 2) David Kaplan
2025-07-07 18:32 ` [PATCH v6 01/21] Documentation/x86: Document new attack vector controls David Kaplan
2025-07-09 15:57   ` [PATCH v7 01/22] " David Kaplan
2025-07-11 16:09     ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:32 ` [PATCH v6 02/21] cpu: Define attack vectors David Kaplan
2025-07-10 10:42   ` Borislav Petkov
2025-07-10 14:02     ` Kaplan, David
2025-07-10 15:17       ` Borislav Petkov
2025-07-10 15:22         ` Kaplan, David
2025-07-11 16:09   ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:32 ` [PATCH v6 03/21] x86/Kconfig: Add arch attack vector support David Kaplan
2025-07-11 16:09   ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:32 ` [PATCH v6 04/21] x86/bugs: Define attack vectors relevant for each bug David Kaplan
2025-07-11 16:09   ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 05/21] x86/bugs: Add attack vector controls for MDS David Kaplan
2025-07-11 16:09   ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 06/21] x86/bugs: Add attack vector controls for TAA David Kaplan
2025-07-11 16:09   ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 07/21] x86/bugs: Add attack vector controls for MMIO David Kaplan
2025-07-11 16:09   ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 08/21] x86/bugs: Add attack vector controls for RFDS David Kaplan
2025-07-11 16:09   ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 09/21] x86/bugs: Add attack vector controls for SRBDS David Kaplan
2025-07-11 16:09   ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 10/21] x86/bugs: Add attack vector controls for GDS David Kaplan
2025-07-11 16:09   ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 11/21] x86/bugs: Add attack vector controls for spectre_v1 David Kaplan
2025-07-11 16:09   ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` David Kaplan [this message]
2025-07-11 16:09   ` [tip: x86/bugs] x86/bugs: Add attack vector controls for retbleed tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 13/21] x86/bugs: Add attack vector controls for spectre_v2_user David Kaplan
2025-07-11 16:09   ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 14/21] x86/bugs: Add attack vector controls for BHI David Kaplan
2025-07-11 16:09   ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 15/21] x86/bugs: Add attack vector controls for spectre_v2 David Kaplan
2025-07-11 16:09   ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 16/21] x86/bugs: Add attack vector controls for L1TF David Kaplan
2025-07-11 16:09   ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 17/21] x86/bugs: Add attack vector controls for SRSO David Kaplan
2025-07-11 16:09   ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 18/21] x86/bugs: Add attack vector controls for ITS David Kaplan
2025-07-11 16:09   ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 19/21] x86/pti: Add attack vector controls for PTI David Kaplan
2025-07-11 16:09   ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 20/21] x86/bugs: Print enabled attack vectors David Kaplan
2025-07-11 16:09   ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 21/21] cpu: Show attack vectors in sysfs David Kaplan
2025-07-09 18:47   ` Borislav Petkov
2025-07-09 15:58 ` [PATCH v7 19/22] x86/bugs: Add attack vector controls for TSA David Kaplan
2025-07-11 16:09   ` [tip: x86/bugs] " tip-bot2 for David Kaplan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20250707183316.1349127-13-david.kaplan@amd.com \
    --to=david.kaplan@amd.com \
    --cc=bp@alien8.de \
    --cc=dave.hansen@linux.intel.com \
    --cc=hpa@zytor.com \
    --cc=jpoimboe@kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@redhat.com \
    --cc=pawan.kumar.gupta@linux.intel.com \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®