From: David Kaplan <david.kaplan@amd.com>
To: Thomas Gleixner <tglx@linutronix.de>,
Borislav Petkov <bp@alien8.de>,
Peter Zijlstra <peterz@infradead.org>,
Josh Poimboeuf <jpoimboe@kernel.org>,
Pawan Gupta <pawan.kumar.gupta@linux.intel.com>,
Ingo Molnar <mingo@redhat.com>,
Dave Hansen <dave.hansen@linux.intel.com>, <x86@kernel.org>,
"H . Peter Anvin" <hpa@zytor.com>
Cc: <linux-kernel@vger.kernel.org>
Subject: [PATCH v6 05/21] x86/bugs: Add attack vector controls for MDS
Date: Mon, 7 Jul 2025 13:33:00 -0500 [thread overview]
Message-ID: <20250707183316.1349127-6-david.kaplan@amd.com> (raw)
In-Reply-To: <20250707183316.1349127-1-david.kaplan@amd.com>
Use attack vector controls to determine if MDS mitigation is required.
The global mitigations=off command now simply disables all attack vectors
so explicit checking of mitigations=off is no longer needed.
If cross-thread attack mitigations are required, disable SMT.
Signed-off-by: David Kaplan <david.kaplan@amd.com>
---
arch/x86/kernel/cpu/bugs.c | 14 +++++++++-----
1 file changed, 9 insertions(+), 5 deletions(-)
diff --git a/arch/x86/kernel/cpu/bugs.c b/arch/x86/kernel/cpu/bugs.c
index 1fa0704a8694..65d482aa450f 100644
--- a/arch/x86/kernel/cpu/bugs.c
+++ b/arch/x86/kernel/cpu/bugs.c
@@ -437,13 +437,17 @@ static bool verw_clear_cpu_buf_mitigation_selected __ro_after_init;
static void __init mds_select_mitigation(void)
{
- if (!boot_cpu_has_bug(X86_BUG_MDS) || cpu_mitigations_off()) {
+ if (!boot_cpu_has_bug(X86_BUG_MDS)) {
mds_mitigation = MDS_MITIGATION_OFF;
return;
}
- if (mds_mitigation == MDS_MITIGATION_AUTO)
- mds_mitigation = MDS_MITIGATION_FULL;
+ if (mds_mitigation == MDS_MITIGATION_AUTO) {
+ if (should_mitigate_vuln(X86_BUG_MDS))
+ mds_mitigation = MDS_MITIGATION_FULL;
+ else
+ mds_mitigation = MDS_MITIGATION_OFF;
+ }
if (mds_mitigation == MDS_MITIGATION_OFF)
return;
@@ -453,7 +457,7 @@ static void __init mds_select_mitigation(void)
static void __init mds_update_mitigation(void)
{
- if (!boot_cpu_has_bug(X86_BUG_MDS) || cpu_mitigations_off())
+ if (!boot_cpu_has_bug(X86_BUG_MDS))
return;
/* If TAA, MMIO, or RFDS are being mitigated, MDS gets mitigated too. */
@@ -474,7 +478,7 @@ static void __init mds_apply_mitigation(void)
mds_mitigation == MDS_MITIGATION_VMWERV) {
setup_force_cpu_cap(X86_FEATURE_CLEAR_CPU_BUF);
if (!boot_cpu_has(X86_BUG_MSBDS_ONLY) &&
- (mds_nosmt || cpu_mitigations_auto_nosmt()))
+ (mds_nosmt || smt_mitigations == SMT_MITIGATIONS_ON))
cpu_smt_disable(false);
}
}
--
2.34.1
next prev parent reply other threads:[~2025-07-07 18:33 UTC|newest]
Thread overview: 50+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-07 18:32 [PATCH v6 00/21] Attack vector controls (part 2) David Kaplan
2025-07-07 18:32 ` [PATCH v6 01/21] Documentation/x86: Document new attack vector controls David Kaplan
2025-07-09 15:57 ` [PATCH v7 01/22] " David Kaplan
2025-07-11 16:09 ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:32 ` [PATCH v6 02/21] cpu: Define attack vectors David Kaplan
2025-07-10 10:42 ` Borislav Petkov
2025-07-10 14:02 ` Kaplan, David
2025-07-10 15:17 ` Borislav Petkov
2025-07-10 15:22 ` Kaplan, David
2025-07-11 16:09 ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:32 ` [PATCH v6 03/21] x86/Kconfig: Add arch attack vector support David Kaplan
2025-07-11 16:09 ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:32 ` [PATCH v6 04/21] x86/bugs: Define attack vectors relevant for each bug David Kaplan
2025-07-11 16:09 ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` David Kaplan [this message]
2025-07-11 16:09 ` [tip: x86/bugs] x86/bugs: Add attack vector controls for MDS tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 06/21] x86/bugs: Add attack vector controls for TAA David Kaplan
2025-07-11 16:09 ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 07/21] x86/bugs: Add attack vector controls for MMIO David Kaplan
2025-07-11 16:09 ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 08/21] x86/bugs: Add attack vector controls for RFDS David Kaplan
2025-07-11 16:09 ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 09/21] x86/bugs: Add attack vector controls for SRBDS David Kaplan
2025-07-11 16:09 ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 10/21] x86/bugs: Add attack vector controls for GDS David Kaplan
2025-07-11 16:09 ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 11/21] x86/bugs: Add attack vector controls for spectre_v1 David Kaplan
2025-07-11 16:09 ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 12/21] x86/bugs: Add attack vector controls for retbleed David Kaplan
2025-07-11 16:09 ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 13/21] x86/bugs: Add attack vector controls for spectre_v2_user David Kaplan
2025-07-11 16:09 ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 14/21] x86/bugs: Add attack vector controls for BHI David Kaplan
2025-07-11 16:09 ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 15/21] x86/bugs: Add attack vector controls for spectre_v2 David Kaplan
2025-07-11 16:09 ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 16/21] x86/bugs: Add attack vector controls for L1TF David Kaplan
2025-07-11 16:09 ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 17/21] x86/bugs: Add attack vector controls for SRSO David Kaplan
2025-07-11 16:09 ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 18/21] x86/bugs: Add attack vector controls for ITS David Kaplan
2025-07-11 16:09 ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 19/21] x86/pti: Add attack vector controls for PTI David Kaplan
2025-07-11 16:09 ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 20/21] x86/bugs: Print enabled attack vectors David Kaplan
2025-07-11 16:09 ` [tip: x86/bugs] " tip-bot2 for David Kaplan
2025-07-07 18:33 ` [PATCH v6 21/21] cpu: Show attack vectors in sysfs David Kaplan
2025-07-09 18:47 ` Borislav Petkov
2025-07-09 15:58 ` [PATCH v7 19/22] x86/bugs: Add attack vector controls for TSA David Kaplan
2025-07-11 16:09 ` [tip: x86/bugs] " tip-bot2 for David Kaplan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20250707183316.1349127-6-david.kaplan@amd.com \
--to=david.kaplan@amd.com \
--cc=bp@alien8.de \
--cc=dave.hansen@linux.intel.com \
--cc=hpa@zytor.com \
--cc=jpoimboe@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pawan.kumar.gupta@linux.intel.com \
--cc=peterz@infradead.org \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®