From: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
To: Ingo Molnar <mingo@redhat.com>,
Peter Zijlstra <peterz@infradead.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Steven Rostedt <rostedt@goodmis.org>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
Valentin Schneider <vschneid@redhat.com>,
Tim C Chen <tim.c.chen@linux.intel.com>,
Chen Yu <yu.c.chen@intel.com>,
Christian Loehle <christian.loehle@arm.com>,
K Prateek Nayak <kprateek.nayak@amd.com>,
Barry Song <baohua@kernel.org>
Cc: "Rafael J. Wysocki" <rafael@kernel.org>,
Andrea Righi <arighi@nvidia.com>, Len Brown <lenb@kernel.org>,
ricardo.neri@intel.com, linux-kernel@vger.kernel.org,
Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
Subject: [PATCH v5 1/6] sched/fair: Do not skip CPUs of similar capacity with busy SMT siblings
Date: Mon, 22 Jun 2026 17:05:51 -0700 [thread overview]
Message-ID: <20260622-rneri-fix-cas-clusters-v5-1-19968f2d1497@linux.intel.com> (raw)
In-Reply-To: <20260622-rneri-fix-cas-clusters-v5-0-19968f2d1497@linux.intel.com>
When picking a busiest CPU with only one running task, the function
sched_balance_find_src_rq() skips candidate CPUs if the destination CPU has
less than ~5% extra capacity. This condition only holds if all the SMT
siblings of a CPU are idle.
SMT siblings share the computing resources of a physical core and this
results in reduced capacity if more than one sibling is busy.
Skipping a CPU as described would prevent the load balancer from pulling
tasks from a scheduling group previously and correctly identified as
group_smt_balance (i.e., one with more than one task running).
Do not skip a candidate CPU of similar capacity if it has busy SMT
siblings.
Reviewed-by: K Prateek Nayak <kprateek.nayak@amd.com>
Signed-off-by: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
---
Changes in v5:
* Optimized logic to identify CPUs with busy SMT siblings only when
needed. (Prateek, Chen Yu)
* Added Reviewed-by tag from Prateek. Thanks!
* Christian also provided his Reviewed-by tag, but the patch changed
significantly since then. I did not think it was correct to keep it
without him reviewing the updated patch first.
Changes in v4:
* Introduced this patch.
Changes in v3:
* N/A
Changes in v2:
* N/A
---
kernel/sched/fair.c | 14 +++++++++++---
1 file changed, 11 insertions(+), 3 deletions(-)
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index d78467ec6ee1..892abd7fcc18 100644
--- a/kernel/sched/fair.c
+++ b/kernel/sched/fair.c
@@ -12976,9 +12976,17 @@ static struct rq *sched_balance_find_src_rq(struct lb_env *env,
* average load.
*/
if (env->sd->flags & SD_ASYM_CPUCAPACITY &&
- !capacity_greater(capacity_of(env->dst_cpu), capacity) &&
- nr_running == 1)
- continue;
+ nr_running == 1) {
+ bool smt_degraded_cap = sched_smt_active() && !is_core_idle(i);
+
+ /*
+ * Busy SMT siblings reduce the capacity of CPU @i. Do
+ * not skip it in this case.
+ */
+ if (!smt_degraded_cap &&
+ !capacity_greater(capacity_of(env->dst_cpu), capacity))
+ continue;
+ }
/*
* Make sure we only pull tasks from a CPU of lower priority
--
2.43.0
next prev parent reply other threads:[~2026-06-22 23:55 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-06-23 0:05 [PATCH v5 0/6] sched: Fix cluster scheduling in the presence of asymmetric capacity Ricardo Neri
2026-06-23 0:05 ` Ricardo Neri [this message]
2026-06-23 7:13 ` [PATCH v5 1/6] sched/fair: Do not skip CPUs of similar capacity with busy SMT siblings Vincent Guittot
2026-06-24 5:25 ` Ricardo Neri
2026-06-23 0:05 ` [PATCH v5 2/6] sched/fair: Also gate overloaded status update for SD_ASYM_CPUCAPACITY Ricardo Neri
2026-06-23 7:14 ` Vincent Guittot
2026-06-23 0:05 ` [PATCH v5 3/6] sched/fair: Check CPU capacity before comparing group types during load balance Ricardo Neri
2026-06-23 0:05 ` [PATCH v5 4/6] sched/fair: Skip misfit load accounting when the destination CPU cannot help Ricardo Neri
2026-06-23 0:05 ` [PATCH v5 5/6] sched/fair: Allow load balancing between CPUs of identical capacity Ricardo Neri
2026-06-23 7:20 ` Vincent Guittot
2026-06-23 7:45 ` Christian Loehle
2026-06-24 5:25 ` Ricardo Neri
2026-06-26 0:11 ` Ricardo Neri
2026-06-26 14:50 ` Vincent Guittot
2026-06-27 2:02 ` Ricardo Neri
2026-06-29 15:35 ` Vincent Guittot
2026-06-29 15:54 ` Rafael J. Wysocki (Intel)
2026-06-29 15:58 ` Vincent Guittot
2026-06-29 16:32 ` Ricardo Neri
2026-06-30 7:00 ` Vincent Guittot
2026-06-26 15:20 ` Vincent Guittot
2026-06-27 19:07 ` Andrea Righi
2026-06-29 16:22 ` Ricardo Neri
2026-06-23 0:05 ` [PATCH v5 6/6] sched/topology: Do not clear SD_PREFER_SIBLING in domains with clusters Ricardo Neri
2026-06-23 7:26 ` Vincent Guittot
2026-06-24 5:14 ` Ricardo Neri
2026-06-26 0:19 ` Ricardo Neri
2026-06-26 14:54 ` Vincent Guittot
2026-06-29 13:10 ` [PATCH v5 0/6] sched: Fix cluster scheduling in the presence of asymmetric capacity Andrea Righi
2026-06-29 16:24 ` Ricardo Neri
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260622-rneri-fix-cas-clusters-v5-1-19968f2d1497@linux.intel.com \
--to=ricardo.neri-calderon@linux.intel.com \
--cc=arighi@nvidia.com \
--cc=baohua@kernel.org \
--cc=bsegall@google.com \
--cc=christian.loehle@arm.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=lenb@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=rafael@kernel.org \
--cc=ricardo.neri@intel.com \
--cc=rostedt@goodmis.org \
--cc=tim.c.chen@linux.intel.com \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
--cc=yu.c.chen@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®