* [PATCH 01/12] crypto: allwinner - Remove redundant dev_err()
2026-07-17 8:00 [PATCH 00/12] crypto: Remove redundant error messages on IRQ request failure Pan Chuang
@ 2026-07-17 8:00 ` Pan Chuang
2026-07-17 8:00 ` [PATCH 02/12] crypto: amlogic " Pan Chuang
` (10 subsequent siblings)
11 siblings, 0 replies; 14+ messages in thread
From: Pan Chuang @ 2026-07-17 8:00 UTC (permalink / raw)
To: Corentin Labbe, Herbert Xu, David S. Miller, Chen-Yu Tsai,
Jernej Skrabec, Samuel Holland, Ovidiu Panait, Arnd Bergmann,
Pan Chuang, Eric Biggers, open list:ALLWINNER CRYPTO DRIVERS,
moderated list:ARM/Allwinner sunXi SoC support,
open list:ARM/Allwinner sunXi SoC support, open list
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c | 4 +---
drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
index c6402e87f8a0..21762bd408e5 100644
--- a/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
+++ b/drivers/crypto/allwinner/sun8i-ce/sun8i-ce-core.c
@@ -976,10 +976,8 @@ static int sun8i_ce_probe(struct platform_device *pdev)
err = devm_request_irq(&pdev->dev, irq, ce_irq_handler, 0,
"sun8i-ce-ns", ce);
- if (err) {
- dev_err(ce->dev, "Cannot request CryptoEngine Non-secure IRQ (err=%d)\n", err);
+ if (err)
goto error_pm;
- }
err = sun8i_ce_register_algs(ce);
if (err)
diff --git a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
index 0b22fcddb882..2167dd9f44c7 100644
--- a/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
+++ b/drivers/crypto/allwinner/sun8i-ss/sun8i-ss-core.c
@@ -824,10 +824,8 @@ static int sun8i_ss_probe(struct platform_device *pdev)
goto error_pm;
err = devm_request_irq(&pdev->dev, irq, ss_irq_handler, 0, "sun8i-ss", ss);
- if (err) {
- dev_err(ss->dev, "Cannot request SecuritySystem IRQ (err=%d)\n", err);
+ if (err)
goto error_irq;
- }
err = sun8i_ss_register_algs(ss);
if (err)
--
2.34.1
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH 02/12] crypto: amlogic - Remove redundant dev_err()
2026-07-17 8:00 [PATCH 00/12] crypto: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-17 8:00 ` [PATCH 01/12] crypto: allwinner - Remove redundant dev_err() Pan Chuang
@ 2026-07-17 8:00 ` Pan Chuang
2026-07-17 8:00 ` [PATCH 03/12] crypto: aspeed " Pan Chuang
` (9 subsequent siblings)
11 siblings, 0 replies; 14+ messages in thread
From: Pan Chuang @ 2026-07-17 8:00 UTC (permalink / raw)
To: Corentin Labbe, Herbert Xu, David S. Miller,
open list:ARM/Amlogic Meson SoC Crypto Drivers,
open list:ARM/Amlogic Meson SoC Crypto Drivers, open list
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/crypto/amlogic/amlogic-gxl-core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/crypto/amlogic/amlogic-gxl-core.c b/drivers/crypto/amlogic/amlogic-gxl-core.c
index 6cb33949915f..169c6eeb51e5 100644
--- a/drivers/crypto/amlogic/amlogic-gxl-core.c
+++ b/drivers/crypto/amlogic/amlogic-gxl-core.c
@@ -257,10 +257,8 @@ static int meson_crypto_probe(struct platform_device *pdev)
err = devm_request_irq(&pdev->dev, mc->irqs[i], meson_irq_handler, 0,
"gxl-crypto", mc);
- if (err < 0) {
- dev_err(mc->dev, "Cannot request IRQ for flow %d\n", i);
+ if (err < 0)
return err;
- }
}
err = clk_prepare_enable(mc->busclk);
--
2.34.1
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH 03/12] crypto: aspeed - Remove redundant dev_err()
2026-07-17 8:00 [PATCH 00/12] crypto: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-17 8:00 ` [PATCH 01/12] crypto: allwinner - Remove redundant dev_err() Pan Chuang
2026-07-17 8:00 ` [PATCH 02/12] crypto: amlogic " Pan Chuang
@ 2026-07-17 8:00 ` Pan Chuang
2026-07-17 8:00 ` [PATCH 04/12] crypto: Remove redundant dev_err()/dev_err_probe() Pan Chuang
` (8 subsequent siblings)
11 siblings, 0 replies; 14+ messages in thread
From: Pan Chuang @ 2026-07-17 8:00 UTC (permalink / raw)
To: Neal Liu, Herbert Xu, David S. Miller, Joel Stanley,
Andrew Jeffery, moderated list:ASPEED CRYPTO DRIVER,
open list:CRYPTO API, moderated list:ARM/ASPEED MACHINE SUPPORT,
open list
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/crypto/aspeed/aspeed-acry.c | 4 +---
drivers/crypto/aspeed/aspeed-hace.c | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/crypto/aspeed/aspeed-acry.c b/drivers/crypto/aspeed/aspeed-acry.c
index 5993bcba9716..8d13f01e7a37 100644
--- a/drivers/crypto/aspeed/aspeed-acry.c
+++ b/drivers/crypto/aspeed/aspeed-acry.c
@@ -732,10 +732,8 @@ static int aspeed_acry_probe(struct platform_device *pdev)
rc = devm_request_irq(dev, acry_dev->irq, aspeed_acry_irq, 0,
dev_name(dev), acry_dev);
- if (rc) {
- dev_err(dev, "Failed to request irq.\n");
+ if (rc)
return rc;
- }
acry_dev->clk = devm_clk_get_enabled(dev, NULL);
if (IS_ERR(acry_dev->clk)) {
diff --git a/drivers/crypto/aspeed/aspeed-hace.c b/drivers/crypto/aspeed/aspeed-hace.c
index 3fe644bfe037..6677cba666d7 100644
--- a/drivers/crypto/aspeed/aspeed-hace.c
+++ b/drivers/crypto/aspeed/aspeed-hace.c
@@ -131,10 +131,8 @@ static int aspeed_hace_probe(struct platform_device *pdev)
rc = devm_request_irq(&pdev->dev, hace_dev->irq, aspeed_hace_irq, 0,
dev_name(&pdev->dev), hace_dev);
- if (rc) {
- dev_err(&pdev->dev, "Failed to request interrupt\n");
+ if (rc)
return rc;
- }
/* Get clk and enable it */
hace_dev->clk = devm_clk_get(&pdev->dev, NULL);
--
2.34.1
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH 04/12] crypto: Remove redundant dev_err()/dev_err_probe()
2026-07-17 8:00 [PATCH 00/12] crypto: Remove redundant error messages on IRQ request failure Pan Chuang
` (2 preceding siblings ...)
2026-07-17 8:00 ` [PATCH 03/12] crypto: aspeed " Pan Chuang
@ 2026-07-17 8:00 ` Pan Chuang
2026-07-17 8:00 ` [PATCH 05/12] crypto: caam - Remove redundant dev_err() Pan Chuang
` (7 subsequent siblings)
11 siblings, 0 replies; 14+ messages in thread
From: Pan Chuang @ 2026-07-17 8:00 UTC (permalink / raw)
To: Herbert Xu, David S. Miller, Nicolas Ferre, Alexandre Belloni,
Claudiu Beznea, Frank Li, Sascha Hauer, Pengutronix Kernel Team,
Fabio Estevam, open list:CRYPTO API,
moderated list:ARM/Microchip (AT91) SoC support, open list,
open list:ARM/FREESCALE IMX / MXC ARM ARCHITECTURE
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() and dev_err_probe() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/crypto/atmel-aes.c | 4 +---
drivers/crypto/atmel-sha.c | 4 +---
drivers/crypto/atmel-tdes.c | 4 +---
drivers/crypto/img-hash.c | 4 +---
drivers/crypto/mxs-dcp.c | 8 ++------
drivers/crypto/omap-aes.c | 4 +---
drivers/crypto/omap-des.c | 4 +---
drivers/crypto/omap-sham.c | 5 +----
drivers/crypto/sahara.c | 3 +--
9 files changed, 10 insertions(+), 30 deletions(-)
diff --git a/drivers/crypto/atmel-aes.c b/drivers/crypto/atmel-aes.c
index 30acfd937d54..50d97cef75b8 100644
--- a/drivers/crypto/atmel-aes.c
+++ b/drivers/crypto/atmel-aes.c
@@ -2364,10 +2364,8 @@ static int atmel_aes_probe(struct platform_device *pdev)
err = devm_request_irq(&pdev->dev, aes_dd->irq, atmel_aes_irq,
IRQF_SHARED, "atmel-aes", aes_dd);
- if (err) {
- dev_err(dev, "unable to request aes irq.\n");
+ if (err)
goto err_tasklet_kill;
- }
/* Initializing the clock */
aes_dd->iclk = devm_clk_get_prepared(&pdev->dev, "aes_clk");
diff --git a/drivers/crypto/atmel-sha.c b/drivers/crypto/atmel-sha.c
index 66323ac63406..48f54b615504 100644
--- a/drivers/crypto/atmel-sha.c
+++ b/drivers/crypto/atmel-sha.c
@@ -2604,10 +2604,8 @@ static int atmel_sha_probe(struct platform_device *pdev)
err = devm_request_irq(&pdev->dev, sha_dd->irq, atmel_sha_irq,
IRQF_SHARED, "atmel-sha", sha_dd);
- if (err) {
- dev_err(dev, "unable to request sha irq.\n");
+ if (err)
goto err_tasklet_kill;
- }
/* Initializing the clock */
sha_dd->iclk = devm_clk_get_prepared(&pdev->dev, "sha_clk");
diff --git a/drivers/crypto/atmel-tdes.c b/drivers/crypto/atmel-tdes.c
index 48cd537f001e..4511166fd74d 100644
--- a/drivers/crypto/atmel-tdes.c
+++ b/drivers/crypto/atmel-tdes.c
@@ -978,10 +978,8 @@ static int atmel_tdes_probe(struct platform_device *pdev)
err = devm_request_irq(&pdev->dev, tdes_dd->irq, atmel_tdes_irq,
IRQF_SHARED, "atmel-tdes", tdes_dd);
- if (err) {
- dev_err(dev, "unable to request tdes irq.\n");
+ if (err)
goto err_tasklet_kill;
- }
/* Initializing the clock */
tdes_dd->iclk = devm_clk_get(&pdev->dev, "tdes_clk");
diff --git a/drivers/crypto/img-hash.c b/drivers/crypto/img-hash.c
index 0f19dcc2f388..1ccfc0eccc73 100644
--- a/drivers/crypto/img-hash.c
+++ b/drivers/crypto/img-hash.c
@@ -966,10 +966,8 @@ static int img_hash_probe(struct platform_device *pdev)
err = devm_request_irq(dev, irq, img_irq_handler, 0,
dev_name(dev), hdev);
- if (err) {
- dev_err(dev, "unable to request irq\n");
+ if (err)
goto res_err;
- }
dev_dbg(dev, "using IRQ channel %d\n", irq);
hdev->hash_clk = devm_clk_get_enabled(&pdev->dev, "hash");
diff --git a/drivers/crypto/mxs-dcp.c b/drivers/crypto/mxs-dcp.c
index 595b2fd84667..c75a06999787 100644
--- a/drivers/crypto/mxs-dcp.c
+++ b/drivers/crypto/mxs-dcp.c
@@ -1085,17 +1085,13 @@ static int mxs_dcp_probe(struct platform_device *pdev)
ret = devm_request_irq(dev, dcp_vmi_irq, mxs_dcp_irq, 0,
"dcp-vmi-irq", sdcp);
- if (ret) {
- dev_err(dev, "Failed to claim DCP VMI IRQ!\n");
+ if (ret)
return ret;
- }
ret = devm_request_irq(dev, dcp_irq, mxs_dcp_irq, 0,
"dcp-irq", sdcp);
- if (ret) {
- dev_err(dev, "Failed to claim DCP IRQ!\n");
+ if (ret)
return ret;
- }
/* Allocate coherent helper block. */
sdcp->coh = devm_kzalloc(dev, sizeof(*sdcp->coh) + DCP_ALIGNMENT,
diff --git a/drivers/crypto/omap-aes.c b/drivers/crypto/omap-aes.c
index f31555c0d715..711909de2013 100644
--- a/drivers/crypto/omap-aes.c
+++ b/drivers/crypto/omap-aes.c
@@ -1172,10 +1172,8 @@ static int omap_aes_probe(struct platform_device *pdev)
err = devm_request_irq(dev, irq, omap_aes_irq, 0,
dev_name(dev), dd);
- if (err) {
- dev_err(dev, "Unable to grab omap-aes IRQ\n");
+ if (err)
goto err_irq;
- }
}
spin_lock_init(&dd->lock);
diff --git a/drivers/crypto/omap-des.c b/drivers/crypto/omap-des.c
index dfaf831dd8ec..3b7104cb4487 100644
--- a/drivers/crypto/omap-des.c
+++ b/drivers/crypto/omap-des.c
@@ -1017,10 +1017,8 @@ static int omap_des_probe(struct platform_device *pdev)
err = devm_request_irq(dev, irq, omap_des_irq, 0,
dev_name(dev), dd);
- if (err) {
- dev_err(dev, "Unable to grab omap-des IRQ\n");
+ if (err)
goto err_irq;
- }
}
diff --git a/drivers/crypto/omap-sham.c b/drivers/crypto/omap-sham.c
index be1ac640ee59..8f95c381f4c8 100644
--- a/drivers/crypto/omap-sham.c
+++ b/drivers/crypto/omap-sham.c
@@ -2092,11 +2092,8 @@ static int omap_sham_probe(struct platform_device *pdev)
err = devm_request_irq(dev, dd->irq, dd->pdata->intr_hdlr,
IRQF_TRIGGER_NONE, dev_name(dev), dd);
- if (err) {
- dev_err(dev, "unable to request irq %d, err = %d\n",
- dd->irq, err);
+ if (err)
goto data_err;
- }
dma_cap_zero(mask);
dma_cap_set(DMA_SLAVE, mask);
diff --git a/drivers/crypto/sahara.c b/drivers/crypto/sahara.c
index 533080b0cddc..d586f1315de1 100644
--- a/drivers/crypto/sahara.c
+++ b/drivers/crypto/sahara.c
@@ -1305,8 +1305,7 @@ static int sahara_probe(struct platform_device *pdev)
err = devm_request_irq(&pdev->dev, irq, sahara_irq_handler,
0, dev_name(&pdev->dev), dev);
if (err)
- return dev_err_probe(&pdev->dev, err,
- "failed to request irq\n");
+ return err;
/* clocks */
dev->clk_ipg = devm_clk_get_enabled(&pdev->dev, "ipg");
--
2.34.1
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH 05/12] crypto: caam - Remove redundant dev_err()
2026-07-17 8:00 [PATCH 00/12] crypto: Remove redundant error messages on IRQ request failure Pan Chuang
` (3 preceding siblings ...)
2026-07-17 8:00 ` [PATCH 04/12] crypto: Remove redundant dev_err()/dev_err_probe() Pan Chuang
@ 2026-07-17 8:00 ` Pan Chuang
2026-07-17 8:00 ` [PATCH 06/12] crypto: ccree " Pan Chuang
` (6 subsequent siblings)
11 siblings, 0 replies; 14+ messages in thread
From: Pan Chuang @ 2026-07-17 8:00 UTC (permalink / raw)
To: Horia Geantă,
Pankaj Gupta, Gaurav Jain, Herbert Xu, David S. Miller,
open list
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/crypto/caam/jr.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c
index bddeaaaca487..e4fab3a3112e 100644
--- a/drivers/crypto/caam/jr.c
+++ b/drivers/crypto/caam/jr.c
@@ -566,8 +566,6 @@ static int caam_jr_init(struct device *dev)
error = devm_request_irq(dev, jrp->irq, caam_jr_interrupt, IRQF_SHARED,
dev_name(dev), dev);
if (error) {
- dev_err(dev, "can't connect JobR %d interrupt (%d)\n",
- jrp->ridx, jrp->irq);
tasklet_kill(&jrp->irqtask);
}
--
2.34.1
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH 06/12] crypto: ccree - Remove redundant dev_err()
2026-07-17 8:00 [PATCH 00/12] crypto: Remove redundant error messages on IRQ request failure Pan Chuang
` (4 preceding siblings ...)
2026-07-17 8:00 ` [PATCH 05/12] crypto: caam - Remove redundant dev_err() Pan Chuang
@ 2026-07-17 8:00 ` Pan Chuang
2026-07-17 8:00 ` [PATCH 07/12] crypto: sl3516 " Pan Chuang
` (5 subsequent siblings)
11 siblings, 0 replies; 14+ messages in thread
From: Pan Chuang @ 2026-07-17 8:00 UTC (permalink / raw)
To: Gilad Ben-Yossef, Herbert Xu, David S. Miller,
open list:CCREE ARM TRUSTZONE CRYPTOCELL REE DRIVER, open list
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/crypto/ccree/cc_driver.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/crypto/ccree/cc_driver.c b/drivers/crypto/ccree/cc_driver.c
index 061e68a31c36..28a23cd572d6 100644
--- a/drivers/crypto/ccree/cc_driver.c
+++ b/drivers/crypto/ccree/cc_driver.c
@@ -471,10 +471,8 @@ static int init_cc_resources(struct platform_device *plat_dev)
/* register the driver isr function */
rc = devm_request_irq(dev, irq, cc_isr, IRQF_SHARED, "ccree",
new_drvdata);
- if (rc) {
- dev_err(dev, "Could not register to interrupt %d\n", irq);
+ if (rc)
goto post_pm_err;
- }
dev_dbg(dev, "Registered to IRQ: %d\n", irq);
init_cc_cache_params(new_drvdata);
--
2.34.1
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH 07/12] crypto: sl3516 - Remove redundant dev_err()
2026-07-17 8:00 [PATCH 00/12] crypto: Remove redundant error messages on IRQ request failure Pan Chuang
` (5 preceding siblings ...)
2026-07-17 8:00 ` [PATCH 06/12] crypto: ccree " Pan Chuang
@ 2026-07-17 8:00 ` Pan Chuang
2026-07-17 8:00 ` [PATCH 08/12] crypto: safexcel " Pan Chuang
` (4 subsequent siblings)
11 siblings, 0 replies; 14+ messages in thread
From: Pan Chuang @ 2026-07-17 8:00 UTC (permalink / raw)
To: Hans Ulli Kroll, Linus Walleij, Corentin Labbe, Herbert Xu,
David S. Miller,
moderated list:ARM/CORTINA SYSTEMS GEMINI ARM ARCHITECTURE,
open list:GEMINI CRYPTO DRIVER, open list
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/crypto/gemini/sl3516-ce-core.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/crypto/gemini/sl3516-ce-core.c b/drivers/crypto/gemini/sl3516-ce-core.c
index f7e0e3fea15c..c1df5f96ea42 100644
--- a/drivers/crypto/gemini/sl3516-ce-core.c
+++ b/drivers/crypto/gemini/sl3516-ce-core.c
@@ -414,10 +414,8 @@ static int sl3516_ce_probe(struct platform_device *pdev)
return irq;
err = devm_request_irq(&pdev->dev, irq, ce_irq_handler, 0, "crypto", ce);
- if (err) {
- dev_err(ce->dev, "Cannot request Crypto Engine IRQ (err=%d)\n", err);
+ if (err)
return err;
- }
ce->reset = devm_reset_control_get(&pdev->dev, NULL);
if (IS_ERR(ce->reset))
--
2.34.1
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH 08/12] crypto: safexcel - Remove redundant dev_err()
2026-07-17 8:00 [PATCH 00/12] crypto: Remove redundant error messages on IRQ request failure Pan Chuang
` (6 preceding siblings ...)
2026-07-17 8:00 ` [PATCH 07/12] crypto: sl3516 " Pan Chuang
@ 2026-07-17 8:00 ` Pan Chuang
2026-07-17 8:00 ` [PATCH 09/12] crypto: keembay " Pan Chuang
` (3 subsequent siblings)
11 siblings, 0 replies; 14+ messages in thread
From: Pan Chuang @ 2026-07-17 8:00 UTC (permalink / raw)
To: Antoine Tenart, Herbert Xu, David S. Miller,
open list:INSIDE SECURE CRYPTO DRIVER, open list
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/crypto/inside-secure/safexcel.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/crypto/inside-secure/safexcel.c b/drivers/crypto/inside-secure/safexcel.c
index 52809e57361a..71b920e17e98 100644
--- a/drivers/crypto/inside-secure/safexcel.c
+++ b/drivers/crypto/inside-secure/safexcel.c
@@ -1172,10 +1172,8 @@ static int safexcel_request_ring_irq(void *pdev, int irqid,
ret = devm_request_threaded_irq(dev, irq, handler,
threaded_handler, IRQF_ONESHOT,
dev_name(dev), ring_irq_priv);
- if (ret) {
- dev_err(dev, "unable to request IRQ %d\n", irq);
+ if (ret)
return ret;
- }
/* Set affinity */
cpu = cpumask_local_spread(ring_id, NUMA_NO_NODE);
--
2.34.1
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH 09/12] crypto: keembay - Remove redundant dev_err()
2026-07-17 8:00 [PATCH 00/12] crypto: Remove redundant error messages on IRQ request failure Pan Chuang
` (7 preceding siblings ...)
2026-07-17 8:00 ` [PATCH 08/12] crypto: safexcel " Pan Chuang
@ 2026-07-17 8:00 ` Pan Chuang
2026-07-17 8:00 ` [PATCH 10/12] crypto: octeontx2 " Pan Chuang
` (2 subsequent siblings)
11 siblings, 0 replies; 14+ messages in thread
From: Pan Chuang @ 2026-07-17 8:00 UTC (permalink / raw)
To: Herbert Xu, David S. Miller, Prabhjot Khurana, Declan Murphy,
Ijae Kim, Pan Chuang, Myeonghun Pak, open list:CRYPTO API,
open list
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/crypto/intel/keembay/keembay-ocs-aes-core.c | 4 +---
drivers/crypto/intel/keembay/keembay-ocs-ecc.c | 4 +---
drivers/crypto/intel/keembay/keembay-ocs-hcu-core.c | 4 +---
3 files changed, 3 insertions(+), 9 deletions(-)
diff --git a/drivers/crypto/intel/keembay/keembay-ocs-aes-core.c b/drivers/crypto/intel/keembay/keembay-ocs-aes-core.c
index 0e424024224e..6de6dbdcdbd0 100644
--- a/drivers/crypto/intel/keembay/keembay-ocs-aes-core.c
+++ b/drivers/crypto/intel/keembay/keembay-ocs-aes-core.c
@@ -1609,10 +1609,8 @@ static int kmb_ocs_aes_probe(struct platform_device *pdev)
rc = devm_request_threaded_irq(dev, aes_dev->irq, ocs_aes_irq_handler,
NULL, 0, "keembay-ocs-aes", aes_dev);
- if (rc < 0) {
- dev_err(dev, "Could not request IRQ\n");
+ if (rc < 0)
return rc;
- }
INIT_LIST_HEAD(&aes_dev->list);
spin_lock(&ocs_aes.lock);
diff --git a/drivers/crypto/intel/keembay/keembay-ocs-ecc.c b/drivers/crypto/intel/keembay/keembay-ocs-ecc.c
index 9e555b02086c..9bdee39dc4e1 100644
--- a/drivers/crypto/intel/keembay/keembay-ocs-ecc.c
+++ b/drivers/crypto/intel/keembay/keembay-ocs-ecc.c
@@ -900,10 +900,8 @@ static int kmb_ocs_ecc_probe(struct platform_device *pdev)
rc = devm_request_threaded_irq(dev, ecc_dev->irq, ocs_ecc_irq_handler,
NULL, 0, "keembay-ocs-ecc", ecc_dev);
- if (rc < 0) {
- dev_err(dev, "Could not request IRQ\n");
+ if (rc < 0)
goto list_del;
- }
/* Add device to the list of OCS ECC devices. */
spin_lock(&ocs_ecc.lock);
diff --git a/drivers/crypto/intel/keembay/keembay-ocs-hcu-core.c b/drivers/crypto/intel/keembay/keembay-ocs-hcu-core.c
index 87b67060c77b..9a67bb4ecc82 100644
--- a/drivers/crypto/intel/keembay/keembay-ocs-hcu-core.c
+++ b/drivers/crypto/intel/keembay/keembay-ocs-hcu-core.c
@@ -1204,10 +1204,8 @@ static int kmb_ocs_hcu_probe(struct platform_device *pdev)
rc = devm_request_threaded_irq(&pdev->dev, hcu_dev->irq,
ocs_hcu_irq_handler, NULL, 0,
"keembay-ocs-hcu", hcu_dev);
- if (rc < 0) {
- dev_err(dev, "Could not request IRQ.\n");
+ if (rc < 0)
return rc;
- }
INIT_LIST_HEAD(&hcu_dev->list);
--
2.34.1
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH 10/12] crypto: octeontx2 - Remove redundant dev_err()
2026-07-17 8:00 [PATCH 00/12] crypto: Remove redundant error messages on IRQ request failure Pan Chuang
` (8 preceding siblings ...)
2026-07-17 8:00 ` [PATCH 09/12] crypto: keembay " Pan Chuang
@ 2026-07-17 8:00 ` Pan Chuang
2026-07-17 8:00 ` [PATCH 11/12] crypto: rockchip " Pan Chuang
2026-07-17 8:00 ` [PATCH 12/12] crypto: stm32 " Pan Chuang
11 siblings, 0 replies; 14+ messages in thread
From: Pan Chuang @ 2026-07-17 8:00 UTC (permalink / raw)
To: Srujana Challa, Bharat Bhushan, Herbert Xu, David S. Miller,
Kees Cook, Thorsten Blum, Krzysztof Kozlowski, Pan Chuang,
open list:MARVELL CRYPTO DRIVER, open list
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/crypto/marvell/octeontx2/otx2_cptpf_main.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/crypto/marvell/octeontx2/otx2_cptpf_main.c b/drivers/crypto/marvell/octeontx2/otx2_cptpf_main.c
index f6f47f4e5d83..79f6c2bb9d8b 100644
--- a/drivers/crypto/marvell/octeontx2/otx2_cptpf_main.c
+++ b/drivers/crypto/marvell/octeontx2/otx2_cptpf_main.c
@@ -430,11 +430,8 @@ static int cptpf_register_afpf_mbox_intr(struct otx2_cptpf_dev *cptpf)
/* Register AF-PF mailbox interrupt handler */
ret = devm_request_irq(dev, irq, otx2_cptpf_afpf_mbox_intr, 0,
"CPTAFPF Mbox", cptpf);
- if (ret) {
- dev_err(dev,
- "IRQ registration failed for PFAF mbox irq\n");
+ if (ret)
return ret;
- }
/* Clear interrupt if any, to avoid spurious interrupts */
otx2_cpt_write64(cptpf->reg_base, BLKADDR_RVUM, 0, RVU_PF_INT, 0x1ULL);
/* Enable AF-PF interrupt */
--
2.34.1
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH 11/12] crypto: rockchip - Remove redundant dev_err()
2026-07-17 8:00 [PATCH 00/12] crypto: Remove redundant error messages on IRQ request failure Pan Chuang
` (9 preceding siblings ...)
2026-07-17 8:00 ` [PATCH 10/12] crypto: octeontx2 " Pan Chuang
@ 2026-07-17 8:00 ` Pan Chuang
2026-07-17 8:00 ` [PATCH 12/12] crypto: stm32 " Pan Chuang
11 siblings, 0 replies; 14+ messages in thread
From: Pan Chuang @ 2026-07-17 8:00 UTC (permalink / raw)
To: Corentin Labbe, Herbert Xu, David S. Miller, Heiko Stuebner,
open list:ROCKCHIP CRYPTO DRIVERS,
moderated list:ARM/Rockchip SoC support,
open list:ARM/Rockchip SoC support, open list
Cc: Pan Chuang
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/crypto/rockchip/rk3288_crypto.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/crypto/rockchip/rk3288_crypto.c b/drivers/crypto/rockchip/rk3288_crypto.c
index b77bdce8e7fc..7cb1316b6f18 100644
--- a/drivers/crypto/rockchip/rk3288_crypto.c
+++ b/drivers/crypto/rockchip/rk3288_crypto.c
@@ -365,10 +365,8 @@ static int rk_crypto_probe(struct platform_device *pdev)
rk_crypto_irq_handle, IRQF_SHARED,
"rk-crypto", pdev);
- if (err) {
- dev_err(&pdev->dev, "irq request failed.\n");
+ if (err)
goto err_crypto;
- }
crypto_info->engine = crypto_engine_alloc_init(&pdev->dev, true);
if (!crypto_info->engine) {
--
2.34.1
^ permalink raw reply [flat|nested] 14+ messages in thread* [PATCH 12/12] crypto: stm32 - Remove redundant dev_err()
2026-07-17 8:00 [PATCH 00/12] crypto: Remove redundant error messages on IRQ request failure Pan Chuang
` (10 preceding siblings ...)
2026-07-17 8:00 ` [PATCH 11/12] crypto: rockchip " Pan Chuang
@ 2026-07-17 8:00 ` Pan Chuang
2026-07-17 8:59 ` Maxime MERE
11 siblings, 1 reply; 14+ messages in thread
From: Pan Chuang @ 2026-07-17 8:00 UTC (permalink / raw)
To: Herbert Xu, David S. Miller, Maxime Coquelin, Alexandre Torgue,
Kees Cook, Thorsten Blum, Sakari Ailus, Pan Chuang,
Colin Ian King, open list:CRYPTO API,
moderated list:ARM/STM32 ARCHITECTURE,
moderated list:ARM/STM32 ARCHITECTURE, open list
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/crypto/stm32/stm32-cryp.c | 4 +---
drivers/crypto/stm32/stm32-hash.c | 4 +---
2 files changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/crypto/stm32/stm32-cryp.c b/drivers/crypto/stm32/stm32-cryp.c
index b79877099942..3fc2db290b0f 100644
--- a/drivers/crypto/stm32/stm32-cryp.c
+++ b/drivers/crypto/stm32/stm32-cryp.c
@@ -2590,10 +2590,8 @@ static int stm32_cryp_probe(struct platform_device *pdev)
ret = devm_request_threaded_irq(dev, irq, stm32_cryp_irq,
stm32_cryp_irq_thread, IRQF_ONESHOT,
dev_name(dev), cryp);
- if (ret) {
- dev_err(dev, "Cannot grab IRQ\n");
+ if (ret)
return ret;
- }
cryp->clk = devm_clk_get(dev, NULL);
if (IS_ERR(cryp->clk)) {
diff --git a/drivers/crypto/stm32/stm32-hash.c b/drivers/crypto/stm32/stm32-hash.c
index dada5951082c..e6a1e9b9f88d 100644
--- a/drivers/crypto/stm32/stm32-hash.c
+++ b/drivers/crypto/stm32/stm32-hash.c
@@ -2356,10 +2356,8 @@ static int stm32_hash_probe(struct platform_device *pdev)
stm32_hash_irq_thread,
IRQF_ONESHOT,
dev_name(dev), hdev);
- if (ret) {
- dev_err(dev, "Cannot grab IRQ\n");
+ if (ret)
return ret;
- }
} else {
dev_info(dev, "No IRQ, use polling mode\n");
hdev->polled = true;
--
2.34.1
^ permalink raw reply [flat|nested] 14+ messages in thread* Re: [PATCH 12/12] crypto: stm32 - Remove redundant dev_err()
2026-07-17 8:00 ` [PATCH 12/12] crypto: stm32 " Pan Chuang
@ 2026-07-17 8:59 ` Maxime MERE
0 siblings, 0 replies; 14+ messages in thread
From: Maxime MERE @ 2026-07-17 8:59 UTC (permalink / raw)
To: Pan Chuang, Herbert Xu, David S. Miller, Maxime Coquelin,
Alexandre Torgue, Kees Cook, Thorsten Blum, Sakari Ailus,
Colin Ian King, open list:CRYPTO API,
moderated list:ARM/STM32 ARCHITECTURE,
moderated list:ARM/STM32 ARCHITECTURE, open list
Acked-by: Maxime Méré <maxime.mere@foss.st.com>
On 7/17/26 10:00, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> ---
> drivers/crypto/stm32/stm32-cryp.c | 4 +---
> drivers/crypto/stm32/stm32-hash.c | 4 +---
> 2 files changed, 2 insertions(+), 6 deletions(-)
>
> diff --git a/drivers/crypto/stm32/stm32-cryp.c b/drivers/crypto/stm32/stm32-cryp.c
> index b79877099942..3fc2db290b0f 100644
> --- a/drivers/crypto/stm32/stm32-cryp.c
> +++ b/drivers/crypto/stm32/stm32-cryp.c
> @@ -2590,10 +2590,8 @@ static int stm32_cryp_probe(struct platform_device *pdev)
> ret = devm_request_threaded_irq(dev, irq, stm32_cryp_irq,
> stm32_cryp_irq_thread, IRQF_ONESHOT,
> dev_name(dev), cryp);
> - if (ret) {
> - dev_err(dev, "Cannot grab IRQ\n");
> + if (ret)
> return ret;
> - }
>
> cryp->clk = devm_clk_get(dev, NULL);
> if (IS_ERR(cryp->clk)) {
> diff --git a/drivers/crypto/stm32/stm32-hash.c b/drivers/crypto/stm32/stm32-hash.c
> index dada5951082c..e6a1e9b9f88d 100644
> --- a/drivers/crypto/stm32/stm32-hash.c
> +++ b/drivers/crypto/stm32/stm32-hash.c
> @@ -2356,10 +2356,8 @@ static int stm32_hash_probe(struct platform_device *pdev)
> stm32_hash_irq_thread,
> IRQF_ONESHOT,
> dev_name(dev), hdev);
> - if (ret) {
> - dev_err(dev, "Cannot grab IRQ\n");
> + if (ret)
> return ret;
> - }
> } else {
> dev_info(dev, "No IRQ, use polling mode\n");
> hdev->polled = true;
^ permalink raw reply [flat|nested] 14+ messages in thread