From: Pan Chuang <panchuang@vivo.com>
To: "Hans de Goede" <hansg@kernel.org>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>,
"Bryan O'Donoghue" <bryan.odonoghue@linaro.org>,
"Pengyu Luo" <mitltlatltl@gmail.com>,
"Sebastian Reichel" <sre@kernel.org>,
platform-driver-x86@vger.kernel.org (open list:ARM64 PLATFORM
DRIVERS), linux-kernel@vger.kernel.org (open list)
Cc: Pan Chuang <panchuang@vivo.com>
Subject: [PATCH 1/7] platform: arm64: Remove redundant dev_err_probe()
Date: Fri, 17 Jul 2026 19:20:39 +0800 [thread overview]
Message-ID: <20260717112103.213017-2-panchuang@vivo.com> (raw)
In-Reply-To: <20260717112103.213017-1-panchuang@vivo.com>
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err_probe() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/platform/arm64/acer-aspire1-ec.c | 2 +-
drivers/platform/arm64/huawei-gaokun-ec.c | 2 +-
drivers/platform/arm64/lenovo-thinkpad-t14s.c | 2 +-
drivers/platform/arm64/lenovo-yoga-c630.c | 2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/platform/arm64/acer-aspire1-ec.c b/drivers/platform/arm64/acer-aspire1-ec.c
index 08d0b155a197..501c62a096f8 100644
--- a/drivers/platform/arm64/acer-aspire1-ec.c
+++ b/drivers/platform/arm64/acer-aspire1-ec.c
@@ -514,7 +514,7 @@ static int aspire_ec_probe(struct i2c_client *client)
aspire_ec_irq_handler, IRQF_ONESHOT,
dev_name(dev), ec);
if (ret)
- return dev_err_probe(dev, ret, "Failed to request irq\n");
+ return ret;
return 0;
}
diff --git a/drivers/platform/arm64/huawei-gaokun-ec.c b/drivers/platform/arm64/huawei-gaokun-ec.c
index 80a8ba8b8dda..d4ce8ad6426c 100644
--- a/drivers/platform/arm64/huawei-gaokun-ec.c
+++ b/drivers/platform/arm64/huawei-gaokun-ec.c
@@ -783,7 +783,7 @@ static int gaokun_ec_probe(struct i2c_client *client)
gaokun_ec_irq_handler, IRQF_ONESHOT,
dev_name(dev), ec);
if (ret)
- return dev_err_probe(dev, ret, "Failed to request IRQ\n");
+ return ret;
ec->hwmon_dev = devm_hwmon_device_register_with_info(dev, "gaokun_ec_hwmon",
ec, &gaokun_ec_hwmon_chip_info, NULL);
diff --git a/drivers/platform/arm64/lenovo-thinkpad-t14s.c b/drivers/platform/arm64/lenovo-thinkpad-t14s.c
index e7acb66b77f2..191ecd7f85b5 100644
--- a/drivers/platform/arm64/lenovo-thinkpad-t14s.c
+++ b/drivers/platform/arm64/lenovo-thinkpad-t14s.c
@@ -594,7 +594,7 @@ static int t14s_ec_probe(struct i2c_client *client)
t14s_ec_irq_handler,
IRQF_ONESHOT, dev_name(dev), ec);
if (ret < 0)
- return dev_err_probe(dev, ret, "Failed to get IRQ\n");
+ return ret;
/*
* Disable wakeup support by default, because the driver currently does
diff --git a/drivers/platform/arm64/lenovo-yoga-c630.c b/drivers/platform/arm64/lenovo-yoga-c630.c
index a8600a977fbc..cad40c58c55b 100644
--- a/drivers/platform/arm64/lenovo-yoga-c630.c
+++ b/drivers/platform/arm64/lenovo-yoga-c630.c
@@ -221,7 +221,7 @@ static int yoga_c630_ec_probe(struct i2c_client *client)
NULL, yoga_c630_ec_thread_intr,
IRQF_ONESHOT, "yoga_c630_ec", ec);
if (ret < 0)
- return dev_err_probe(dev, ret, "unable to request irq\n");
+ return ret;
ret = yoga_c630_aux_init(dev, YOGA_C630_DEV_PSY, ec);
if (ret)
--
2.34.1
next prev parent reply other threads:[~2026-07-17 11:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 11:20 [PATCH 0/7] platform: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-17 11:20 ` Pan Chuang [this message]
2026-07-17 23:59 ` [PATCH 1/7] platform: arm64: Remove redundant dev_err_probe() Sebastian Reichel
2026-07-17 11:20 ` [PATCH 2/7] platform/chrome: Remove redundant dev_err() Pan Chuang
2026-07-17 11:20 ` [PATCH 3/7] platform: cznic: turris-omnia-mcu: Remove redundant dev_err_probe() Pan Chuang
2026-07-17 11:20 ` [PATCH 4/7] platform: goldfish: pipe: Remove redundant dev_err() Pan Chuang
2026-07-17 11:20 ` [PATCH 5/7] platform/mellanox: " Pan Chuang
2026-07-17 11:20 ` [PATCH 6/7] platform/raspberrypi: " Pan Chuang
2026-07-17 17:58 ` Stefan Wahren
2026-07-17 11:20 ` [PATCH 7/7] platform/x86: Remove redundant dev_err()/dev_err_probe() Pan Chuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260717112103.213017-2-panchuang@vivo.com \
--to=panchuang@vivo.com \
--cc=bryan.odonoghue@linaro.org \
--cc=hansg@kernel.org \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mitltlatltl@gmail.com \
--cc=platform-driver-x86@vger.kernel.org \
--cc=sre@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox