Re: [PATCH 6/7] platform/raspberrypi: Remove redundant dev_err()

[Stefan Wahren <wahrenst@gmx.net>]

Am 17.07.26 um 13:20 schrieb Pan Chuang:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err() calls.
>
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
Reviewed-by: Stefan Wahren <wahrenst@gmx.net>
> ---
>   drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
>
> diff --git a/drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c b/drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c
> index e78641703252..9490ad88df0f 100644
> --- a/drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c
> +++ b/drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c
> @@ -257,10 +257,8 @@ static int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state
>   
>   	err = devm_request_irq(dev, irq, vchiq_doorbell_irq, IRQF_IRQPOLL,
>   			       "VCHIQ doorbell", state);
> -	if (err) {
> -		dev_err(dev, "failed to register irq=%d\n", irq);
> +	if (err)
>   		return err;
> -	}
>   
>   	/* Send the base address of the slots to VideoCore */
>   	channelbase = slot_phys;