From: Pan Chuang <panchuang@vivo.com>
To: Benson Leung <bleung@chromium.org>,
Tzung-Bi Shih <tzungbi@kernel.org>,
Guenter Roeck <groeck@chromium.org>,
chrome-platform@lists.linux.dev (open list:CHROME HARDWARE
PLATFORM SUPPORT), linux-kernel@vger.kernel.org (open list)
Cc: Pan Chuang <panchuang@vivo.com>
Subject: [PATCH 2/7] platform/chrome: Remove redundant dev_err()
Date: Fri, 17 Jul 2026 19:20:40 +0800 [thread overview]
Message-ID: <20260717112103.213017-3-panchuang@vivo.com> (raw)
In-Reply-To: <20260717112103.213017-1-panchuang@vivo.com>
Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.
Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
drivers/platform/chrome/cros_ec.c | 5 +----
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/platform/chrome/cros_ec.c b/drivers/platform/chrome/cros_ec.c
index 1da79e3d215b..5d0f5a9187b1 100644
--- a/drivers/platform/chrome/cros_ec.c
+++ b/drivers/platform/chrome/cros_ec.c
@@ -249,11 +249,8 @@ int cros_ec_register(struct cros_ec_device *ec_dev)
cros_ec_irq_thread,
IRQF_TRIGGER_LOW | IRQF_ONESHOT,
"chromeos-ec", ec_dev);
- if (err) {
- dev_err(dev, "Failed to request IRQ %d: %d\n",
- ec_dev->irq, err);
+ if (err)
goto exit;
- }
}
/* Register a platform device for the main EC instance */
--
2.34.1
next prev parent reply other threads:[~2026-07-17 11:22 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-17 11:20 [PATCH 0/7] platform: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-17 11:20 ` [PATCH 1/7] platform: arm64: Remove redundant dev_err_probe() Pan Chuang
2026-07-17 23:59 ` Sebastian Reichel
2026-07-17 11:20 ` Pan Chuang [this message]
2026-07-17 11:20 ` [PATCH 3/7] platform: cznic: turris-omnia-mcu: " Pan Chuang
2026-07-17 11:20 ` [PATCH 4/7] platform: goldfish: pipe: Remove redundant dev_err() Pan Chuang
2026-07-17 11:20 ` [PATCH 5/7] platform/mellanox: " Pan Chuang
2026-07-17 11:20 ` [PATCH 6/7] platform/raspberrypi: " Pan Chuang
2026-07-17 17:58 ` Stefan Wahren
2026-07-17 11:20 ` [PATCH 7/7] platform/x86: Remove redundant dev_err()/dev_err_probe() Pan Chuang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260717112103.213017-3-panchuang@vivo.com \
--to=panchuang@vivo.com \
--cc=bleung@chromium.org \
--cc=chrome-platform@lists.linux.dev \
--cc=groeck@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tzungbi@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox