mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Pan Chuang <panchuang@vivo.com>
To: Florian Fainelli <florian.fainelli@broadcom.com>,
	Broadcom internal kernel review list
	<bcm-kernel-feedback-list@broadcom.com>,
	Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
	Jai Luthra <jai.luthra@ideasonboard.com>,
	Stefan Wahren <wahrenst@gmx.net>,
	Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
	Pan Chuang <panchuang@vivo.com>,
	Phil Elwell <phil@raspberrypi.com>, Kees Cook <kees@kernel.org>,
	linux-rpi-kernel@lists.infradead.org (moderated list:BROADCOM
	BCM2711/BCM2835 ARM ARCHITECTURE),
	linux-arm-kernel@lists.infradead.org (moderated list:BROADCOM
	BCM2711/BCM2835 ARM ARCHITECTURE),
	linux-kernel@vger.kernel.org (open list)
Subject: [PATCH 6/7] platform/raspberrypi: Remove redundant dev_err()
Date: Fri, 17 Jul 2026 19:20:44 +0800	[thread overview]
Message-ID: <20260717112103.213017-7-panchuang@vivo.com> (raw)
In-Reply-To: <20260717112103.213017-1-panchuang@vivo.com>

Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
devm_request_*_irq()"), devm_request_irq() automatically logs
detailed error messages on failure. Remove the now-redundant
driver-specific dev_err() calls.

Signed-off-by: Pan Chuang <panchuang@vivo.com>
---
 drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c b/drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c
index e78641703252..9490ad88df0f 100644
--- a/drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c
+++ b/drivers/platform/raspberrypi/vchiq-interface/vchiq_arm.c
@@ -257,10 +257,8 @@ static int vchiq_platform_init(struct platform_device *pdev, struct vchiq_state
 
 	err = devm_request_irq(dev, irq, vchiq_doorbell_irq, IRQF_IRQPOLL,
 			       "VCHIQ doorbell", state);
-	if (err) {
-		dev_err(dev, "failed to register irq=%d\n", irq);
+	if (err)
 		return err;
-	}
 
 	/* Send the base address of the slots to VideoCore */
 	channelbase = slot_phys;
-- 
2.34.1


  parent reply	other threads:[~2026-07-17 11:22 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-17 11:20 [PATCH 0/7] platform: Remove redundant error messages on IRQ request failure Pan Chuang
2026-07-17 11:20 ` [PATCH 1/7] platform: arm64: Remove redundant dev_err_probe() Pan Chuang
2026-07-17 23:59   ` Sebastian Reichel
2026-07-17 11:20 ` [PATCH 2/7] platform/chrome: Remove redundant dev_err() Pan Chuang
2026-07-17 11:20 ` [PATCH 3/7] platform: cznic: turris-omnia-mcu: Remove redundant dev_err_probe() Pan Chuang
2026-07-17 11:20 ` [PATCH 4/7] platform: goldfish: pipe: Remove redundant dev_err() Pan Chuang
2026-07-17 11:20 ` [PATCH 5/7] platform/mellanox: " Pan Chuang
2026-07-17 11:20 ` Pan Chuang [this message]
2026-07-17 17:58   ` [PATCH 6/7] platform/raspberrypi: " Stefan Wahren
2026-07-17 11:20 ` [PATCH 7/7] platform/x86: Remove redundant dev_err()/dev_err_probe() Pan Chuang

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260717112103.213017-7-panchuang@vivo.com \
    --to=panchuang@vivo.com \
    --cc=bcm-kernel-feedback-list@broadcom.com \
    --cc=florian.fainelli@broadcom.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=jai.luthra@ideasonboard.com \
    --cc=kees@kernel.org \
    --cc=laurent.pinchart@ideasonboard.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rpi-kernel@lists.infradead.org \
    --cc=phil@raspberrypi.com \
    --cc=wahrenst@gmx.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox