Re: [PATCH 1/7] platform: arm64: Remove redundant dev_err_probe()

[Sebastian Reichel <sre@kernel.org>]

[-- Attachment #1: Type: text/plain, Size: 3111 bytes --]

Hi,

On Fri, Jul 17, 2026 at 07:20:39PM +0800, Pan Chuang wrote:
> Since commit 55b48e23f5c4 ("genirq/devres: Add error handling in
> devm_request_*_irq()"), devm_request_threaded_irq() automatically logs
> detailed error messages on failure. Remove the now-redundant
> driver-specific dev_err_probe() calls.
> 
> Signed-off-by: Pan Chuang <panchuang@vivo.com>
> ---

Reviewed-by: Sebastian Reichel <sre@kernel.org>

Greetings,

-- Sebastian

>  drivers/platform/arm64/acer-aspire1-ec.c      | 2 +-
>  drivers/platform/arm64/huawei-gaokun-ec.c     | 2 +-
>  drivers/platform/arm64/lenovo-thinkpad-t14s.c | 2 +-
>  drivers/platform/arm64/lenovo-yoga-c630.c     | 2 +-
>  4 files changed, 4 insertions(+), 4 deletions(-)
> 
> diff --git a/drivers/platform/arm64/acer-aspire1-ec.c b/drivers/platform/arm64/acer-aspire1-ec.c
> index 08d0b155a197..501c62a096f8 100644
> --- a/drivers/platform/arm64/acer-aspire1-ec.c
> +++ b/drivers/platform/arm64/acer-aspire1-ec.c
> @@ -514,7 +514,7 @@ static int aspire_ec_probe(struct i2c_client *client)
>  					aspire_ec_irq_handler, IRQF_ONESHOT,
>  					dev_name(dev), ec);
>  	if (ret)
> -		return dev_err_probe(dev, ret, "Failed to request irq\n");
> +		return ret;
>  
>  	return 0;
>  }
> diff --git a/drivers/platform/arm64/huawei-gaokun-ec.c b/drivers/platform/arm64/huawei-gaokun-ec.c
> index 80a8ba8b8dda..d4ce8ad6426c 100644
> --- a/drivers/platform/arm64/huawei-gaokun-ec.c
> +++ b/drivers/platform/arm64/huawei-gaokun-ec.c
> @@ -783,7 +783,7 @@ static int gaokun_ec_probe(struct i2c_client *client)
>  					gaokun_ec_irq_handler, IRQF_ONESHOT,
>  					dev_name(dev), ec);
>  	if (ret)
> -		return dev_err_probe(dev, ret, "Failed to request IRQ\n");
> +		return ret;
>  
>  	ec->hwmon_dev = devm_hwmon_device_register_with_info(dev, "gaokun_ec_hwmon",
>  							     ec, &gaokun_ec_hwmon_chip_info, NULL);
> diff --git a/drivers/platform/arm64/lenovo-thinkpad-t14s.c b/drivers/platform/arm64/lenovo-thinkpad-t14s.c
> index e7acb66b77f2..191ecd7f85b5 100644
> --- a/drivers/platform/arm64/lenovo-thinkpad-t14s.c
> +++ b/drivers/platform/arm64/lenovo-thinkpad-t14s.c
> @@ -594,7 +594,7 @@ static int t14s_ec_probe(struct i2c_client *client)
>  					t14s_ec_irq_handler,
>  					IRQF_ONESHOT, dev_name(dev), ec);
>  	if (ret < 0)
> -		return dev_err_probe(dev, ret, "Failed to get IRQ\n");
> +		return ret;
>  
>  	/*
>  	 * Disable wakeup support by default, because the driver currently does
> diff --git a/drivers/platform/arm64/lenovo-yoga-c630.c b/drivers/platform/arm64/lenovo-yoga-c630.c
> index a8600a977fbc..cad40c58c55b 100644
> --- a/drivers/platform/arm64/lenovo-yoga-c630.c
> +++ b/drivers/platform/arm64/lenovo-yoga-c630.c
> @@ -221,7 +221,7 @@ static int yoga_c630_ec_probe(struct i2c_client *client)
>  					NULL, yoga_c630_ec_thread_intr,
>  					IRQF_ONESHOT, "yoga_c630_ec", ec);
>  	if (ret < 0)
> -		return dev_err_probe(dev, ret, "unable to request irq\n");
> +		return ret;
>  
>  	ret = yoga_c630_aux_init(dev, YOGA_C630_DEV_PSY, ec);
>  	if (ret)
> -- 
> 2.34.1
> 

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 833 bytes --]