From: Henrik Grimler <henrik.grimler@axis.com>
To: Jesper Nilsson <jesper.nilsson@axis.com>,
Lars Persson <lars.persson@axis.com>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Richard Cochran <richardcochran@gmail.com>
Cc: linux-arm-kernel@axis.com, kernel@axis.com,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Henrik Grimler <henrik@grimler.se>,
Henrik Grimler <henrik.grimler@axis.com>
Subject: [PATCH 4/7] ARM: dts: axis: artpec6: sort all properties
Date: Mon, 28 Sep 2026 14:04:50 +0200 [thread overview]
Message-ID: <20260928-b4-artpec6-cleanup-v1-4-e3b75e10acc6@axis.com> (raw)
In-Reply-To: <20260928-b4-artpec6-cleanup-v1-0-e3b75e10acc6@axis.com>
To make as easy as possible to read devicetree nodes, the properties
should be alphabetical, with a few exceptions (compatible, reg,
status, ..). Update the artpec-6 dtses to use preferred style. Issues
are detected by dt-check-style when run in strict mode as:
axis/artpec6.dtsi:93: [property-order] property 'compatible' out of canonical order (should sort before '#clock-cells')
Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
arch/arm/boot/dts/axis/artpec6-devboard.dts | 8 +++---
arch/arm/boot/dts/axis/artpec6.dtsi | 40 ++++++++++++++---------------
2 files changed, 24 insertions(+), 24 deletions(-)
diff --git a/arch/arm/boot/dts/axis/artpec6-devboard.dts b/arch/arm/boot/dts/axis/artpec6-devboard.dts
index 042a9cc920c6..9a91f9758442 100644
--- a/arch/arm/boot/dts/axis/artpec6-devboard.dts
+++ b/arch/arm/boot/dts/axis/artpec6-devboard.dts
@@ -46,18 +46,18 @@ &pcie {
};
ðernet {
- status = "okay";
-
phy-handle = <&phy1>;
phy-mode = "gmii";
+ status = "okay";
+
mdio {
+ compatible = "snps,dwmac-mdio";
#address-cells = <0x1>;
#size-cells = <0x0>;
- compatible = "snps,dwmac-mdio";
phy1: phy@0 {
- compatible = "ethernet-phy-ieee802.3-c22";
device_type = "ethernet-phy";
+ compatible = "ethernet-phy-ieee802.3-c22";
reg = <0x0>;
};
};
diff --git a/arch/arm/boot/dts/axis/artpec6.dtsi b/arch/arm/boot/dts/axis/artpec6.dtsi
index 49439058854d..d3079badcf21 100644
--- a/arch/arm/boot/dts/axis/artpec6.dtsi
+++ b/arch/arm/boot/dts/axis/artpec6.dtsi
@@ -45,9 +45,9 @@
#include <dt-bindings/clock/axis,artpec6-clkctrl.h>
/ {
+ compatible = "axis,artpec6";
#address-cells = <1>;
#size-cells = <1>;
- compatible = "axis,artpec6";
interrupt-parent = <&intc>;
cpus {
@@ -89,21 +89,21 @@ scu@faf00000 {
/* Main external clock driving CPU and peripherals */
ext_clk: ext-clk {
- #clock-cells = <0>;
compatible = "fixed-clock";
+ #clock-cells = <0>;
clock-frequency = <50000000>;
};
eth_phy_ref_clk: eth-phy-ref-clk {
- #clock-cells = <0>;
compatible = "fixed-clock";
+ #clock-cells = <0>;
clock-frequency = <125000000>;
};
clkctrl: clkctrl@f8000000 {
- #clock-cells = <1>;
compatible = "axis,artpec6-clkctrl";
reg = <0xf8000000 0x48>;
+ #clock-cells = <1>;
clocks = <&ext_clk>;
clock-names = "sys_refclk";
};
@@ -124,26 +124,26 @@ timer@faf00600 {
};
intc: interrupt-controller@faf01000 {
- interrupt-controller;
compatible = "arm,cortex-a9-gic";
+ reg = <0xfaf01000 0x1000>, <0xfaf00100 0x0100>;
+ interrupt-controller;
#interrupt-cells = <3>;
- reg = < 0xfaf01000 0x1000 >, < 0xfaf00100 0x0100 >;
};
pl310: cache-controller@faf10000 {
compatible = "arm,pl310-cache";
+ reg = <0xfaf10000 0x1000>;
cache-unified;
cache-level = <2>;
- reg = <0xfaf10000 0x1000>;
interrupts = <GIC_SPI 4 IRQ_TYPE_LEVEL_HIGH>;
+ prefetch-data = <1>;
+ prefetch-instr = <1>;
arm,data-latency = <1 1 1>;
arm,tag-latency = <1 1 1>;
arm,filter-ranges = <0x0 0x80000000>;
arm,double-linefill = <1>;
arm,double-linefill-incr = <0>;
arm,double-linefill-wrap = <0>;
- prefetch-data = <1>;
- prefetch-instr = <1>;
arm,prefetch-offset = <0>;
arm,prefetch-drop = <1>;
};
@@ -160,18 +160,18 @@ pmu {
* leave the unwanted node as disabled.
*/
pcie: pcie@f8050000 {
+ device_type = "pci";
compatible = "axis,artpec6-pcie", "snps,dw-pcie";
reg = <0xf8050000 0x2000>,
<0xf8040000 0x1000>,
<0xc0000000 0x2000>;
reg-names = "dbi", "phy", "config";
- #address-cells = <3>;
- #size-cells = <2>;
- device_type = "pci";
/* downstream I/O */
ranges = <0x81000000 0 0 0xc0002000 0 0x00010000>,
/* non-prefetchable memory */
<0x82000000 0 0xc0012000 0xc0012000 0 0x1ffee000>;
+ #address-cells = <3>;
+ #size-cells = <2>;
num-lanes = <2>;
bus-range = <0x00 0xff>;
interrupts = <GIC_SPI 148 IRQ_TYPE_LEVEL_HIGH>;
@@ -228,9 +228,9 @@ pinctrl_uart3: uart3grp {
amba@0 {
compatible = "simple-bus";
+ ranges;
#address-cells = <0x1>;
#size-cells = <0x1>;
- ranges;
dma-ranges;
crypto@f4264000 {
@@ -285,14 +285,14 @@ dma1: dma@f8019400 {
};
ethernet: ethernet@f8010000 {
- clock-names = "stmmaceth", "ptp_ref";
+ compatible = "snps,dwmac-4.10a", "snps,dwmac";
+ reg = <0xf8010000 0x4000>;
clocks = <&clkctrl ARTPEC6_CLK_ETH_ACLK>,
<&clkctrl ARTPEC6_CLK_PTP_REF>;
- compatible = "snps,dwmac-4.10a", "snps,dwmac";
+ clock-names = "stmmaceth", "ptp_ref";
interrupts = <GIC_SPI 98 IRQ_TYPE_LEVEL_HIGH>,
<GIC_SPI 99 IRQ_TYPE_LEVEL_HIGH>;
interrupt-names = "macirq", "eth_lpi";
- reg = <0xf8010000 0x4000>;
snps,axi-config = <&stmmac_axi_setup>;
snps,mtl-rx-config = <&mtl_rx_setup>;
@@ -335,8 +335,8 @@ uart0: serial@f8036000 {
clocks = <&clkctrl ARTPEC6_CLK_UART_REFCLK>,
<&clkctrl ARTPEC6_CLK_UART_PCLK>;
clock-names = "uart_clk", "apb_pclk";
- pinctrl-names = "default";
pinctrl-0 = <&pinctrl_uart0>;
+ pinctrl-names = "default";
dmas = <&dma0 4 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>,
<&dma0 5 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>;
dma-names = "rx", "tx";
@@ -349,8 +349,8 @@ uart1: serial@f8037000 {
clocks = <&clkctrl ARTPEC6_CLK_UART_REFCLK>,
<&clkctrl ARTPEC6_CLK_UART_PCLK>;
clock-names = "uart_clk", "apb_pclk";
- pinctrl-names = "default";
pinctrl-0 = <&pinctrl_uart1>;
+ pinctrl-names = "default";
dmas = <&dma0 6 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>,
<&dma0 7 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>;
dma-names = "rx", "tx";
@@ -363,8 +363,8 @@ uart2: serial@f8038000 {
clocks = <&clkctrl ARTPEC6_CLK_UART_REFCLK>,
<&clkctrl ARTPEC6_CLK_UART_PCLK>;
clock-names = "uart_clk", "apb_pclk";
- pinctrl-names = "default";
pinctrl-0 = <&pinctrl_uart2>;
+ pinctrl-names = "default";
dmas = <&dma1 0 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>,
<&dma1 1 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>;
dma-names = "rx", "tx";
@@ -377,8 +377,8 @@ uart3: serial@f8039000 {
clocks = <&clkctrl ARTPEC6_CLK_UART_REFCLK>,
<&clkctrl ARTPEC6_CLK_UART_PCLK>;
clock-names = "uart_clk", "apb_pclk";
- pinctrl-names = "default";
pinctrl-0 = <&pinctrl_uart3>;
+ pinctrl-names = "default";
dmas = <&dma1 2 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>,
<&dma1 3 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>;
dma-names = "rx", "tx";
--
2.43.0
next prev parent reply other threads:[~2026-09-28 12:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 12:04 [PATCH 0/7] ARM: dts: artpec: cleanup with the help of dt-check-style Henrik Grimler
2026-09-28 12:04 ` [PATCH 1/7] ARM: dts: axis: artpec6: avoid _ in node names Henrik Grimler
2026-09-30 5:24 ` Krzysztof Kozlowski
2026-09-28 12:04 ` [PATCH 2/7] ARM: dts: axis: artpec6: align all continued lines Henrik Grimler
2026-09-30 5:30 ` (subset) " Krzysztof Kozlowski
2026-09-30 5:44 ` Krzysztof Kozlowski
2026-09-30 6:22 ` Henrik Grimler
2026-09-30 8:39 ` Krzysztof Kozlowski
2026-09-28 12:04 ` [PATCH 3/7] ARM: dts: axis: artpec6: use multiple tuples in regs and ranges Henrik Grimler
2026-09-28 12:04 ` Henrik Grimler [this message]
2026-09-28 12:04 ` [PATCH 5/7] ARM: dts: axis: artpec6: add more blank lines Henrik Grimler
2026-09-28 12:04 ` [PATCH 6/7] ARM: dts: axis: artpec6: put inline comments on same line as entries Henrik Grimler
2026-09-30 5:29 ` Krzysztof Kozlowski
2026-09-28 12:04 ` [PATCH 7/7] ARM: dts: axis: artpec6: add empty lines before empty queue nodes Henrik Grimler
2026-09-30 5:27 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928-b4-artpec6-cleanup-v1-4-e3b75e10acc6@axis.com \
--to=henrik.grimler@axis.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=henrik@grimler.se \
--cc=jesper.nilsson@axis.com \
--cc=kernel@axis.com \
--cc=krzk+dt@kernel.org \
--cc=lars.persson@axis.com \
--cc=linux-arm-kernel@axis.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=richardcochran@gmail.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®