mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Henrik Grimler <henrik.grimler@axis.com>
To: Jesper Nilsson <jesper.nilsson@axis.com>,
	 Lars Persson <lars.persson@axis.com>,
	Rob Herring <robh@kernel.org>,
	 Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	 Richard Cochran <richardcochran@gmail.com>
Cc: linux-arm-kernel@axis.com, kernel@axis.com,
	devicetree@vger.kernel.org,  linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org,  Henrik Grimler <henrik@grimler.se>,
	 Henrik Grimler <henrik.grimler@axis.com>
Subject: [PATCH 5/7] ARM: dts: axis: artpec6: add more blank lines
Date: Mon, 28 Sep 2026 14:04:51 +0200	[thread overview]
Message-ID: <20260928-b4-artpec6-cleanup-v1-5-e3b75e10acc6@axis.com> (raw)
In-Reply-To: <20260928-b4-artpec6-cleanup-v1-0-e3b75e10acc6@axis.com>

The status property, and each child node, should preferably have empty
lines before them to increase readability. dt-check-style in strict
mode reports this type of issue as:

  axis/artpec6.dtsi:186: [required-blank-lines] "status" must be preceded by a blank line

Fix all occurences.

Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
 arch/arm/boot/dts/axis/artpec6-devboard.dts |  1 +
 arch/arm/boot/dts/axis/artpec6.dtsi         | 14 ++++++++++++++
 2 files changed, 15 insertions(+)

diff --git a/arch/arm/boot/dts/axis/artpec6-devboard.dts b/arch/arm/boot/dts/axis/artpec6-devboard.dts
index 9a91f9758442..55fdd610d3ed 100644
--- a/arch/arm/boot/dts/axis/artpec6-devboard.dts
+++ b/arch/arm/boot/dts/axis/artpec6-devboard.dts
@@ -55,6 +55,7 @@ mdio {
 		compatible = "snps,dwmac-mdio";
 		#address-cells = <0x1>;
 		#size-cells = <0x0>;
+
 		phy1: phy@0 {
 			device_type = "ethernet-phy";
 			compatible = "ethernet-phy-ieee802.3-c22";
diff --git a/arch/arm/boot/dts/axis/artpec6.dtsi b/arch/arm/boot/dts/axis/artpec6.dtsi
index d3079badcf21..146a5fd98528 100644
--- a/arch/arm/boot/dts/axis/artpec6.dtsi
+++ b/arch/arm/boot/dts/axis/artpec6.dtsi
@@ -120,6 +120,7 @@ timer@faf00600 {
 		reg = <0xfaf00600 0x20>;
 		interrupts = <GIC_PPI 13 0xf04>;
 		clocks = <&clkctrl ARTPEC6_CLK_CPU_PERIPH>;
+
 		status = "disabled";
 	};
 
@@ -183,6 +184,7 @@ pcie: pcie@f8050000 {
 				<0 0 0 3 &intc GIC_SPI 146 IRQ_TYPE_LEVEL_HIGH>,
 				<0 0 0 4 &intc GIC_SPI 147 IRQ_TYPE_LEVEL_HIGH>;
 		axis,syscon-pcie = <&syscon>;
+
 		status = "disabled";
 	};
 
@@ -197,6 +199,7 @@ pcie_ep: pcie-ep@f8050000 {
 		num-ob-windows = <2>;
 		num-lanes = <2>;
 		axis,syscon-pcie = <&syscon>;
+
 		status = "disabled";
 	};
 
@@ -209,16 +212,19 @@ pinctrl_uart0: uart0grp {
 			groups = "uart0grp2";
 			bias-pull-up;
 		};
+
 		pinctrl_uart1: uart1grp {
 			function = "uart1";
 			groups = "uart1grp0";
 			bias-pull-up;
 		};
+
 		pinctrl_uart2: uart2grp {
 			function = "uart2";
 			groups = "uart2grp1";
 			bias-pull-up;
 		};
+
 		pinctrl_uart3: uart3grp {
 			function = "uart3";
 			groups = "uart3grp0";
@@ -261,6 +267,7 @@ dma0: dma@f8019000 {
 			dma-channels = <8>;
 			dma-requests = <8>;
 		};
+
 		dma1: dma@f8019400 {
 			compatible = "renesas,nbpfaxi64dmac8b16";
 			reg = <0xf8019400 0x400>;
@@ -340,8 +347,10 @@ uart0: serial@f8036000 {
 			dmas = <&dma0 4 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>,
 			       <&dma0 5 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>;
 			dma-names = "rx", "tx";
+
 			status = "disabled";
 		};
+
 		uart1: serial@f8037000 {
 			compatible = "arm,pl011", "arm,primecell";
 			reg = <0xf8037000 0x1000>;
@@ -354,8 +363,10 @@ uart1: serial@f8037000 {
 			dmas = <&dma0 6 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>,
 			       <&dma0 7 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>;
 			dma-names = "rx", "tx";
+
 			status = "disabled";
 		};
+
 		uart2: serial@f8038000 {
 			compatible = "arm,pl011", "arm,primecell";
 			reg = <0xf8038000 0x1000>;
@@ -368,8 +379,10 @@ uart2: serial@f8038000 {
 			dmas = <&dma1 0 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>,
 			       <&dma1 1 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>;
 			dma-names = "rx", "tx";
+
 			status = "disabled";
 		};
+
 		uart3: serial@f8039000 {
 			compatible = "arm,pl011", "arm,primecell";
 			reg = <0xf8039000 0x1000>;
@@ -382,6 +395,7 @@ uart3: serial@f8039000 {
 			dmas = <&dma1 2 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>,
 			       <&dma1 3 (NBPF_SLAVE_RQ_HIGH | NBPF_SLAVE_RQ_LEVEL)>;
 			dma-names = "rx", "tx";
+
 			status = "disabled";
 		};
 	};

-- 
2.43.0


  parent reply	other threads:[~2026-09-28 12:05 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28 12:04 [PATCH 0/7] ARM: dts: artpec: cleanup with the help of dt-check-style Henrik Grimler
2026-09-28 12:04 ` [PATCH 1/7] ARM: dts: axis: artpec6: avoid _ in node names Henrik Grimler
2026-09-30  5:24   ` Krzysztof Kozlowski
2026-09-28 12:04 ` [PATCH 2/7] ARM: dts: axis: artpec6: align all continued lines Henrik Grimler
2026-09-30  5:30   ` (subset) " Krzysztof Kozlowski
2026-09-30  5:44     ` Krzysztof Kozlowski
2026-09-30  6:22       ` Henrik Grimler
2026-09-30  8:39         ` Krzysztof Kozlowski
2026-09-28 12:04 ` [PATCH 3/7] ARM: dts: axis: artpec6: use multiple tuples in regs and ranges Henrik Grimler
2026-09-28 12:04 ` [PATCH 4/7] ARM: dts: axis: artpec6: sort all properties Henrik Grimler
2026-09-28 12:04 ` Henrik Grimler [this message]
2026-09-28 12:04 ` [PATCH 6/7] ARM: dts: axis: artpec6: put inline comments on same line as entries Henrik Grimler
2026-09-30  5:29   ` Krzysztof Kozlowski
2026-09-28 12:04 ` [PATCH 7/7] ARM: dts: axis: artpec6: add empty lines before empty queue nodes Henrik Grimler
2026-09-30  5:27   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260928-b4-artpec6-cleanup-v1-5-e3b75e10acc6@axis.com \
    --to=henrik.grimler@axis.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=henrik@grimler.se \
    --cc=jesper.nilsson@axis.com \
    --cc=kernel@axis.com \
    --cc=krzk+dt@kernel.org \
    --cc=lars.persson@axis.com \
    --cc=linux-arm-kernel@axis.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®