mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Krzysztof Kozlowski <krzk@kernel.org>
To: Henrik Grimler <henrik.grimler@axis.com>,
	Jesper Nilsson <jesper.nilsson@axis.com>,
	Lars Persson <lars.persson@axis.com>,
	Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	Conor Dooley <conor+dt@kernel.org>,
	Richard Cochran <richardcochran@gmail.com>
Cc: linux-arm-kernel@axis.com, kernel@axis.com,
	devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
	netdev@vger.kernel.org, Henrik Grimler <henrik@grimler.se>
Subject: Re: [PATCH 6/7] ARM: dts: axis: artpec6: put inline comments on same line as entries
Date: Wed, 30 Sep 2026 07:29:09 +0200	[thread overview]
Message-ID: <50a12135-b7c2-492e-aa8a-363715600e44@kernel.org> (raw)
In-Reply-To: <20260928-b4-artpec6-cleanup-v1-6-e3b75e10acc6@axis.com>

On 28/09/2026 14:04, Henrik Grimler wrote:
> By having the comments next to the data they describe it is easier to
> read the property. This fixes indent-consistent and
> continuation-alignment warnings from dt-check-style in strict mode,
> e.g. warnings like:
> 
>   axis/artpec6.dtsi:170: [indent-consistent] indent mismatch (expected depth 2 * '\t')
>   axis/artpec6.dtsi:172: [continuation-alignment] continuation should align to column 26 (to < or ")
> 
> Also shorten one of the comments a bit so that the entire line fits
> under 100 chars.
> 
> Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
> ---
>  arch/arm/boot/dts/axis/artpec6.dtsi | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/axis/artpec6.dtsi b/arch/arm/boot/dts/axis/artpec6.dtsi
> index 146a5fd98528..c9f671fd685a 100644
> --- a/arch/arm/boot/dts/axis/artpec6.dtsi
> +++ b/arch/arm/boot/dts/axis/artpec6.dtsi
> @@ -167,10 +167,8 @@ pcie: pcie@f8050000 {
>  		      <0xf8040000 0x1000>,
>  		      <0xc0000000 0x2000>;
>  		reg-names = "dbi", "phy", "config";
> -			  /* downstream I/O */
> -		ranges = <0x81000000 0 0 0xc0002000 0 0x00010000>,
> -			  /* non-prefetchable memory */
> -			 <0x82000000 0 0xc0012000 0xc0012000 0 0x1ffee000>;
> +		ranges = <0x81000000 0 0 0xc0002000 0 0x00010000>,          /* downstream I/O */
> +			 <0x82000000 0 0xc0012000 0xc0012000 0 0x1ffee000>; /* non-prefetchable */

Squash with the #3 patch.

Best regards,
Krzysztof

  reply	other threads:[~2026-09-30  5:29 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-28 12:04 [PATCH 0/7] ARM: dts: artpec: cleanup with the help of dt-check-style Henrik Grimler
2026-09-28 12:04 ` [PATCH 1/7] ARM: dts: axis: artpec6: avoid _ in node names Henrik Grimler
2026-09-30  5:24   ` Krzysztof Kozlowski
2026-09-28 12:04 ` [PATCH 2/7] ARM: dts: axis: artpec6: align all continued lines Henrik Grimler
2026-09-30  5:30   ` (subset) " Krzysztof Kozlowski
2026-09-30  5:44     ` Krzysztof Kozlowski
2026-09-30  6:22       ` Henrik Grimler
2026-09-30  8:39         ` Krzysztof Kozlowski
2026-09-28 12:04 ` [PATCH 3/7] ARM: dts: axis: artpec6: use multiple tuples in regs and ranges Henrik Grimler
2026-09-28 12:04 ` [PATCH 4/7] ARM: dts: axis: artpec6: sort all properties Henrik Grimler
2026-09-28 12:04 ` [PATCH 5/7] ARM: dts: axis: artpec6: add more blank lines Henrik Grimler
2026-09-28 12:04 ` [PATCH 6/7] ARM: dts: axis: artpec6: put inline comments on same line as entries Henrik Grimler
2026-09-30  5:29   ` Krzysztof Kozlowski [this message]
2026-09-28 12:04 ` [PATCH 7/7] ARM: dts: axis: artpec6: add empty lines before empty queue nodes Henrik Grimler
2026-09-30  5:27   ` Krzysztof Kozlowski

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=50a12135-b7c2-492e-aa8a-363715600e44@kernel.org \
    --to=krzk@kernel.org \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=henrik.grimler@axis.com \
    --cc=henrik@grimler.se \
    --cc=jesper.nilsson@axis.com \
    --cc=kernel@axis.com \
    --cc=krzk+dt@kernel.org \
    --cc=lars.persson@axis.com \
    --cc=linux-arm-kernel@axis.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=netdev@vger.kernel.org \
    --cc=richardcochran@gmail.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®