mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Henrik Grimler <henrik.grimler@axis.com>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	 Peter Griffin <peter.griffin@linaro.org>,
	 Alim Akhtar <alim.akhtar@samsung.com>
Cc: devicetree@vger.kernel.org, waqar.hameed@axis.com,
	 linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,  linux-kernel@vger.kernel.org,
	Henrik Grimler <henrik.grimler@axis.com>
Subject: [PATCH v2 13/17] ARM: dts: samsung: exynos4210-origen: sort properties
Date: Tue, 06 Oct 2026 13:57:27 +0200	[thread overview]
Message-ID: <20261006-exynos-arm-cleanup-v2-13-e8e86a3c8c1f@axis.com> (raw)
In-Reply-To: <20261006-exynos-arm-cleanup-v2-0-e8e86a3c8c1f@axis.com>

And add or delete newlines where applicable, and sort properties
according to the preferred style. Fixes warnings from dt-check-style
like:

  samsung/exynos4210-origen.dts:171: [required-blank-lines] "status" must be preceded by a blank line
  samsung/exynos4210-origen.dts:176: [property-order] property 'samsung,i2c-sda-delay' out of canonical order (should sort before 'status')
  samsung/exynos4210-origen.dts:178: [property-order] property 'pinctrl-0' out of canonical order (should sort before 'samsung,i2c-max-bus-freq')

Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
 arch/arm/boot/dts/samsung/exynos4210-origen.dts | 30 ++++++++++++++++---------
 1 file changed, 20 insertions(+), 10 deletions(-)

diff --git a/arch/arm/boot/dts/samsung/exynos4210-origen.dts b/arch/arm/boot/dts/samsung/exynos4210-origen.dts
index f1927ca15e08..78c77d00d138 100644
--- a/arch/arm/boot/dts/samsung/exynos4210-origen.dts
+++ b/arch/arm/boot/dts/samsung/exynos4210-origen.dts
@@ -55,41 +55,42 @@ gpio-keys {
 		key-up {
 			label = "Up";
 			gpios = <&gpx2 0 GPIO_ACTIVE_LOW>;
-			linux,code = <KEY_UP>;
 			wakeup-source;
+			linux,code = <KEY_UP>;
 		};
 
 		key-down {
 			label = "Down";
 			gpios = <&gpx2 1 GPIO_ACTIVE_LOW>;
-			linux,code = <KEY_DOWN>;
 			wakeup-source;
+			linux,code = <KEY_DOWN>;
 		};
 
 		key-back {
 			label = "Back";
 			gpios = <&gpx1 7 GPIO_ACTIVE_LOW>;
-			linux,code = <KEY_BACK>;
 			wakeup-source;
+			linux,code = <KEY_BACK>;
 		};
 
 		key-home {
 			label = "Home";
 			gpios = <&gpx1 6 GPIO_ACTIVE_LOW>;
-			linux,code = <KEY_HOME>;
 			wakeup-source;
+			linux,code = <KEY_HOME>;
 		};
 
 		key-menu {
 			label = "Menu";
 			gpios = <&gpx1 5 GPIO_ACTIVE_LOW>;
-			linux,code = <KEY_MENU>;
 			wakeup-source;
+			linux,code = <KEY_MENU>;
 		};
 	};
 
 	leds {
 		compatible = "gpio-leds";
+
 		led-status {
 			gpios = <&gpx1 3 GPIO_ACTIVE_LOW>;
 			function = LED_FUNCTION_HEARTBEAT;
@@ -118,6 +119,7 @@ pmic_ap_clk: pmic-ap-clk {
 
 	display-timings {
 		native-mode = <&timing0>;
+
 		timing0: timing {
 			clock-frequency = <47500000>;
 			hactive = <1024>;
@@ -142,6 +144,7 @@ map0 {
 			/* Corresponds to 800MHz */
 			cooling-device = <&cpu0 2 2>;
 		};
+
 		map1 {
 			/* Corresponds to 200MHz */
 			cooling-device = <&cpu0 4 4>;
@@ -156,11 +159,13 @@ &exynos_usbphy {
 &fimd {
 	pinctrl-0 = <&lcd_en &lcd_clk &lcd_data24 &pwm0_out>;
 	pinctrl-names = "default";
+
 	status = "okay";
 };
 
 &gpu {
 	mali-supply = <&buck3_reg>;
+
 	status = "okay";
 };
 
@@ -168,23 +173,25 @@ &hsotg {
 	vusb_d-supply = <&ldo3_reg>;
 	vusb_a-supply = <&ldo8_reg>;
 	dr_mode = "peripheral";
+
 	status = "okay";
 };
 
 &i2c_0 {
-	status = "okay";
-	samsung,i2c-sda-delay = <100>;
-	samsung,i2c-max-bus-freq = <20000>;
 	pinctrl-0 = <&i2c0_bus>;
 	pinctrl-names = "default";
+	samsung,i2c-sda-delay = <100>;
+	samsung,i2c-max-bus-freq = <20000>;
+
+	status = "okay";
 
 	pmic@66 {
 		compatible = "maxim,max8997-pmic";
 		reg = <0x66>;
 		interrupt-parent = <&gpx0>;
 		interrupts = <4 IRQ_TYPE_NONE>, <3 IRQ_TYPE_NONE>;
-		pinctrl-names = "default";
 		pinctrl-0 = <&max8997_irq>;
+		pinctrl-names = "default";
 
 		max8997,pmic-buck1-dvs-voltage = <1350000>;
 		max8997,pmic-buck2-dvs-voltage = <1100000>;
@@ -334,6 +341,7 @@ &sdhci_0 {
 	pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus4 &sd0_cd>;
 	pinctrl-names = "default";
 	vmmc-supply = <&mmc_reg>;
+
 	status = "okay";
 };
 
@@ -342,6 +350,7 @@ &sdhci_2 {
 	pinctrl-0 = <&sd2_clk &sd2_cmd &sd2_bus4 &sd2_cd>;
 	pinctrl-names = "default";
 	vmmc-supply = <&mmc_reg>;
+
 	status = "okay";
 };
 
@@ -362,9 +371,10 @@ &serial_3 {
 };
 
 &rtc {
-	status = "okay";
 	clocks = <&clock CLK_RTC>, <&pmic_ap_clk>;
 	clock-names = "rtc", "rtc_src";
+
+	status = "okay";
 };
 
 &tmu {

-- 
2.43.0


  parent reply	other threads:[~2026-10-06 11:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-06 11:57 [PATCH v2 00/17] ARM: dts: samsung: cleanup Exynos 4210 dts'es Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 01/17] ARM: dts: samsung: exynos4: add or remove empty lines Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 02/17] ARM: dts: samsung: exynos4: order *-names properties Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 03/17] ARM: dts: samsung: exynos4: sort all properties Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 04/17] ARM: dts: samsung: exynos4-cpu-thermal: fix indentation and sort Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 05/17] ARM: dts: samsung: exynos4210: sort nodes by address Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 06/17] ARM: dts: samsung: exynos4210: add or remove empty lines Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 07/17] ARM: dts: samsung: exynos4210: sort all properties Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 08/17] ARM: dts: samsung: exynos4210: use operating-points-v2 Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 09/17] ARM: dts: samsung: exynos4210: align all multiline properties Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 10/17] ARM: dts: samsung: exynos4210-pinctrl: align all continued lines Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 11/17] ARM: dts: samsung: exynos4210-i9100: sort properties Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 12/17] ARM: dts: samsung: exynos4210-trats: " Henrik Grimler
2026-10-06 11:57 ` Henrik Grimler [this message]
2026-10-06 11:57 ` [PATCH v2 14/17] ARM: dts: samsung: exynos4210-universal_c210: " Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 15/17] ARM: dts: samsung: exynos4210-smdkv310: " Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 16/17] ARM: dts: samsung: exynos4210-smdkv310: sort child nodes Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 17/17] ARM: dts: samsung: exynos4210-universal_c210: fix alignments Henrik Grimler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261006-exynos-arm-cleanup-v2-13-e8e86a3c8c1f@axis.com \
    --to=henrik.grimler@axis.com \
    --cc=alim.akhtar@samsung.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    --cc=waqar.hameed@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®