From: Henrik Grimler <henrik.grimler@axis.com>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Peter Griffin <peter.griffin@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>
Cc: devicetree@vger.kernel.org, waqar.hameed@axis.com,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Henrik Grimler <henrik.grimler@axis.com>
Subject: [PATCH v2 05/17] ARM: dts: samsung: exynos4210: sort nodes by address
Date: Tue, 06 Oct 2026 13:57:19 +0200 [thread overview]
Message-ID: <20261006-exynos-arm-cleanup-v2-5-e8e86a3c8c1f@axis.com> (raw)
In-Reply-To: <20261006-exynos-arm-cleanup-v2-0-e8e86a3c8c1f@axis.com>
Nodes should be sorted by address, or in the absence of an address,
alphabetically. Sort all nodes except the pinctrl ones, to keep them
grouped and in order by alias numbering.
Fixes child-address-order warnings from dt-check-style in strict mode
like:
samsung/exynos4210.dtsi:369: [child-address-order] child node @12220000 out of address order
Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
arch/arm/boot/dts/samsung/exynos4210.dtsi | 77 ++++++++++++++++---------------
1 file changed, 39 insertions(+), 38 deletions(-)
diff --git a/arch/arm/boot/dts/samsung/exynos4210.dtsi b/arch/arm/boot/dts/samsung/exynos4210.dtsi
index 510e8665d1a2..66b1a55f703d 100644
--- a/arch/arm/boot/dts/samsung/exynos4210.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos4210.dtsi
@@ -269,15 +269,10 @@ pd_lcd1: power-domain@10023ca0 {
label = "LCD1";
};
- l2c: cache-controller@10502000 {
- compatible = "arm,pl310-cache";
- reg = <0x10502000 0x1000>;
- cache-unified;
- cache-level = <2>;
- prefetch-data = <1>;
- prefetch-instr = <1>;
- arm,tag-latency = <2 2 1>;
- arm,data-latency = <2 2 1>;
+ clock: clock-controller@10030000 {
+ compatible = "samsung,exynos4210-clock";
+ reg = <0x10030000 0x20000>;
+ #clock-cells = <1>;
};
mct: timer@10050000 {
@@ -301,10 +296,22 @@ watchdog: watchdog@10060000 {
clock-names = "watchdog";
};
- clock: clock-controller@10030000 {
- compatible = "samsung,exynos4210-clock";
- reg = <0x10030000 0x20000>;
- #clock-cells = <1>;
+ l2c: cache-controller@10502000 {
+ compatible = "arm,pl310-cache";
+ reg = <0x10502000 0x1000>;
+ cache-unified;
+ cache-level = <2>;
+ prefetch-data = <1>;
+ prefetch-instr = <1>;
+ arm,tag-latency = <2 2 1>;
+ arm,data-latency = <2 2 1>;
+ };
+
+ ppmu_acp: ppmu@10ae0000 {
+ compatible = "samsung,exynos-ppmu";
+ reg = <0x10ae0000 0x2000>;
+
+ status = "disabled";
};
pinctrl_0: pinctrl@11400000 {
@@ -330,20 +337,15 @@ pinctrl_2: pinctrl@3860000 {
reg = <0x03860000 0x1000>;
};
- g2d: g2d@12800000 {
- compatible = "samsung,s5pv210-g2d";
- reg = <0x12800000 0x1000>;
- interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>;
- clocks = <&clock CLK_SCLK_FIMG2D>, <&clock CLK_G2D>;
- clock-names = "sclk_fimg2d", "fimg2d";
- power-domains = <&pd_lcd0>;
- iommus = <&sysmmu_g2d>;
- };
-
- ppmu_acp: ppmu@10ae0000 {
- compatible = "samsung,exynos-ppmu";
- reg = <0x10ae0000 0x2000>;
- status = "disabled";
+ sysmmu_fimd1: sysmmu@12220000 {
+ compatible = "samsung,exynos-sysmmu";
+ interrupt-parent = <&combiner>;
+ reg = <0x12220000 0x1000>;
+ interrupts = <5 3>;
+ clock-names = "sysmmu", "master";
+ clocks = <&clock CLK_SMMU_FIMD1>, <&clock CLK_FIMD1>;
+ power-domains = <&pd_lcd1>;
+ #iommu-cells = <0>;
};
ppmu_lcd1: ppmu@12240000 {
@@ -354,6 +356,16 @@ ppmu_lcd1: ppmu@12240000 {
status = "disabled";
};
+ g2d: g2d@12800000 {
+ compatible = "samsung,s5pv210-g2d";
+ reg = <0x12800000 0x1000>;
+ interrupts = <GIC_SPI 89 IRQ_TYPE_LEVEL_HIGH>;
+ clocks = <&clock CLK_SCLK_FIMG2D>, <&clock CLK_G2D>;
+ clock-names = "sclk_fimg2d", "fimg2d";
+ power-domains = <&pd_lcd0>;
+ iommus = <&sysmmu_g2d>;
+ };
+
sysmmu_g2d: sysmmu@12a20000 {
compatible = "samsung,exynos-sysmmu";
reg = <0x12a20000 0x1000>;
@@ -364,17 +376,6 @@ sysmmu_g2d: sysmmu@12a20000 {
power-domains = <&pd_lcd0>;
#iommu-cells = <0>;
};
-
- sysmmu_fimd1: sysmmu@12220000 {
- compatible = "samsung,exynos-sysmmu";
- interrupt-parent = <&combiner>;
- reg = <0x12220000 0x1000>;
- interrupts = <5 3>;
- clock-names = "sysmmu", "master";
- clocks = <&clock CLK_SMMU_FIMD1>, <&clock CLK_FIMD1>;
- power-domains = <&pd_lcd1>;
- #iommu-cells = <0>;
- };
};
};
--
2.43.0
next prev parent reply other threads:[~2026-10-06 11:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-06 11:57 [PATCH v2 00/17] ARM: dts: samsung: cleanup Exynos 4210 dts'es Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 01/17] ARM: dts: samsung: exynos4: add or remove empty lines Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 02/17] ARM: dts: samsung: exynos4: order *-names properties Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 03/17] ARM: dts: samsung: exynos4: sort all properties Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 04/17] ARM: dts: samsung: exynos4-cpu-thermal: fix indentation and sort Henrik Grimler
2026-10-06 11:57 ` Henrik Grimler [this message]
2026-10-06 11:57 ` [PATCH v2 06/17] ARM: dts: samsung: exynos4210: add or remove empty lines Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 07/17] ARM: dts: samsung: exynos4210: sort all properties Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 08/17] ARM: dts: samsung: exynos4210: use operating-points-v2 Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 09/17] ARM: dts: samsung: exynos4210: align all multiline properties Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 10/17] ARM: dts: samsung: exynos4210-pinctrl: align all continued lines Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 11/17] ARM: dts: samsung: exynos4210-i9100: sort properties Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 12/17] ARM: dts: samsung: exynos4210-trats: " Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 13/17] ARM: dts: samsung: exynos4210-origen: " Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 14/17] ARM: dts: samsung: exynos4210-universal_c210: " Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 15/17] ARM: dts: samsung: exynos4210-smdkv310: " Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 16/17] ARM: dts: samsung: exynos4210-smdkv310: sort child nodes Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 17/17] ARM: dts: samsung: exynos4210-universal_c210: fix alignments Henrik Grimler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261006-exynos-arm-cleanup-v2-5-e8e86a3c8c1f@axis.com \
--to=henrik.grimler@axis.com \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=waqar.hameed@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®