mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Henrik Grimler <henrik.grimler@axis.com>
To: Rob Herring <robh@kernel.org>,
	Krzysztof Kozlowski <krzk+dt@kernel.org>,
	 Conor Dooley <conor+dt@kernel.org>,
	 Peter Griffin <peter.griffin@linaro.org>,
	 Alim Akhtar <alim.akhtar@samsung.com>
Cc: devicetree@vger.kernel.org, waqar.hameed@axis.com,
	 linux-arm-kernel@lists.infradead.org,
	linux-samsung-soc@vger.kernel.org,  linux-kernel@vger.kernel.org,
	Henrik Grimler <henrik.grimler@axis.com>
Subject: [PATCH v2 14/17] ARM: dts: samsung: exynos4210-universal_c210: sort properties
Date: Tue, 06 Oct 2026 13:57:28 +0200	[thread overview]
Message-ID: <20261006-exynos-arm-cleanup-v2-14-e8e86a3c8c1f@axis.com> (raw)
In-Reply-To: <20261006-exynos-arm-cleanup-v2-0-e8e86a3c8c1f@axis.com>

And add or delete newlines where applicable, and sort properties
according to the preferred style. Fixes warnings from dt-check-style
in strict mode like:

  samsung/exynos4210-universal_c210.dts:338: [property-order] property 'pinctrl-0' out of canonical order (should sort before 'samsung,i2c-max-bus-freq')
  samsung/exynos4210-universal_c210.dts:340: [required-blank-lines] "status" must be preceded by a blank line

Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
 .../boot/dts/samsung/exynos4210-universal_c210.dts | 91 ++++++++++++++--------
 1 file changed, 57 insertions(+), 34 deletions(-)

diff --git a/arch/arm/boot/dts/samsung/exynos4210-universal_c210.dts b/arch/arm/boot/dts/samsung/exynos4210-universal_c210.dts
index 744039068e8f..bcc636adba91 100644
--- a/arch/arm/boot/dts/samsung/exynos4210-universal_c210.dts
+++ b/arch/arm/boot/dts/samsung/exynos4210-universal_c210.dts
@@ -74,46 +74,46 @@ gpio-keys {
 
 		vol-up-key {
 			gpios = <&gpx2 0 GPIO_ACTIVE_LOW>;
-			linux,code = <115>;
 			label = "volume up";
 			debounce-interval = <1>;
+			linux,code = <115>;
 		};
 
 		vol-down-key {
 			gpios = <&gpx2 1 GPIO_ACTIVE_LOW>;
-			linux,code = <114>;
 			label = "volume down";
 			debounce-interval = <1>;
+			linux,code = <114>;
 		};
 
 		config-key {
 			gpios = <&gpx2 2 GPIO_ACTIVE_LOW>;
-			linux,code = <171>;
 			label = "config";
 			debounce-interval = <1>;
 			wakeup-source;
+			linux,code = <171>;
 		};
 
 		camera-key {
 			gpios = <&gpx2 3 GPIO_ACTIVE_LOW>;
-			linux,code = <212>;
 			label = "camera";
 			debounce-interval = <1>;
+			linux,code = <212>;
 		};
 
 		power-key {
 			gpios = <&gpx2 7 GPIO_ACTIVE_LOW>;
-			linux,code = <116>;
 			label = "power";
 			debounce-interval = <1>;
 			wakeup-source;
+			linux,code = <116>;
 		};
 
 		ok-key {
 			gpios = <&gpx3 5 GPIO_ACTIVE_LOW>;
-			linux,code = <352>;
 			label = "ok";
 			debounce-interval = <1>;
+			linux,code = <352>;
 		};
 	};
 
@@ -147,6 +147,7 @@ lcd@0 {
 			reset-delay = <10>;
 			panel-width-mm = <90>;
 			panel-height-mm = <154>;
+
 			display-timings {
 				timing {
 					clock-frequency = <23492370>;
@@ -164,6 +165,7 @@ timing {
 					pixelclk-active = <0>;
 				};
 			};
+
 			port {
 				lcd_ep: endpoint {
 					remote-endpoint = <&fimd_dpi_ep>;
@@ -185,12 +187,13 @@ hdmi_ddc: i2c-ddc {
 		compatible = "i2c-gpio";
 		sda-gpios = <&gpe4 2 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
 		scl-gpios = <&gpe4 3 (GPIO_ACTIVE_HIGH | GPIO_OPEN_DRAIN)>;
-		i2c-gpio,delay-us = <100>;
 		#address-cells = <1>;
 		#size-cells = <0>;
 
 		pinctrl-0 = <&i2c_ddc_bus>;
 		pinctrl-names = "default";
+		i2c-gpio,delay-us = <100>;
+
 		status = "okay";
 	};
 };
@@ -209,6 +212,7 @@ map0 {
 			/* Corresponds to 800MHz */
 			cooling-device = <&cpu0 2 2>;
 		};
+
 		map1 {
 			/* Corresponds to 200MHz */
 			cooling-device = <&cpu0 4 4>;
@@ -217,58 +221,67 @@ map1 {
 };
 
 &ehci {
-	status = "okay";
 	phys = <&exynos_usbphy 1>;
 	phy-names = "host";
+
+	status = "okay";
 };
 
 &exynos_usbphy {
-	status = "okay";
 	vbus-supply = <&safeout1_reg>;
+
+	status = "okay";
 };
 
 &fimc_0 {
-	status = "okay";
 	assigned-clocks = <&clock CLK_MOUT_FIMC0>,
 			  <&clock CLK_SCLK_FIMC0>;
 	assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
 	assigned-clock-rates = <0>, <160000000>;
+
+	status = "okay";
 };
 
 &fimc_1 {
-	status = "okay";
 	assigned-clocks = <&clock CLK_MOUT_FIMC1>,
 			  <&clock CLK_SCLK_FIMC1>;
 	assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
 	assigned-clock-rates = <0>, <160000000>;
+
+	status = "okay";
 };
 
 &fimc_2 {
-	status = "okay";
 	assigned-clocks = <&clock CLK_MOUT_FIMC2>,
 			  <&clock CLK_SCLK_FIMC2>;
 	assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
 	assigned-clock-rates = <0>, <160000000>;
+
+	status = "okay";
 };
 
 &fimc_3 {
-	status = "okay";
 	assigned-clocks = <&clock CLK_MOUT_FIMC3>,
 			  <&clock CLK_SCLK_FIMC3>;
 	assigned-clock-parents = <&clock CLK_SCLK_MPLL>;
 	assigned-clock-rates = <0>, <160000000>;
+
+	status = "okay";
 };
 
 &fimd {
 	pinctrl-0 = <&lcd_clk>, <&lcd_data24>;
 	pinctrl-names = "default";
-	status = "okay";
-	samsung,invert-vden;
-	samsung,invert-vclk;
 	#address-cells = <1>;
 	#size-cells = <0>;
+	samsung,invert-vden;
+	samsung,invert-vclk;
+
+	status = "okay";
+
 	port@3 {
 		reg = <3>;
+
 		fimd_dpi_ep: endpoint {
 			remote-endpoint = <&lcd_ep>;
 		};
@@ -277,18 +290,20 @@ fimd_dpi_ep: endpoint {
 
 &gpu {
 	mali-supply = <&buck2_reg>;
+
 	status = "okay";
 };
 
 &hdmi {
 	hpd-gpios = <&gpx3 7 GPIO_ACTIVE_HIGH>;
-	pinctrl-names = "default";
 	pinctrl-0 = <&hdmi_hpd>;
+	pinctrl-names = "default";
 	hdmi-en-supply = <&hdmi_en>;
 	vdd-supply = <&ldo3_reg>;
 	vdd_osc-supply = <&ldo4_reg>;
 	vdd_pll-supply = <&ldo3_reg>;
 	ddc = <&hdmi_ddc>;
+
 	status = "okay";
 };
 
@@ -296,15 +311,17 @@ &hsotg {
 	vusb_d-supply = <&ldo3_reg>;
 	vusb_a-supply = <&ldo8_reg>;
 	dr_mode = "peripheral";
+
 	status = "okay";
 };
 
 &i2c_3 {
+	pinctrl-0 = <&i2c3_bus>;
+	pinctrl-names = "default";
 	samsung,i2c-sda-delay = <100>;
 	samsung,i2c-slave-addr = <0x10>;
 	samsung,i2c-max-bus-freq = <100000>;
-	pinctrl-0 = <&i2c3_bus>;
-	pinctrl-names = "default";
+
 	status = "okay";
 
 	tsp@4a {
@@ -314,17 +331,24 @@ tsp@4a {
 };
 
 &i2c_5 {
+	pinctrl-0 = <&i2c5_bus>;
+	pinctrl-names = "default";
 	samsung,i2c-sda-delay = <100>;
 	samsung,i2c-slave-addr = <0x10>;
 	samsung,i2c-max-bus-freq = <100000>;
-	pinctrl-0 = <&i2c5_bus>;
-	pinctrl-names = "default";
+
 	status = "okay";
 
 	vdd_arm_reg: pmic@60 {
 		compatible = "maxim,max8952";
 		reg = <0x60>;
 
+		regulator-name = "VARM_1.2V_C210";
+		regulator-min-microvolt = <770000>;
+		regulator-max-microvolt = <1400000>;
+		regulator-always-on;
+		regulator-boot-on;
+
 		max8952,vid-gpios = <&gpx0 3 GPIO_ACTIVE_HIGH>,
 				    <&gpx0 4 GPIO_ACTIVE_HIGH>;
 		max8952,default-mode = <0>;
@@ -332,20 +356,14 @@ vdd_arm_reg: pmic@60 {
 						<1050000>, <950000>;
 		max8952,sync-freq = <0>;
 		max8952,ramp-speed = <0>;
-
-		regulator-name = "VARM_1.2V_C210";
-		regulator-min-microvolt = <770000>;
-		regulator-max-microvolt = <1400000>;
-		regulator-always-on;
-		regulator-boot-on;
 	};
 
 	pmic@66 {
 		compatible = "national,lp3974";
+		reg = <0x66>;
 		interrupts-extended = <&gpx0 7 0>, <&gpx2 7 0>;
-		pinctrl-names = "default";
 		pinctrl-0 = <&lp3974_irq>;
-		reg = <0x66>;
+		pinctrl-names = "default";
 
 		max8998,pmic-buck1-default-dvs-idx = <0>;
 		max8998,pmic-buck1-dvs-gpios = <&gpx0 5 GPIO_ACTIVE_HIGH>,
@@ -576,13 +594,15 @@ i2c_ddc_bus: i2c-ddc-bus-pins {
 
 &pwm {
 	compatible = "samsung,s5p6440-pwm";
+
 	status = "okay";
 };
 
 &rtc {
-	status = "okay";
 	clocks = <&clock CLK_RTC>, <&pmic_ap_clk>;
 	clock-names = "rtc", "rtc_src";
+
+	status = "okay";
 };
 
 &sdhci_0 {
@@ -591,6 +611,7 @@ &sdhci_0 {
 	pinctrl-0 = <&sd0_clk &sd0_cmd &sd0_bus8>;
 	pinctrl-names = "default";
 	vmmc-supply = <&vemmc_reg>;
+
 	status = "okay";
 };
 
@@ -600,12 +621,11 @@ &sdhci_2 {
 	pinctrl-names = "default";
 	vmmc-supply = <&ldo5_reg>;
 	cd-gpios = <&gpx3 4 GPIO_ACTIVE_LOW>;
+
 	status = "okay";
 };
 
 &sdhci_3 {
-	status = "okay";
-
 	#address-cells = <1>;
 	#size-cells = <0>;
 
@@ -615,8 +635,10 @@ &sdhci_3 {
 	mmc-pwrseq = <&wlan_pwrseq>;
 	vmmc-supply = <&ldo5_reg>;
 
-	pinctrl-names = "default";
 	pinctrl-0 = <&sd3_clk>, <&sd3_cmd>, <&sd3_bus4>;
+	pinctrl-names = "default";
+
+	status = "okay";
 
 	brcmf: wifi@1 {
 		compatible = "brcm,bcm4330-fmac", "brcm,bcm4329-fmac";
@@ -628,7 +650,6 @@ brcmf: wifi@1 {
 };
 
 &serial_0 {
-	status = "okay";
 	/delete-property/dmas;
 	/delete-property/dma-names;
 	pinctrl-0 = <&uart0_data &uart0_fctl>;
@@ -636,6 +657,8 @@ &serial_0 {
 
 	uart-has-rtscts;
 
+	status = "okay";
+
 	bluetooth {
 		compatible = "brcm,bcm4330-bt";
 

-- 
2.43.0


  parent reply	other threads:[~2026-10-06 11:58 UTC|newest]

Thread overview: 18+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-06 11:57 [PATCH v2 00/17] ARM: dts: samsung: cleanup Exynos 4210 dts'es Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 01/17] ARM: dts: samsung: exynos4: add or remove empty lines Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 02/17] ARM: dts: samsung: exynos4: order *-names properties Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 03/17] ARM: dts: samsung: exynos4: sort all properties Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 04/17] ARM: dts: samsung: exynos4-cpu-thermal: fix indentation and sort Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 05/17] ARM: dts: samsung: exynos4210: sort nodes by address Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 06/17] ARM: dts: samsung: exynos4210: add or remove empty lines Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 07/17] ARM: dts: samsung: exynos4210: sort all properties Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 08/17] ARM: dts: samsung: exynos4210: use operating-points-v2 Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 09/17] ARM: dts: samsung: exynos4210: align all multiline properties Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 10/17] ARM: dts: samsung: exynos4210-pinctrl: align all continued lines Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 11/17] ARM: dts: samsung: exynos4210-i9100: sort properties Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 12/17] ARM: dts: samsung: exynos4210-trats: " Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 13/17] ARM: dts: samsung: exynos4210-origen: " Henrik Grimler
2026-10-06 11:57 ` Henrik Grimler [this message]
2026-10-06 11:57 ` [PATCH v2 15/17] ARM: dts: samsung: exynos4210-smdkv310: " Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 16/17] ARM: dts: samsung: exynos4210-smdkv310: sort child nodes Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 17/17] ARM: dts: samsung: exynos4210-universal_c210: fix alignments Henrik Grimler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261006-exynos-arm-cleanup-v2-14-e8e86a3c8c1f@axis.com \
    --to=henrik.grimler@axis.com \
    --cc=alim.akhtar@samsung.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=krzk+dt@kernel.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-samsung-soc@vger.kernel.org \
    --cc=peter.griffin@linaro.org \
    --cc=robh@kernel.org \
    --cc=waqar.hameed@axis.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®