From: Henrik Grimler <henrik.grimler@axis.com>
To: Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Peter Griffin <peter.griffin@linaro.org>,
Alim Akhtar <alim.akhtar@samsung.com>
Cc: devicetree@vger.kernel.org, waqar.hameed@axis.com,
linux-arm-kernel@lists.infradead.org,
linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org,
Henrik Grimler <henrik.grimler@axis.com>
Subject: [PATCH v2 02/17] ARM: dts: samsung: exynos4: order *-names properties
Date: Tue, 06 Oct 2026 13:57:16 +0200 [thread overview]
Message-ID: <20261006-exynos-arm-cleanup-v2-2-e8e86a3c8c1f@axis.com> (raw)
In-Reply-To: <20261006-exynos-arm-cleanup-v2-0-e8e86a3c8c1f@axis.com>
pinctrl-names, clock-names and interrupt-names should be after
pinctrl-*, clocks and interrupts respectively. Re-order all of them to
make the files consistent.
dt-check-style in strict mode reports the issues like:
samsung/exynos4.dtsi:745: [property-order] property 'interrupt-names' must be placed after 'interrupts'
samsung/exynos4.dtsi:788: [property-order] property 'clock-names' must be placed after 'clocks'
samsung/exynos4.dtsi:810: [property-order] property 'pinctrl-names' must be placed after 'pinctrl-0'
Signed-off-by: Henrik Grimler <henrik.grimler@axis.com>
---
arch/arm/boot/dts/samsung/exynos4.dtsi | 50 +++++++++++++++++-----------------
1 file changed, 25 insertions(+), 25 deletions(-)
diff --git a/arch/arm/boot/dts/samsung/exynos4.dtsi b/arch/arm/boot/dts/samsung/exynos4.dtsi
index c38489a05e15..f69b01423ae0 100644
--- a/arch/arm/boot/dts/samsung/exynos4.dtsi
+++ b/arch/arm/boot/dts/samsung/exynos4.dtsi
@@ -524,8 +524,8 @@ i2c_0: i2c@13860000 {
interrupts = <GIC_SPI 58 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_I2C0>;
clock-names = "i2c";
- pinctrl-names = "default";
pinctrl-0 = <&i2c0_bus>;
+ pinctrl-names = "default";
status = "disabled";
};
@@ -538,8 +538,8 @@ i2c_1: i2c@13870000 {
interrupts = <GIC_SPI 59 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_I2C1>;
clock-names = "i2c";
- pinctrl-names = "default";
pinctrl-0 = <&i2c1_bus>;
+ pinctrl-names = "default";
status = "disabled";
};
@@ -552,8 +552,8 @@ i2c_2: i2c@13880000 {
interrupts = <GIC_SPI 60 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_I2C2>;
clock-names = "i2c";
- pinctrl-names = "default";
pinctrl-0 = <&i2c2_bus>;
+ pinctrl-names = "default";
status = "disabled";
};
@@ -566,8 +566,8 @@ i2c_3: i2c@13890000 {
interrupts = <GIC_SPI 61 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_I2C3>;
clock-names = "i2c";
- pinctrl-names = "default";
pinctrl-0 = <&i2c3_bus>;
+ pinctrl-names = "default";
status = "disabled";
};
@@ -580,8 +580,8 @@ i2c_4: i2c@138a0000 {
interrupts = <GIC_SPI 62 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_I2C4>;
clock-names = "i2c";
- pinctrl-names = "default";
pinctrl-0 = <&i2c4_bus>;
+ pinctrl-names = "default";
status = "disabled";
};
@@ -594,8 +594,8 @@ i2c_5: i2c@138b0000 {
interrupts = <GIC_SPI 63 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_I2C5>;
clock-names = "i2c";
- pinctrl-names = "default";
pinctrl-0 = <&i2c5_bus>;
+ pinctrl-names = "default";
status = "disabled";
};
@@ -608,8 +608,8 @@ i2c_6: i2c@138c0000 {
interrupts = <GIC_SPI 64 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_I2C6>;
clock-names = "i2c";
- pinctrl-names = "default";
pinctrl-0 = <&i2c6_bus>;
+ pinctrl-names = "default";
status = "disabled";
};
@@ -622,8 +622,8 @@ i2c_7: i2c@138d0000 {
interrupts = <GIC_SPI 65 IRQ_TYPE_LEVEL_HIGH>;
clocks = <&clock CLK_I2C7>;
clock-names = "i2c";
- pinctrl-names = "default";
pinctrl-0 = <&i2c7_bus>;
+ pinctrl-names = "default";
status = "disabled";
};
@@ -655,8 +655,8 @@ spi_0: spi@13920000 {
#size-cells = <0>;
clocks = <&clock CLK_SPI0>, <&clock CLK_SCLK_SPI0>;
clock-names = "spi", "spi_busclk0";
- pinctrl-names = "default";
pinctrl-0 = <&spi0_bus>;
+ pinctrl-names = "default";
fifo-depth = <256>;
status = "disabled";
@@ -672,8 +672,8 @@ spi_1: spi@13930000 {
#size-cells = <0>;
clocks = <&clock CLK_SPI1>, <&clock CLK_SCLK_SPI1>;
clock-names = "spi", "spi_busclk0";
- pinctrl-names = "default";
pinctrl-0 = <&spi1_bus>;
+ pinctrl-names = "default";
fifo-depth = <64>;
status = "disabled";
@@ -689,8 +689,8 @@ spi_2: spi@13940000 {
#size-cells = <0>;
clocks = <&clock CLK_SPI2>, <&clock CLK_SCLK_SPI2>;
clock-names = "spi", "spi_busclk0";
- pinctrl-names = "default";
pinctrl-0 = <&spi2_bus>;
+ pinctrl-names = "default";
fifo-depth = <64>;
status = "disabled";
@@ -742,8 +742,8 @@ fimd: fimd@11c00000 {
compatible = "samsung,exynos4210-fimd";
interrupt-parent = <&combiner>;
reg = <0x11c00000 0x20000>;
- interrupt-names = "fifo", "vsync", "lcd_sys";
interrupts = <11 0>, <11 1>, <11 2>;
+ interrupt-names = "fifo", "vsync", "lcd_sys";
clocks = <&clock CLK_SCLK_FIMD0>, <&clock CLK_FIMD0>;
clock-names = "sclk_fimd", "fimd";
power-domains = <&pd_lcd0>;
@@ -785,12 +785,12 @@ hdmi: hdmi@12d00000 {
compatible = "samsung,exynos4210-hdmi";
reg = <0x12d00000 0x70000>;
interrupts = <GIC_SPI 92 IRQ_TYPE_LEVEL_HIGH>;
- clock-names = "hdmi", "sclk_hdmi", "sclk_pixel",
- "sclk_hdmiphy", "mout_hdmi";
clocks = <&clock CLK_HDMI>, <&clock CLK_SCLK_HDMI>,
<&clock CLK_SCLK_PIXEL>,
<&clock CLK_SCLK_HDMIPHY>,
<&clock CLK_MOUT_HDMI>;
+ clock-names = "hdmi", "sclk_hdmi", "sclk_pixel",
+ "sclk_hdmiphy", "mout_hdmi";
phy = <&hdmi_i2c_phy>;
power-domains = <&pd_tv>;
samsung,syscon-phandle = <&pmu_system_controller>;
@@ -807,8 +807,8 @@ hdmicec: cec@100b0000 {
clock-names = "hdmicec";
samsung,syscon-phandle = <&pmu_system_controller>;
hdmi-phandle = <&hdmi>;
- pinctrl-names = "default";
pinctrl-0 = <&hdmi_cec>;
+ pinctrl-names = "default";
status = "disabled";
};
@@ -943,8 +943,8 @@ sysmmu_mfc_l: sysmmu@13620000 {
reg = <0x13620000 0x1000>;
interrupt-parent = <&combiner>;
interrupts = <5 5>;
- clock-names = "sysmmu", "master";
clocks = <&clock CLK_SMMU_MFCL>, <&clock CLK_MFC>;
+ clock-names = "sysmmu", "master";
power-domains = <&pd_mfc>;
#iommu-cells = <0>;
};
@@ -954,8 +954,8 @@ sysmmu_mfc_r: sysmmu@13630000 {
reg = <0x13630000 0x1000>;
interrupt-parent = <&combiner>;
interrupts = <5 6>;
- clock-names = "sysmmu", "master";
clocks = <&clock CLK_SMMU_MFCR>, <&clock CLK_MFC>;
+ clock-names = "sysmmu", "master";
power-domains = <&pd_mfc>;
#iommu-cells = <0>;
};
@@ -965,8 +965,8 @@ sysmmu_tv: sysmmu@12e20000 {
reg = <0x12e20000 0x1000>;
interrupt-parent = <&combiner>;
interrupts = <5 4>;
- clock-names = "sysmmu", "master";
clocks = <&clock CLK_SMMU_TV>, <&clock CLK_MIXER>;
+ clock-names = "sysmmu", "master";
power-domains = <&pd_tv>;
#iommu-cells = <0>;
};
@@ -976,8 +976,8 @@ sysmmu_fimc0: sysmmu@11a20000 {
reg = <0x11a20000 0x1000>;
interrupt-parent = <&combiner>;
interrupts = <4 2>;
- clock-names = "sysmmu", "master";
clocks = <&clock CLK_SMMU_FIMC0>, <&clock CLK_FIMC0>;
+ clock-names = "sysmmu", "master";
power-domains = <&pd_cam>;
#iommu-cells = <0>;
};
@@ -987,8 +987,8 @@ sysmmu_fimc1: sysmmu@11a30000 {
reg = <0x11a30000 0x1000>;
interrupt-parent = <&combiner>;
interrupts = <4 3>;
- clock-names = "sysmmu", "master";
clocks = <&clock CLK_SMMU_FIMC1>, <&clock CLK_FIMC1>;
+ clock-names = "sysmmu", "master";
power-domains = <&pd_cam>;
#iommu-cells = <0>;
};
@@ -998,8 +998,8 @@ sysmmu_fimc2: sysmmu@11a40000 {
reg = <0x11a40000 0x1000>;
interrupt-parent = <&combiner>;
interrupts = <4 4>;
- clock-names = "sysmmu", "master";
clocks = <&clock CLK_SMMU_FIMC2>, <&clock CLK_FIMC2>;
+ clock-names = "sysmmu", "master";
power-domains = <&pd_cam>;
#iommu-cells = <0>;
};
@@ -1009,8 +1009,8 @@ sysmmu_fimc3: sysmmu@11a50000 {
reg = <0x11a50000 0x1000>;
interrupt-parent = <&combiner>;
interrupts = <4 5>;
- clock-names = "sysmmu", "master";
clocks = <&clock CLK_SMMU_FIMC3>, <&clock CLK_FIMC3>;
+ clock-names = "sysmmu", "master";
power-domains = <&pd_cam>;
#iommu-cells = <0>;
};
@@ -1020,8 +1020,8 @@ sysmmu_jpeg: sysmmu@11a60000 {
reg = <0x11a60000 0x1000>;
interrupt-parent = <&combiner>;
interrupts = <4 6>;
- clock-names = "sysmmu", "master";
clocks = <&clock CLK_SMMU_JPEG>, <&clock CLK_JPEG>;
+ clock-names = "sysmmu", "master";
power-domains = <&pd_cam>;
#iommu-cells = <0>;
};
@@ -1031,9 +1031,9 @@ sysmmu_rotator: sysmmu@12a30000 {
reg = <0x12a30000 0x1000>;
interrupt-parent = <&combiner>;
interrupts = <5 0>;
- clock-names = "sysmmu", "master";
clocks = <&clock CLK_SMMU_ROTATOR>,
<&clock CLK_ROTATOR>;
+ clock-names = "sysmmu", "master";
#iommu-cells = <0>;
};
@@ -1042,8 +1042,8 @@ sysmmu_fimd0: sysmmu@11e20000 {
reg = <0x11e20000 0x1000>;
interrupt-parent = <&combiner>;
interrupts = <5 2>;
- clock-names = "sysmmu", "master";
clocks = <&clock CLK_SMMU_FIMD0>, <&clock CLK_FIMD0>;
+ clock-names = "sysmmu", "master";
power-domains = <&pd_lcd0>;
#iommu-cells = <0>;
};
--
2.43.0
next prev parent reply other threads:[~2026-10-06 11:58 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-06 11:57 [PATCH v2 00/17] ARM: dts: samsung: cleanup Exynos 4210 dts'es Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 01/17] ARM: dts: samsung: exynos4: add or remove empty lines Henrik Grimler
2026-10-06 11:57 ` Henrik Grimler [this message]
2026-10-06 11:57 ` [PATCH v2 03/17] ARM: dts: samsung: exynos4: sort all properties Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 04/17] ARM: dts: samsung: exynos4-cpu-thermal: fix indentation and sort Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 05/17] ARM: dts: samsung: exynos4210: sort nodes by address Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 06/17] ARM: dts: samsung: exynos4210: add or remove empty lines Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 07/17] ARM: dts: samsung: exynos4210: sort all properties Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 08/17] ARM: dts: samsung: exynos4210: use operating-points-v2 Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 09/17] ARM: dts: samsung: exynos4210: align all multiline properties Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 10/17] ARM: dts: samsung: exynos4210-pinctrl: align all continued lines Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 11/17] ARM: dts: samsung: exynos4210-i9100: sort properties Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 12/17] ARM: dts: samsung: exynos4210-trats: " Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 13/17] ARM: dts: samsung: exynos4210-origen: " Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 14/17] ARM: dts: samsung: exynos4210-universal_c210: " Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 15/17] ARM: dts: samsung: exynos4210-smdkv310: " Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 16/17] ARM: dts: samsung: exynos4210-smdkv310: sort child nodes Henrik Grimler
2026-10-06 11:57 ` [PATCH v2 17/17] ARM: dts: samsung: exynos4210-universal_c210: fix alignments Henrik Grimler
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261006-exynos-arm-cleanup-v2-2-e8e86a3c8c1f@axis.com \
--to=henrik.grimler@axis.com \
--cc=alim.akhtar@samsung.com \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=peter.griffin@linaro.org \
--cc=robh@kernel.org \
--cc=waqar.hameed@axis.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®