mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: imx6ull-dhcor-maveo-box: Remove unused SPI device
@ 2026-10-21 13:44 Christoph Niedermaier
  2026-10-21 13:44 ` [PATCH 2/2] ARM: dts: imx6ull-dhcor-maveo-box: Correct PCB number Christoph Niedermaier
  2026-10-21 17:19 ` [PATCH 1/2] ARM: dts: imx6ull-dhcor-maveo-box: Remove unused SPI device Marek Vasut
  0 siblings, 2 replies; 5+ messages in thread
From: Christoph Niedermaier @ 2026-10-21 13:44 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Christoph Niedermaier, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Frank Li, Sascha Hauer, Pengutronix Kernel Team,
	Fabio Estevam, Marek Vasut, devicetree, imx, kernel,
	linux-kernel

On the maveo box, the SPI pins are connected to connector X10,
but no device is connected. The device "dhcom-board" was used
only to test the hardware, but was not removed afterward. So
remove this device to accurately represent the current hardware
configuration here.

Fixes: 145e2732a5e9 ("ARM: dts: imx6ull-dhcor: Add Marantec maveo box")
Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
---
Cc: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Frank Li <Frank.Li@nxp.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Marek Vasut <marex@nabladev.com>
Cc: devicetree@vger.kernel.org
Cc: imx@lists.linux.dev
Cc: kernel@dh-electronics.com
Cc: linux-kernel@vger.kernel.org
---
 arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
index 047f7b2d8526..eb0b91040110 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
@@ -60,14 +60,6 @@ &ecspi4 {
 	pinctrl-0 = <&pinctrl_ecspi4>;
 	pinctrl-names = "default";
 	status = "okay";
-
-	spidev@0 {
-		compatible = "dh,dhcom-board";
-		reg = <0>;
-		spi-cpha;
-		spi-cpol;
-		spi-max-frequency = <54000000>;
-	};
 };
 
 &gpio1 {
-- 
2.30.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* [PATCH 2/2] ARM: dts: imx6ull-dhcor-maveo-box: Correct PCB number
  2026-10-21 13:44 [PATCH 1/2] ARM: dts: imx6ull-dhcor-maveo-box: Remove unused SPI device Christoph Niedermaier
@ 2026-10-21 13:44 ` Christoph Niedermaier
  2026-10-21 17:20   ` Marek Vasut
  2026-10-21 17:19 ` [PATCH 1/2] ARM: dts: imx6ull-dhcor-maveo-box: Remove unused SPI device Marek Vasut
  1 sibling, 1 reply; 5+ messages in thread
From: Christoph Niedermaier @ 2026-10-21 13:44 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Christoph Niedermaier, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Frank Li, Sascha Hauer, Pengutronix Kernel Team,
	Fabio Estevam, Marek Vasut, devicetree, imx, kernel,
	linux-kernel

The PCB number of the maveo box isn't 525. Change the
number to the correct number, 625.

Fixes: 145e2732a5e9 ("ARM: dts: imx6ull-dhcor: Add Marantec maveo box")
Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
---
Cc: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Frank Li <Frank.Li@nxp.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Marek Vasut <marex@nabladev.com>
Cc: devicetree@vger.kernel.org
Cc: imx@lists.linux.dev
Cc: kernel@dh-electronics.com
Cc: linux-kernel@vger.kernel.org
---
 arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
index eb0b91040110..bb82d97f9d84 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
@@ -6,7 +6,7 @@
  * DHCOM iMX6ULL variant:
  * DHCR-iMX6ULL-C080-R051-SPI-WBT-I-01LG
  * DHCOR PCB number: 578-200 or newer
- * maveo box PCB number: 525-200 or newer
+ * maveo box PCB number: 625-200 or newer
  */
 
 /dts-v1/;
-- 
2.30.2


^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] ARM: dts: imx6ull-dhcor-maveo-box: Remove unused SPI device
  2026-10-21 13:44 [PATCH 1/2] ARM: dts: imx6ull-dhcor-maveo-box: Remove unused SPI device Christoph Niedermaier
  2026-10-21 13:44 ` [PATCH 2/2] ARM: dts: imx6ull-dhcor-maveo-box: Correct PCB number Christoph Niedermaier
@ 2026-10-21 17:19 ` Marek Vasut
  2026-10-21 18:37   ` Francesco Dolcini
  1 sibling, 1 reply; 5+ messages in thread
From: Marek Vasut @ 2026-10-21 17:19 UTC (permalink / raw)
  To: Christoph Niedermaier, linux-arm-kernel
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, devicetree,
	imx, kernel, linux-kernel

On 10/21/26 3:44 PM, Christoph Niedermaier wrote:
> On the maveo box, the SPI pins are connected to connector X10,
> but no device is connected. The device "dhcom-board" was used
> only to test the hardware, but was not removed afterward. So
> remove this device to accurately represent the current hardware
> configuration here.
> 
> Fixes: 145e2732a5e9 ("ARM: dts: imx6ull-dhcor: Add Marantec maveo box")
> Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
> ---
> Cc: Rob Herring <robh@kernel.org>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Frank Li <Frank.Li@nxp.com>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Marek Vasut <marex@nabladev.com>
> Cc: devicetree@vger.kernel.org
> Cc: imx@lists.linux.dev
> Cc: kernel@dh-electronics.com
> Cc: linux-kernel@vger.kernel.org
> ---
>   arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts | 8 --------
>   1 file changed, 8 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
> index 047f7b2d8526..eb0b91040110 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
> +++ b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
> @@ -60,14 +60,6 @@ &ecspi4 {
>   	pinctrl-0 = <&pinctrl_ecspi4>;
>   	pinctrl-names = "default";
>   	status = "okay";

Drop "status = "okay"" too , since this controller will be unused ?

[...]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 2/2] ARM: dts: imx6ull-dhcor-maveo-box: Correct PCB number
  2026-10-21 13:44 ` [PATCH 2/2] ARM: dts: imx6ull-dhcor-maveo-box: Correct PCB number Christoph Niedermaier
@ 2026-10-21 17:20   ` Marek Vasut
  0 siblings, 0 replies; 5+ messages in thread
From: Marek Vasut @ 2026-10-21 17:20 UTC (permalink / raw)
  To: Christoph Niedermaier, linux-arm-kernel
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, devicetree,
	imx, kernel, linux-kernel

On 10/21/26 3:44 PM, Christoph Niedermaier wrote:
> The PCB number of the maveo box isn't 525. Change the
> number to the correct number, 625.
> 
> Fixes: 145e2732a5e9 ("ARM: dts: imx6ull-dhcor: Add Marantec maveo box")
> Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
> ---
> Cc: Rob Herring <robh@kernel.org>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Frank Li <Frank.Li@nxp.com>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Marek Vasut <marex@nabladev.com>
> Cc: devicetree@vger.kernel.org
> Cc: imx@lists.linux.dev
> Cc: kernel@dh-electronics.com
> Cc: linux-kernel@vger.kernel.org
> ---
>   arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
> index eb0b91040110..bb82d97f9d84 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
> +++ b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
> @@ -6,7 +6,7 @@
>    * DHCOM iMX6ULL variant:
>    * DHCR-iMX6ULL-C080-R051-SPI-WBT-I-01LG
>    * DHCOR PCB number: 578-200 or newer
> - * maveo box PCB number: 525-200 or newer
> + * maveo box PCB number: 625-200 or newer
Is the rev.200 correct , or is the base board still rev.100 ?

^ permalink raw reply	[flat|nested] 5+ messages in thread

* Re: [PATCH 1/2] ARM: dts: imx6ull-dhcor-maveo-box: Remove unused SPI device
  2026-10-21 17:19 ` [PATCH 1/2] ARM: dts: imx6ull-dhcor-maveo-box: Remove unused SPI device Marek Vasut
@ 2026-10-21 18:37   ` Francesco Dolcini
  0 siblings, 0 replies; 5+ messages in thread
From: Francesco Dolcini @ 2026-10-21 18:37 UTC (permalink / raw)
  To: Marek Vasut
  Cc: Christoph Niedermaier, linux-arm-kernel, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Frank Li, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, devicetree, imx, kernel,
	linux-kernel

On Wed, Oct 21, 2026 at 07:19:30PM +0200, Marek Vasut wrote:
> On 10/21/26 3:44 PM, Christoph Niedermaier wrote:
> > On the maveo box, the SPI pins are connected to connector X10,
> > but no device is connected. The device "dhcom-board" was used
> > only to test the hardware, but was not removed afterward. So
> > remove this device to accurately represent the current hardware
> > configuration here.
> > 
> > Fixes: 145e2732a5e9 ("ARM: dts: imx6ull-dhcor: Add Marantec maveo box")
> > Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
> > ---
> > Cc: Rob Herring <robh@kernel.org>
> > Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> > Cc: Conor Dooley <conor+dt@kernel.org>
> > Cc: Frank Li <Frank.Li@nxp.com>
> > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> > Cc: Fabio Estevam <festevam@gmail.com>
> > Cc: Marek Vasut <marex@nabladev.com>
> > Cc: devicetree@vger.kernel.org
> > Cc: imx@lists.linux.dev
> > Cc: kernel@dh-electronics.com
> > Cc: linux-kernel@vger.kernel.org
> > ---
> >   arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts | 8 --------
> >   1 file changed, 8 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
> > index 047f7b2d8526..eb0b91040110 100644
> > --- a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
> > +++ b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
> > @@ -60,14 +60,6 @@ &ecspi4 {
> >   	pinctrl-0 = <&pinctrl_ecspi4>;
> >   	pinctrl-names = "default";
> >   	status = "okay";
> 
> Drop "status = "okay"" too , since this controller will be unused ?

you can instantiate a new device on the SPI bus from userspace. up to
you, but if I was a user I would appreciate to have it enabled.

Francesco


^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2026-10-21 18:37 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-21 13:44 [PATCH 1/2] ARM: dts: imx6ull-dhcor-maveo-box: Remove unused SPI device Christoph Niedermaier
2026-10-21 13:44 ` [PATCH 2/2] ARM: dts: imx6ull-dhcor-maveo-box: Correct PCB number Christoph Niedermaier
2026-10-21 17:20   ` Marek Vasut
2026-10-21 17:19 ` [PATCH 1/2] ARM: dts: imx6ull-dhcor-maveo-box: Remove unused SPI device Marek Vasut
2026-10-21 18:37   ` Francesco Dolcini

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®