mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
* [PATCH 1/2] ARM: dts: imx6ull-dhcor-maveo-box: Remove unused SPI device
@ 2026-10-21 13:44 Christoph Niedermaier
  2026-10-21 13:44 ` [PATCH 2/2] ARM: dts: imx6ull-dhcor-maveo-box: Correct PCB number Christoph Niedermaier
  2026-10-21 17:19 ` [PATCH 1/2] ARM: dts: imx6ull-dhcor-maveo-box: Remove unused SPI device Marek Vasut
  0 siblings, 2 replies; 12+ messages in thread
From: Christoph Niedermaier @ 2026-10-21 13:44 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Christoph Niedermaier, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Frank Li, Sascha Hauer, Pengutronix Kernel Team,
	Fabio Estevam, Marek Vasut, devicetree, imx, kernel,
	linux-kernel

On the maveo box, the SPI pins are connected to connector X10,
but no device is connected. The device "dhcom-board" was used
only to test the hardware, but was not removed afterward. So
remove this device to accurately represent the current hardware
configuration here.

Fixes: 145e2732a5e9 ("ARM: dts: imx6ull-dhcor: Add Marantec maveo box")
Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
---
Cc: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Frank Li <Frank.Li@nxp.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Marek Vasut <marex@nabladev.com>
Cc: devicetree@vger.kernel.org
Cc: imx@lists.linux.dev
Cc: kernel@dh-electronics.com
Cc: linux-kernel@vger.kernel.org
---
 arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts | 8 --------
 1 file changed, 8 deletions(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
index 047f7b2d8526..eb0b91040110 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
@@ -60,14 +60,6 @@ &ecspi4 {
 	pinctrl-0 = <&pinctrl_ecspi4>;
 	pinctrl-names = "default";
 	status = "okay";
-
-	spidev@0 {
-		compatible = "dh,dhcom-board";
-		reg = <0>;
-		spi-cpha;
-		spi-cpol;
-		spi-max-frequency = <54000000>;
-	};
 };
 
 &gpio1 {
-- 
2.30.2


^ permalink raw reply	[flat|nested] 12+ messages in thread

* [PATCH 2/2] ARM: dts: imx6ull-dhcor-maveo-box: Correct PCB number
  2026-10-21 13:44 [PATCH 1/2] ARM: dts: imx6ull-dhcor-maveo-box: Remove unused SPI device Christoph Niedermaier
@ 2026-10-21 13:44 ` Christoph Niedermaier
  2026-10-21 17:20   ` Marek Vasut
  2026-10-21 17:19 ` [PATCH 1/2] ARM: dts: imx6ull-dhcor-maveo-box: Remove unused SPI device Marek Vasut
  1 sibling, 1 reply; 12+ messages in thread
From: Christoph Niedermaier @ 2026-10-21 13:44 UTC (permalink / raw)
  To: linux-arm-kernel
  Cc: Christoph Niedermaier, Rob Herring, Krzysztof Kozlowski,
	Conor Dooley, Frank Li, Sascha Hauer, Pengutronix Kernel Team,
	Fabio Estevam, Marek Vasut, devicetree, imx, kernel,
	linux-kernel

The PCB number of the maveo box isn't 525. Change the
number to the correct number, 625.

Fixes: 145e2732a5e9 ("ARM: dts: imx6ull-dhcor: Add Marantec maveo box")
Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
---
Cc: Rob Herring <robh@kernel.org>
Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
Cc: Conor Dooley <conor+dt@kernel.org>
Cc: Frank Li <Frank.Li@nxp.com>
Cc: Sascha Hauer <s.hauer@pengutronix.de>
Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
Cc: Fabio Estevam <festevam@gmail.com>
Cc: Marek Vasut <marex@nabladev.com>
Cc: devicetree@vger.kernel.org
Cc: imx@lists.linux.dev
Cc: kernel@dh-electronics.com
Cc: linux-kernel@vger.kernel.org
---
 arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
index eb0b91040110..bb82d97f9d84 100644
--- a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
+++ b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
@@ -6,7 +6,7 @@
  * DHCOM iMX6ULL variant:
  * DHCR-iMX6ULL-C080-R051-SPI-WBT-I-01LG
  * DHCOR PCB number: 578-200 or newer
- * maveo box PCB number: 525-200 or newer
+ * maveo box PCB number: 625-200 or newer
  */
 
 /dts-v1/;
-- 
2.30.2


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/2] ARM: dts: imx6ull-dhcor-maveo-box: Remove unused SPI device
  2026-10-21 13:44 [PATCH 1/2] ARM: dts: imx6ull-dhcor-maveo-box: Remove unused SPI device Christoph Niedermaier
  2026-10-21 13:44 ` [PATCH 2/2] ARM: dts: imx6ull-dhcor-maveo-box: Correct PCB number Christoph Niedermaier
@ 2026-10-21 17:19 ` Marek Vasut
  2026-10-21 18:37   ` Francesco Dolcini
  1 sibling, 1 reply; 12+ messages in thread
From: Marek Vasut @ 2026-10-21 17:19 UTC (permalink / raw)
  To: Christoph Niedermaier, linux-arm-kernel
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, devicetree,
	imx, kernel, linux-kernel

On 10/21/26 3:44 PM, Christoph Niedermaier wrote:
> On the maveo box, the SPI pins are connected to connector X10,
> but no device is connected. The device "dhcom-board" was used
> only to test the hardware, but was not removed afterward. So
> remove this device to accurately represent the current hardware
> configuration here.
> 
> Fixes: 145e2732a5e9 ("ARM: dts: imx6ull-dhcor: Add Marantec maveo box")
> Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
> ---
> Cc: Rob Herring <robh@kernel.org>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Frank Li <Frank.Li@nxp.com>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Marek Vasut <marex@nabladev.com>
> Cc: devicetree@vger.kernel.org
> Cc: imx@lists.linux.dev
> Cc: kernel@dh-electronics.com
> Cc: linux-kernel@vger.kernel.org
> ---
>   arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts | 8 --------
>   1 file changed, 8 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
> index 047f7b2d8526..eb0b91040110 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
> +++ b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
> @@ -60,14 +60,6 @@ &ecspi4 {
>   	pinctrl-0 = <&pinctrl_ecspi4>;
>   	pinctrl-names = "default";
>   	status = "okay";

Drop "status = "okay"" too , since this controller will be unused ?

[...]

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2/2] ARM: dts: imx6ull-dhcor-maveo-box: Correct PCB number
  2026-10-21 13:44 ` [PATCH 2/2] ARM: dts: imx6ull-dhcor-maveo-box: Correct PCB number Christoph Niedermaier
@ 2026-10-21 17:20   ` Marek Vasut
  2026-10-22  8:59     ` Christoph Niedermaier
  0 siblings, 1 reply; 12+ messages in thread
From: Marek Vasut @ 2026-10-21 17:20 UTC (permalink / raw)
  To: Christoph Niedermaier, linux-arm-kernel
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, devicetree,
	imx, kernel, linux-kernel

On 10/21/26 3:44 PM, Christoph Niedermaier wrote:
> The PCB number of the maveo box isn't 525. Change the
> number to the correct number, 625.
> 
> Fixes: 145e2732a5e9 ("ARM: dts: imx6ull-dhcor: Add Marantec maveo box")
> Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
> ---
> Cc: Rob Herring <robh@kernel.org>
> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> Cc: Conor Dooley <conor+dt@kernel.org>
> Cc: Frank Li <Frank.Li@nxp.com>
> Cc: Sascha Hauer <s.hauer@pengutronix.de>
> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> Cc: Fabio Estevam <festevam@gmail.com>
> Cc: Marek Vasut <marex@nabladev.com>
> Cc: devicetree@vger.kernel.org
> Cc: imx@lists.linux.dev
> Cc: kernel@dh-electronics.com
> Cc: linux-kernel@vger.kernel.org
> ---
>   arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts | 2 +-
>   1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
> index eb0b91040110..bb82d97f9d84 100644
> --- a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
> +++ b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
> @@ -6,7 +6,7 @@
>    * DHCOM iMX6ULL variant:
>    * DHCR-iMX6ULL-C080-R051-SPI-WBT-I-01LG
>    * DHCOR PCB number: 578-200 or newer
> - * maveo box PCB number: 525-200 or newer
> + * maveo box PCB number: 625-200 or newer
Is the rev.200 correct , or is the base board still rev.100 ?

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/2] ARM: dts: imx6ull-dhcor-maveo-box: Remove unused SPI device
  2026-10-21 17:19 ` [PATCH 1/2] ARM: dts: imx6ull-dhcor-maveo-box: Remove unused SPI device Marek Vasut
@ 2026-10-21 18:37   ` Francesco Dolcini
  2026-10-21 18:55     ` Marek Vasut
  0 siblings, 1 reply; 12+ messages in thread
From: Francesco Dolcini @ 2026-10-21 18:37 UTC (permalink / raw)
  To: Marek Vasut
  Cc: Christoph Niedermaier, linux-arm-kernel, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Frank Li, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, devicetree, imx, kernel,
	linux-kernel

On Wed, Oct 21, 2026 at 07:19:30PM +0200, Marek Vasut wrote:
> On 10/21/26 3:44 PM, Christoph Niedermaier wrote:
> > On the maveo box, the SPI pins are connected to connector X10,
> > but no device is connected. The device "dhcom-board" was used
> > only to test the hardware, but was not removed afterward. So
> > remove this device to accurately represent the current hardware
> > configuration here.
> > 
> > Fixes: 145e2732a5e9 ("ARM: dts: imx6ull-dhcor: Add Marantec maveo box")
> > Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
> > ---
> > Cc: Rob Herring <robh@kernel.org>
> > Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
> > Cc: Conor Dooley <conor+dt@kernel.org>
> > Cc: Frank Li <Frank.Li@nxp.com>
> > Cc: Sascha Hauer <s.hauer@pengutronix.de>
> > Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
> > Cc: Fabio Estevam <festevam@gmail.com>
> > Cc: Marek Vasut <marex@nabladev.com>
> > Cc: devicetree@vger.kernel.org
> > Cc: imx@lists.linux.dev
> > Cc: kernel@dh-electronics.com
> > Cc: linux-kernel@vger.kernel.org
> > ---
> >   arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts | 8 --------
> >   1 file changed, 8 deletions(-)
> > 
> > diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
> > index 047f7b2d8526..eb0b91040110 100644
> > --- a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
> > +++ b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
> > @@ -60,14 +60,6 @@ &ecspi4 {
> >   	pinctrl-0 = <&pinctrl_ecspi4>;
> >   	pinctrl-names = "default";
> >   	status = "okay";
> 
> Drop "status = "okay"" too , since this controller will be unused ?

you can instantiate a new device on the SPI bus from userspace. up to
you, but if I was a user I would appreciate to have it enabled.

Francesco


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/2] ARM: dts: imx6ull-dhcor-maveo-box: Remove unused SPI device
  2026-10-21 18:37   ` Francesco Dolcini
@ 2026-10-21 18:55     ` Marek Vasut
  2026-10-22  9:12       ` Christoph Niedermaier
  0 siblings, 1 reply; 12+ messages in thread
From: Marek Vasut @ 2026-10-21 18:55 UTC (permalink / raw)
  To: Francesco Dolcini
  Cc: Christoph Niedermaier, linux-arm-kernel, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Frank Li, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, devicetree, imx, kernel,
	linux-kernel

On 10/21/26 8:37 PM, Francesco Dolcini wrote:
> On Wed, Oct 21, 2026 at 07:19:30PM +0200, Marek Vasut wrote:
>> On 10/21/26 3:44 PM, Christoph Niedermaier wrote:
>>> On the maveo box, the SPI pins are connected to connector X10,
>>> but no device is connected. The device "dhcom-board" was used
>>> only to test the hardware, but was not removed afterward. So
>>> remove this device to accurately represent the current hardware
>>> configuration here.
>>>
>>> Fixes: 145e2732a5e9 ("ARM: dts: imx6ull-dhcor: Add Marantec maveo box")
>>> Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
>>> ---
>>> Cc: Rob Herring <robh@kernel.org>
>>> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
>>> Cc: Conor Dooley <conor+dt@kernel.org>
>>> Cc: Frank Li <Frank.Li@nxp.com>
>>> Cc: Sascha Hauer <s.hauer@pengutronix.de>
>>> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
>>> Cc: Fabio Estevam <festevam@gmail.com>
>>> Cc: Marek Vasut <marex@nabladev.com>
>>> Cc: devicetree@vger.kernel.org
>>> Cc: imx@lists.linux.dev
>>> Cc: kernel@dh-electronics.com
>>> Cc: linux-kernel@vger.kernel.org
>>> ---
>>>    arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts | 8 --------
>>>    1 file changed, 8 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
>>> index 047f7b2d8526..eb0b91040110 100644
>>> --- a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
>>> +++ b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
>>> @@ -60,14 +60,6 @@ &ecspi4 {
>>>    	pinctrl-0 = <&pinctrl_ecspi4>;
>>>    	pinctrl-names = "default";
>>>    	status = "okay";
>>
>> Drop "status = "okay"" too , since this controller will be unused ?
> 
> you can instantiate a new device on the SPI bus from userspace. up to
> you, but if I was a user I would appreciate to have it enabled.
Good point -- Christoph, is this the (use)case here , can the user do that?

^ permalink raw reply	[flat|nested] 12+ messages in thread

* RE: [PATCH 2/2] ARM: dts: imx6ull-dhcor-maveo-box: Correct PCB number
  2026-10-21 17:20   ` Marek Vasut
@ 2026-10-22  8:59     ` Christoph Niedermaier
  2026-10-22 10:45       ` Marek Vasut
  0 siblings, 1 reply; 12+ messages in thread
From: Christoph Niedermaier @ 2026-10-22  8:59 UTC (permalink / raw)
  To: Marek Vasut, linux-arm-kernel
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, devicetree,
	imx, kernel, linux-kernel

From: Marek Vasut <marex@nabladev.com>
Sent: Wednesday, October 21, 2026 7:21 PM
> On 10/21/26 3:44 PM, Christoph Niedermaier wrote:
>> The PCB number of the maveo box isn't 525. Change the
>> number to the correct number, 625.
>>
>> Fixes: 145e2732a5e9 ("ARM: dts: imx6ull-dhcor: Add Marantec maveo box")
>> Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
>> ---
>> Cc: Rob Herring <robh@kernel.org>
>> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
>> Cc: Conor Dooley <conor+dt@kernel.org>
>> Cc: Frank Li <Frank.Li@nxp.com>
>> Cc: Sascha Hauer <s.hauer@pengutronix.de>
>> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
>> Cc: Fabio Estevam <festevam@gmail.com>
>> Cc: Marek Vasut <marex@nabladev.com>
>> Cc: devicetree@vger.kernel.org
>> Cc: imx@lists.linux.dev
>> Cc: kernel@dh-electronics.com
>> Cc: linux-kernel@vger.kernel.org
>> ---
>>   arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
>> index eb0b91040110..bb82d97f9d84 100644
>> --- a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
>> +++ b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
>> @@ -6,7 +6,7 @@
>>    * DHCOM iMX6ULL variant:
>>    * DHCR-iMX6ULL-C080-R051-SPI-WBT-I-01LG
>>    * DHCOR PCB number: 578-200 or newer
>> - * maveo box PCB number: 525-200 or newer
>> + * maveo box PCB number: 625-200 or newer
> Is the rev.200 correct , or is the base board still rev.100 ?

Hardware rev.100 was a prototype that was never shipped and
is not compatible with rev.200 or later.

Regards
Christoph

^ permalink raw reply	[flat|nested] 12+ messages in thread

* RE: [PATCH 1/2] ARM: dts: imx6ull-dhcor-maveo-box: Remove unused SPI device
  2026-10-21 18:55     ` Marek Vasut
@ 2026-10-22  9:12       ` Christoph Niedermaier
  2026-10-22  9:25         ` Francesco Dolcini
  0 siblings, 1 reply; 12+ messages in thread
From: Christoph Niedermaier @ 2026-10-22  9:12 UTC (permalink / raw)
  To: Marek Vasut, Francesco Dolcini
  Cc: linux-arm-kernel, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Frank Li, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	devicetree, imx, kernel, linux-kernel

From: Marek Vasut <marex@nabladev.com>
Sent: Wednesday, October 21, 2026 8:56 PM
> On 10/21/26 8:37 PM, Francesco Dolcini wrote:
>> On Wed, Oct 21, 2026 at 07:19:30PM +0200, Marek Vasut wrote:
>>> On 10/21/26 3:44 PM, Christoph Niedermaier wrote:
>>>> On the maveo box, the SPI pins are connected to connector X10,
>>>> but no device is connected. The device "dhcom-board" was used
>>>> only to test the hardware, but was not removed afterward. So
>>>> remove this device to accurately represent the current hardware
>>>> configuration here.
>>>>
>>>> Fixes: 145e2732a5e9 ("ARM: dts: imx6ull-dhcor: Add Marantec maveo box")
>>>> Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
>>>> ---
>>>> Cc: Rob Herring <robh@kernel.org>
>>>> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
>>>> Cc: Conor Dooley <conor+dt@kernel.org>
>>>> Cc: Frank Li <Frank.Li@nxp.com>
>>>> Cc: Sascha Hauer <s.hauer@pengutronix.de>
>>>> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
>>>> Cc: Fabio Estevam <festevam@gmail.com>
>>>> Cc: Marek Vasut <marex@nabladev.com>
>>>> Cc: devicetree@vger.kernel.org
>>>> Cc: imx@lists.linux.dev
>>>> Cc: kernel@dh-electronics.com
>>>> Cc: linux-kernel@vger.kernel.org
>>>> ---
>>>>    arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts | 8 --------
>>>>    1 file changed, 8 deletions(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
>>>> index 047f7b2d8526..eb0b91040110 100644
>>>> --- a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
>>>> +++ b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
>>>> @@ -60,14 +60,6 @@ &ecspi4 {
>>>>     pinctrl-0 = <&pinctrl_ecspi4>;
>>>>     pinctrl-names = "default";
>>>>     status = "okay";
>>>
>>> Drop "status = "okay"" too , since this controller will be unused ?
>>
>> you can instantiate a new device on the SPI bus from userspace. up to
>> you, but if I was a user I would appreciate to have it enabled.
> Good point -- Christoph, is this the (use)case here , can the user do that?

I don't think that's the case, since there isn't currently an SPI device
connected to this interface. Nevertheless, I'd be interested to know how
to instantiate a new device from user space.

Regards
Christoph

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/2] ARM: dts: imx6ull-dhcor-maveo-box: Remove unused SPI device
  2026-10-22  9:12       ` Christoph Niedermaier
@ 2026-10-22  9:25         ` Francesco Dolcini
  2026-10-22 10:58           ` Christoph Niedermaier
  0 siblings, 1 reply; 12+ messages in thread
From: Francesco Dolcini @ 2026-10-22  9:25 UTC (permalink / raw)
  To: Christoph Niedermaier
  Cc: Marek Vasut, Francesco Dolcini, linux-arm-kernel, Rob Herring,
	Krzysztof Kozlowski, Conor Dooley, Frank Li, Sascha Hauer,
	Pengutronix Kernel Team, Fabio Estevam, devicetree, imx, kernel,
	linux-kernel

Hello Christoph,

On Thu, Oct 22, 2026 at 09:12:12AM +0000, Christoph Niedermaier wrote:
> From: Marek Vasut <marex@nabladev.com>
> Sent: Wednesday, October 21, 2026 8:56 PM
> > On 10/21/26 8:37 PM, Francesco Dolcini wrote:
> >> On Wed, Oct 21, 2026 at 07:19:30PM +0200, Marek Vasut wrote:
> >>> On 10/21/26 3:44 PM, Christoph Niedermaier wrote:

[...]

> >>>> --- a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
> >>>> +++ b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
> >>>> @@ -60,14 +60,6 @@ &ecspi4 {
> >>>>     pinctrl-0 = <&pinctrl_ecspi4>;
> >>>>     pinctrl-names = "default";
> >>>>     status = "okay";
> >>>
> >>> Drop "status = "okay"" too , since this controller will be unused ?
> >>
> >> you can instantiate a new device on the SPI bus from userspace. up to
> >> you, but if I was a user I would appreciate to have it enabled.
> > Good point -- Christoph, is this the (use)case here , can the user do that?
> 
> I don't think that's the case, since there isn't currently an SPI device
> connected to this interface. Nevertheless, I'd be interested to know how
> to instantiate a new device from user space.

Documentation/spi/instantiating-devices.rst

Francesco


^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 2/2] ARM: dts: imx6ull-dhcor-maveo-box: Correct PCB number
  2026-10-22  8:59     ` Christoph Niedermaier
@ 2026-10-22 10:45       ` Marek Vasut
  0 siblings, 0 replies; 12+ messages in thread
From: Marek Vasut @ 2026-10-22 10:45 UTC (permalink / raw)
  To: Christoph Niedermaier, linux-arm-kernel
  Cc: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Frank Li,
	Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam, devicetree,
	imx, kernel, linux-kernel

On 10/22/26 10:59 AM, Christoph Niedermaier wrote:
> From: Marek Vasut <marex@nabladev.com>
> Sent: Wednesday, October 21, 2026 7:21 PM
>> On 10/21/26 3:44 PM, Christoph Niedermaier wrote:
>>> The PCB number of the maveo box isn't 525. Change the
>>> number to the correct number, 625.
>>>
>>> Fixes: 145e2732a5e9 ("ARM: dts: imx6ull-dhcor: Add Marantec maveo box")
>>> Signed-off-by: Christoph Niedermaier <cniedermaier@dh-electronics.com>
>>> ---
>>> Cc: Rob Herring <robh@kernel.org>
>>> Cc: Krzysztof Kozlowski <krzk+dt@kernel.org>
>>> Cc: Conor Dooley <conor+dt@kernel.org>
>>> Cc: Frank Li <Frank.Li@nxp.com>
>>> Cc: Sascha Hauer <s.hauer@pengutronix.de>
>>> Cc: Pengutronix Kernel Team <kernel@pengutronix.de>
>>> Cc: Fabio Estevam <festevam@gmail.com>
>>> Cc: Marek Vasut <marex@nabladev.com>
>>> Cc: devicetree@vger.kernel.org
>>> Cc: imx@lists.linux.dev
>>> Cc: kernel@dh-electronics.com
>>> Cc: linux-kernel@vger.kernel.org
>>> ---
>>>    arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts | 2 +-
>>>    1 file changed, 1 insertion(+), 1 deletion(-)
>>>
>>> diff --git a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
>>> index eb0b91040110..bb82d97f9d84 100644
>>> --- a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
>>> +++ b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
>>> @@ -6,7 +6,7 @@
>>>     * DHCOM iMX6ULL variant:
>>>     * DHCR-iMX6ULL-C080-R051-SPI-WBT-I-01LG
>>>     * DHCOR PCB number: 578-200 or newer
>>> - * maveo box PCB number: 525-200 or newer
>>> + * maveo box PCB number: 625-200 or newer
>> Is the rev.200 correct , or is the base board still rev.100 ?
> 
> Hardware rev.100 was a prototype that was never shipped and
> is not compatible with rev.200 or later.
OK

^ permalink raw reply	[flat|nested] 12+ messages in thread

* RE: [PATCH 1/2] ARM: dts: imx6ull-dhcor-maveo-box: Remove unused SPI device
  2026-10-22  9:25         ` Francesco Dolcini
@ 2026-10-22 10:58           ` Christoph Niedermaier
  2026-10-22 11:34             ` Marek Vasut
  0 siblings, 1 reply; 12+ messages in thread
From: Christoph Niedermaier @ 2026-10-22 10:58 UTC (permalink / raw)
  To: Francesco Dolcini, Marek Vasut
  Cc: linux-arm-kernel, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Frank Li, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	devicetree, imx, kernel, linux-kernel

From: Francesco Dolcini <francesco@dolcini.it>
Sent: Thursday, October 22, 2026 11:26 AM
> 
> Hello Christoph,
> 
> On Thu, Oct 22, 2026 at 09:12:12AM +0000, Christoph Niedermaier wrote:
>> From: Marek Vasut <marex@nabladev.com>
>> Sent: Wednesday, October 21, 2026 8:56 PM
>>> On 10/21/26 8:37 PM, Francesco Dolcini wrote:
>>>> On Wed, Oct 21, 2026 at 07:19:30PM +0200, Marek Vasut wrote:
>>>>> On 10/21/26 3:44 PM, Christoph Niedermaier wrote:
> 
> [...]
> 
>>>>>> --- a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
>>>>>> +++ b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
>>>>>> @@ -60,14 +60,6 @@ &ecspi4 {
>>>>>>     pinctrl-0 = <&pinctrl_ecspi4>;
>>>>>>     pinctrl-names = "default";
>>>>>>     status = "okay";
>>>>>
>>>>> Drop "status = "okay"" too , since this controller will be unused ?
>>>>
>>>> you can instantiate a new device on the SPI bus from userspace. up to
>>>> you, but if I was a user I would appreciate to have it enabled.
>>> Good point -- Christoph, is this the (use)case here , can the user do that?
>>
>> I don't think that's the case, since there isn't currently an SPI device
>> connected to this interface. Nevertheless, I'd be interested to know how
>> to instantiate a new device from user space.
> 
> Documentation/spi/instantiating-devices.rst

This is a relatively new document, I haven't seen it yet. Thank you very much.

I'm now leaning toward leaving the interface set to “okay” so that the existing
SPI pins on X10 connector can easily accessed in the future.

@Marek: If you insist, I can also remove the status line.


Regards
Christoph

^ permalink raw reply	[flat|nested] 12+ messages in thread

* Re: [PATCH 1/2] ARM: dts: imx6ull-dhcor-maveo-box: Remove unused SPI device
  2026-10-22 10:58           ` Christoph Niedermaier
@ 2026-10-22 11:34             ` Marek Vasut
  0 siblings, 0 replies; 12+ messages in thread
From: Marek Vasut @ 2026-10-22 11:34 UTC (permalink / raw)
  To: Christoph Niedermaier, Francesco Dolcini
  Cc: linux-arm-kernel, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
	Frank Li, Sascha Hauer, Pengutronix Kernel Team, Fabio Estevam,
	devicetree, imx, kernel, linux-kernel

On 10/22/26 12:58 PM, Christoph Niedermaier wrote:

Hello Christoph,

>>>>>>> --- a/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
>>>>>>> +++ b/arch/arm/boot/dts/nxp/imx/imx6ull-dhcor-maveo-box.dts
>>>>>>> @@ -60,14 +60,6 @@ &ecspi4 {
>>>>>>>      pinctrl-0 = <&pinctrl_ecspi4>;
>>>>>>>      pinctrl-names = "default";
>>>>>>>      status = "okay";
>>>>>>
>>>>>> Drop "status = "okay"" too , since this controller will be unused ?
>>>>>
>>>>> you can instantiate a new device on the SPI bus from userspace. up to
>>>>> you, but if I was a user I would appreciate to have it enabled.
>>>> Good point -- Christoph, is this the (use)case here , can the user do that?
>>>
>>> I don't think that's the case, since there isn't currently an SPI device
>>> connected to this interface. Nevertheless, I'd be interested to know how
>>> to instantiate a new device from user space.
>>
>> Documentation/spi/instantiating-devices.rst
> 
> This is a relatively new document, I haven't seen it yet. Thank you very much.
> 
> I'm now leaning toward leaving the interface set to “okay” so that the existing
> SPI pins on X10 connector can easily accessed in the future.

If you connect anything more complex than a simple device, you would 
anyway need a DT overlay for this.

> @Marek: If you insist, I can also remove the status line.
Either way is fine by me, but consider the above.

^ permalink raw reply	[flat|nested] 12+ messages in thread

end of thread, other threads:[~2026-10-22 12:55 UTC | newest]

Thread overview: 12+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2026-10-21 13:44 [PATCH 1/2] ARM: dts: imx6ull-dhcor-maveo-box: Remove unused SPI device Christoph Niedermaier
2026-10-21 13:44 ` [PATCH 2/2] ARM: dts: imx6ull-dhcor-maveo-box: Correct PCB number Christoph Niedermaier
2026-10-21 17:20   ` Marek Vasut
2026-10-22  8:59     ` Christoph Niedermaier
2026-10-22 10:45       ` Marek Vasut
2026-10-21 17:19 ` [PATCH 1/2] ARM: dts: imx6ull-dhcor-maveo-box: Remove unused SPI device Marek Vasut
2026-10-21 18:37   ` Francesco Dolcini
2026-10-21 18:55     ` Marek Vasut
2026-10-22  9:12       ` Christoph Niedermaier
2026-10-22  9:25         ` Francesco Dolcini
2026-10-22 10:58           ` Christoph Niedermaier
2026-10-22 11:34             ` Marek Vasut

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®