From: Matheus Tagliari <mptagliari@gmail.com>
To: "Alex Deucher" <alexdeucher@gmail.com>,
"Timur Kristóf" <timur.kristof@gmail.com>,
"Christian König" <christian.koenig@amd.com>
Cc: Matheus Tagliari <mptagliari@gmail.com>,
Alex Deucher <alexander.deucher@amd.com>,
David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] drm/radeon: process the VCE interrupt on SI and Trinity
Date: Tue, 27 Oct 2026 12:47:17 -0300 [thread overview]
Message-ID: <20261027154719.155006-1-mptagliari@gmail.com> (raw)
In-Reply-To: <CADnq5_OGgbFOJtBu7SwvvnaN01F=RSqtxZgBhJ1fty4pwBHmVg@mail.gmail.com>
Hi Alex, Timur, Christian,
Thanks Alex for picking these up, and Christian for the Trinity
background.
Timur, yes, that is possible. The only place where Trinity/Richland
gets the interrupt enabled is the family check in vce_v1_0_start() in
patch 2. Today it reads "rdev->family < CHIP_BONAIRE", which also
matches CHIP_ARUBA. Narrowing it to
if (rdev->family >= CHIP_TAHITI && rdev->family < CHIP_BONAIRE)
enables it on Tahiti, Pitcairn, Verde, Oland and Hainan only, and
leaves Trinity/Richland (and CIK) as they were. I built vce_v1_0.o
with that change against 6.12 and checked the gate against the
radeon_family enum: SI on, ARUBA and CIK off. On SI the generated
code is the same register write I tested on the Cape Verde card, so
the earlier results still apply there. I cannot test the Trinity side.
The handling added to evergreen_irq_process() by patch 1 stays
harmless on Trinity: with the trap interrupt left disabled it is
never raised.
Since the series is already applied, I did not want to send a v3 on
top of it unasked. If Christian would still prefer to keep Trinity
out of the picture, especially for stable, I can send this as a
small follow-up against the current tree right away. Otherwise I
will leave it as it is.
Thanks,
Matheus
next prev parent reply other threads:[~2026-10-27 15:47 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-22 11:47 [PATCH v2 0/2] drm/radeon: fix VCE1 encoding on SI by handling the VCE interrupt Matheus Tagliari
2026-10-22 11:47 ` [PATCH v2 1/2] drm/radeon: process the VCE interrupt on SI and Trinity Matheus Tagliari
2026-10-26 8:22 ` Christian König
2026-10-26 13:02 ` Matheus Tagliari
2026-10-26 22:41 ` Timur Kristóf
2026-10-27 0:15 ` Matheus Tagliari
2026-10-27 10:21 ` Christian König
2026-10-27 14:24 ` Timur Kristóf
2026-10-27 14:39 ` Alex Deucher
2026-10-27 15:47 ` Matheus Tagliari [this message]
2026-10-22 11:47 ` [PATCH v2 2/2] drm/radeon/vce1: enable the VCE trap interrupt Matheus Tagliari
2026-10-22 15:12 ` [PATCH v2 0/2] drm/radeon: fix VCE1 encoding on SI by handling the VCE interrupt Alex Deucher
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261027154719.155006-1-mptagliari@gmail.com \
--to=mptagliari@gmail.com \
--cc=airlied@gmail.com \
--cc=alexander.deucher@amd.com \
--cc=alexdeucher@gmail.com \
--cc=amd-gfx@lists.freedesktop.org \
--cc=christian.koenig@amd.com \
--cc=dri-devel@lists.freedesktop.org \
--cc=linux-kernel@vger.kernel.org \
--cc=simona@ffwll.ch \
--cc=timur.kristof@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®