mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: "Christian König" <christian.koenig@amd.com>
To: "Matheus Tagliari" <mptagliari@gmail.com>,
	"Timur Kristóf" <timur.kristof@gmail.com>,
	"Alex Deucher" <alexander.deucher@amd.com>
Cc: David Airlie <airlied@gmail.com>, Simona Vetter <simona@ffwll.ch>,
	amd-gfx@lists.freedesktop.org, dri-devel@lists.freedesktop.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 1/2] drm/radeon: process the VCE interrupt on SI and Trinity
Date: Tue, 27 Oct 2026 11:21:19 +0100	[thread overview]
Message-ID: <6e0b5af2-692a-4b2f-ae20-9c164e7e42ed@amd.com> (raw)
In-Reply-To: <20261027001506.27266-1-mptagliari@gmail.com>

On 10/27/26 01:15, Matheus Tagliari wrote:
> Hi Timur, Christian,
> 
> Thanks for the input, Timur.
> 
> To be clear, I'm not opposed to a backport. Fixing VCE1 for people stuck
> on the radeon driver with an LTS kernel is exactly the case that made me
> look into this in the first place. But my goal is only to help, and as I
> said before, I do not want to push a change you don't want.
> 
> Christian, if you'd rather keep this out of stable, I'll drop the
> "Cc: stable" tag in v3 and leave the decision to you. If there is a
> specific concern behind it (risk of regressions on other SI/Trinity
> parts, say), I'd be glad to hear it. I can also try to address it, for
> example with more testing, so that a backport can be reconsidered later.

I was part of the Trinity bringup back (I still have the engineering sample here :) and I filled a full swear jar bringing VCE up on that HW.

Interrupts were definitely not working correctly back then.

I have no idea when they were fixed but I want to avoid that people start streaming that this change made their system not boot any more and we are forced to revert a patch on stable kernels everywhere.

> On that note, the SI part was tested on real hardware together with
> patch 2, but the Trinity/Richland part only mirrors the existing CIK and
> SI handling and has not been tested on hardware. If anyone has a
> Trinity or Richland machine and can run a VCE encode with the series
> applied, a Tested-by would help for both the review and any backport
> discussion.

I'm pretty sure my engineering sample doesn't work any more. That was an A0 stepping and those boards are only stitched together to work for a few weeks/month during initial HW bringup.

Regards,
Christian.

> Either way, I'll respin v3 with whatever you both prefer.
> 
> Thanks,
> Matheus


  reply	other threads:[~2026-10-27 10:21 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-22 11:47 [PATCH v2 0/2] drm/radeon: fix VCE1 encoding on SI by handling the VCE interrupt Matheus Tagliari
2026-10-22 11:47 ` [PATCH v2 1/2] drm/radeon: process the VCE interrupt on SI and Trinity Matheus Tagliari
2026-10-26  8:22   ` Christian König
2026-10-26 13:02     ` Matheus Tagliari
2026-10-26 22:41     ` Timur Kristóf
2026-10-27  0:15       ` Matheus Tagliari
2026-10-27 10:21         ` Christian König [this message]
2026-10-27 14:24           ` Timur Kristóf
2026-10-27 14:39             ` Alex Deucher
2026-10-27 15:47               ` Matheus Tagliari
2026-10-22 11:47 ` [PATCH v2 2/2] drm/radeon/vce1: enable the VCE trap interrupt Matheus Tagliari
2026-10-22 15:12 ` [PATCH v2 0/2] drm/radeon: fix VCE1 encoding on SI by handling the VCE interrupt Alex Deucher

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=6e0b5af2-692a-4b2f-ae20-9c164e7e42ed@amd.com \
    --to=christian.koenig@amd.com \
    --cc=airlied@gmail.com \
    --cc=alexander.deucher@amd.com \
    --cc=amd-gfx@lists.freedesktop.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mptagliari@gmail.com \
    --cc=simona@ffwll.ch \
    --cc=timur.kristof@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®