Re: [PATCH v2 24/24] ARM: dts: zte: Add ZTE ZXHN H3600 board

[Navid Ghahremani <ghahramani.navid@gmail.com>]

Hi Agustin,

Agustin Santiago wrote:
> Does your unit really have 512 MiB? If both sizes exist, maybe leave
> the size to the boot loader or use the smaller one.

Yes, the boot loader on my unit reports 512 MiB, so both sizes exist.
The next version will describe 256 MiB, which works on both, and drop
the pp node since nothing uses it. A comment at the memory node and the
commit message will say how to use all 512 MiB. You can enable
CONFIG_ARM_ATAG_DTB_COMPAT so the boot loader's ATAG_MEM sets the size
like on your unit, boot with mem=512M, or change the size in the node.

> As far as I can see nothing in mainline implements the cell index for
> "mac-base" here, so all five ports get the same address

You are right, nothing in v7.4-rc1 applies it. My unit has the WAN
address at 0x36 too. It stores four addresses at 0x1e, 0x36, 0x4e and
0x66 that are one apart. The next version will use two plain cells like
you suggest, 0x1e for the LAN ports and 0x36 for wan.

Best regards,
Navid