Re: [PATCH v2 04/24] dt-bindings: clock: Add ZTE ZX279128S CRM clock bindings

[Navid Ghahremani <ghahramani.navid@gmail.com>]

Hi Stefan,

Stefan Dösinger wrote:
> This would be easier to review if it were split in 3 patches, one yaml per
> patch.

The next version will have one binding per patch.

> Afaiu this makes "syscon" optional. Why do you need syscon? Why might you not
> need syscon?

It turned out I don't need it, so I dropped syscon from crm2 in my
tree. All I have found in crm2 so far are the PCIe clock gates and
resets.

> I think you should be the maintainer alone here, I don't have the hardware to
> do proper testing of patches.

OK, I will be the only maintainer there.

> I think splitting those into different bindings is still a viable choice.

The next version will have separate bindings for lsp0crpm and
lsp1crpm.

> You can drop the phy child node and just add "#phy-cells=1".

Will do. topcrm gets #phy-cells = <1> and no PHY child nodes, and once
topcrm is an MFD the PHY driver will use device_set_of_node_from_dev()
like you described.

> I'd suggest to rename clock/zte,zx279128s-crm.h to clock/zte,zx279128s-clk.h.

Will do.

> Do they all need to be exported? You only need those that will be used for a
> clock = <&topcrm ZX279128S_TOP_SOMETHING> handle.

No. The next version will only export the clocks that device tree nodes
use, mostly gates, and the PLLs stay inside the driver.

You also asked on the RFC whether lsp0crpm really has no resets. I have
not tested that yet. I will try your method on the router, clearing the
bits, seeing what breaks and then checking whether the device kept its
state, and I will reply with what I find.

Best regards,
Navid