From: Shrikanth Hegde <sshegde@linux.ibm.com>
To: Steven Rostedt <rostedt@goodmis.org>
Cc: Valentin Schneider <vschneid@redhat.com>,
LKML <linux-kernel@vger.kernel.org>,
Peter Zijlstra <peterz@infradead.org>, Tejun Heo <tj@kernel.org>,
Juri Lelli <juri.lelli@redhat.com>,
Vincent Guittot <vincent.guittot@linaro.org>,
Dietmar Eggemann <dietmar.eggemann@arm.com>,
Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
K Prateek Nayak <kprateek.nayak@amd.com>,
Kyle McMartin <jkkm@meta.com>
Subject: Re: [PATCH v2] sched/rt: Have RT_PUSH_IPI be default off for non PREEMPT_RT
Date: Wed, 20 May 2026 22:34:35 +0530 [thread overview]
Message-ID: <310c1f04-562e-4e81-9d39-0f28e1cc414c@linux.ibm.com> (raw)
In-Reply-To: <20260520125226.50b83e76@gandalf.local.home>
On 5/20/26 10:22 PM, Steven Rostedt wrote:
> On Wed, 20 May 2026 12:03:37 +0530
> Shrikanth Hegde <sshegde@linux.ibm.com> wrote:
>
>> On 5/18/26 2:17 PM, Valentin Schneider wrote:
>>> On 15/05/26 10:37, Steven Rostedt wrote:
>>
>>> I got a bit confused here, please correct me if I didn't get this right:
>>>
>>> Per handle_softirqs(), we can't restart the softirq handling loop if
>>> need_resched() is true (which would be the case here, per what we'd have
>>> done it push_rt_task(@pull=true)).
>>> I thought this meant softirqs couldn't be the issue, however this is only
>>> valid within the scope of a single handle_softirqs() invocation.
>>>
>>> AIUI here we're being hammered by IRQs, thus under this sort of pattern:
>>>
>>> <IRQ>
>>> __irq_exit_rcu()
>>> invoke_softirq()
>>> handle_softirqs()
>>> // handle NET_RX_SOFTIRQ
>>> // need_resched() is true so don't loop
>>> </IRQ>
>>>
>>
>> Wouldn't IRQ exit call schedule if need_resched is set? via irqentry_exit_cond_resched ?
>
> I haven't looked at the networking code, but does NAPI just continue
> looping while there are packets to process? Or is there a check if
> need_resched() is set, that it will exit out early?
>
> Yeah, I'm still wondering why this causes a live lock.
>
> -- Steve
>
>
By any chance it is running with preempt=none/voluntary?
If so it might never call schedule until it goes back to user space.
>>
>>> // Barely any progress made here towards actually executing __schedule()
>>>
>>> <IRQ>
>>> __irq_exit_rcu()
>>> invoke_softirq()
>>> handle_softirqs()
>>> // handle NET_RX_SOFTIRQ and wake up some tasks
>>> // need_resched() is true so don't loop
>>> </IRQ>
>>>
>>> & repeat ad nauseam. Did I get this right?
>>>
>
next prev parent reply other threads:[~2026-05-20 17:05 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-15 14:37 Steven Rostedt
2026-05-15 17:17 ` Tejun Heo
2026-05-15 18:38 ` Steven Rostedt
2026-05-15 18:47 ` Tejun Heo
2026-05-15 18:56 ` Steven Rostedt
2026-05-15 22:27 ` Tejun Heo
2026-05-18 8:47 ` Valentin Schneider
2026-05-20 6:33 ` Shrikanth Hegde
2026-05-20 16:52 ` Steven Rostedt
2026-05-20 17:04 ` Shrikanth Hegde [this message]
2026-05-20 18:09 ` Tejun Heo
2026-05-20 19:02 ` Steven Rostedt
2026-05-20 19:37 ` Tejun Heo
2026-05-21 10:11 ` Valentin Schneider
2026-05-20 8:33 ` [tip: sched/core] " tip-bot2 for Steven Rostedt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=310c1f04-562e-4e81-9d39-0f28e1cc414c@linux.ibm.com \
--to=sshegde@linux.ibm.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=jkkm@meta.com \
--cc=juri.lelli@redhat.com \
--cc=kprateek.nayak@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mgorman@suse.de \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tj@kernel.org \
--cc=vincent.guittot@linaro.org \
--cc=vschneid@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®