mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Valentin Schneider <vschneid@redhat.com>
To: Shrikanth Hegde <sshegde@linux.ibm.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	LKML <linux-kernel@vger.kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>, Tejun Heo <tj@kernel.org>,
	Juri Lelli <juri.lelli@redhat.com>,
	Vincent Guittot <vincent.guittot@linaro.org>,
	Dietmar Eggemann <dietmar.eggemann@arm.com>,
	Ben Segall <bsegall@google.com>, Mel Gorman <mgorman@suse.de>,
	K Prateek Nayak <kprateek.nayak@amd.com>,
	Kyle McMartin <jkkm@meta.com>
Subject: Re: [PATCH v2] sched/rt: Have RT_PUSH_IPI be default off for non PREEMPT_RT
Date: Thu, 21 May 2026 12:11:31 +0200	[thread overview]
Message-ID: <xhsmhmrxtdqcs.mognet@vschneid-thinkpadt14sgen2i.remote.csb> (raw)
In-Reply-To: <61203cdb-af98-47e6-bb70-78af7f0f1cbc@linux.ibm.com>

On 20/05/26 12:03, Shrikanth Hegde wrote:
> On 5/18/26 2:17 PM, Valentin Schneider wrote:
>> On 15/05/26 10:37, Steven Rostedt wrote:
>
>> I got a bit confused here, please correct me if I didn't get this right:
>>
>> Per handle_softirqs(), we can't restart the softirq handling loop if
>> need_resched() is true (which would be the case here, per what we'd have
>> done it push_rt_task(@pull=true)).
>> I thought this meant softirqs couldn't be the issue, however this is only
>> valid within the scope of a single handle_softirqs() invocation.
>>
>> AIUI here we're being hammered by IRQs, thus under this sort of pattern:
>>
>> <IRQ>
>>    __irq_exit_rcu()
>>      invoke_softirq()
>>        handle_softirqs()
>>          // handle NET_RX_SOFTIRQ
>>          // need_resched() is true so don't loop
>> </IRQ>
>>
>
> Wouldn't IRQ exit call schedule if need_resched is set? via irqentry_exit_cond_resched ?
>

So as pointed out further down the thread it may not because of
PREEMPT_NONE.

Also; schedule is entered with preemption disabled and IRQs enabled, which
I think means in a stupidly network-busy scenario and !PREEMPT_RT,
IRQ+invoke_softirq() can significantly slow down the top half of
__schedule() itself.


  parent reply	other threads:[~2026-05-21 10:11 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-05-15 14:37 Steven Rostedt
2026-05-15 17:17 ` Tejun Heo
2026-05-15 18:38   ` Steven Rostedt
2026-05-15 18:47     ` Tejun Heo
2026-05-15 18:56       ` Steven Rostedt
2026-05-15 22:27         ` Tejun Heo
2026-05-18  8:47 ` Valentin Schneider
2026-05-20  6:33   ` Shrikanth Hegde
2026-05-20 16:52     ` Steven Rostedt
2026-05-20 17:04       ` Shrikanth Hegde
2026-05-20 18:09         ` Tejun Heo
2026-05-20 19:02           ` Steven Rostedt
2026-05-20 19:37             ` Tejun Heo
2026-05-21 10:11     ` Valentin Schneider [this message]
2026-05-20  8:33 ` [tip: sched/core] " tip-bot2 for Steven Rostedt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=xhsmhmrxtdqcs.mognet@vschneid-thinkpadt14sgen2i.remote.csb \
    --to=vschneid@redhat.com \
    --cc=bsegall@google.com \
    --cc=dietmar.eggemann@arm.com \
    --cc=jkkm@meta.com \
    --cc=juri.lelli@redhat.com \
    --cc=kprateek.nayak@amd.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mgorman@suse.de \
    --cc=peterz@infradead.org \
    --cc=rostedt@goodmis.org \
    --cc=sshegde@linux.ibm.com \
    --cc=tj@kernel.org \
    --cc=vincent.guittot@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®