Re: [PATCH v7 04/11] arm64: dts: qcom: ipq5210: Add support for WPS button

[Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>]

On 10/12/26 9:23 AM, Varadarajan Narayanan wrote:
> Add GPIO related nodes to enable WPS (Wi-Fi Protected Setup) in IPQ5210
> based RDPs.
> 
> Signed-off-by: Varadarajan Narayanan <varadarajan.narayanan@oss.qualcomm.com>
> ---
>  arch/arm64/boot/dts/qcom/ipq5210-rdp504-common.dtsi | 21 +++++++++++++++++++++
>  1 file changed, 21 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/ipq5210-rdp504-common.dtsi b/arch/arm64/boot/dts/qcom/ipq5210-rdp504-common.dtsi
> index 67f62c1acddb..7f90a2632b07 100644
> --- a/arch/arm64/boot/dts/qcom/ipq5210-rdp504-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/ipq5210-rdp504-common.dtsi
> @@ -6,6 +6,7 @@
>  /dts-v1/;
>  
>  #include <dt-bindings/gpio/gpio.h>
> +#include <dt-bindings/input/input.h>
>  #include "ipq5210.dtsi"
>  
>  / {
> @@ -17,6 +18,19 @@ chosen {
>  		stdout-path = "serial0";
>  	};
>  
> +	gpio-keys {
> +		compatible = "gpio-keys";
> +		pinctrl-0 = <&gpio_keys_default>;
> +		pinctrl-names = "default";
> +
> +		button-wps {
> +			label = "wps";

"WPS", capital letters please

with that:

Reviewed-by: Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>

Konrad